From 3ab48f5f5635be0e017bf867a9fe0bb0bb413830 Mon Sep 17 00:00:00 2001
From: xO-Tx <mou@odoo.com>
Date: Thu, 29 Oct 2020 18:13:27 +0000
Subject: [PATCH] [FIX] web_editor, website: restore footer visibility option

Making the footer visible after having made it disappear was not
possible anymore because of [1].

Part of https://github.com/odoo/odoo/pull/59624
task-2312878

[1]: https://github.com/odoo/odoo/commit/61ffe97d03deae0aee72568311c453d1cd3470c8

closes odoo/odoo#61275

X-original-commit: fab31e378d2069ff6f2bd18365de2f116a43b872
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
---
 .../static/src/js/editor/snippets.options.js  | 19 ++++++++++++++++++-
 .../static/src/js/editor/snippets.options.js  |  6 +++---
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js
index 50e6201634e..43568382bc8 100644
--- a/addons/web_editor/static/src/js/editor/snippets.options.js
+++ b/addons/web_editor/static/src/js/editor/snippets.options.js
@@ -290,6 +290,12 @@ const UserValueWidget = Widget.extend({
         this.el.classList.remove('o_we_widget_opened');
         this._userValueWidgets.forEach(widget => widget.close());
     },
+    /**
+     * Simulates the correct event on the element to make it active.
+     */
+    enable() {
+        this.$el.click();
+    },
     /**
      * @param {string} name
      * @returns {UserValueWidget|null}
@@ -728,6 +734,17 @@ const CheckboxUserValueWidget = ButtonUserValueWidget.extend({
         return this._super(...arguments);
     },
 
+    //--------------------------------------------------------------------------
+    // Public
+    //--------------------------------------------------------------------------
+
+    /**
+     * @override
+     */
+    enable() {
+        this.$('we-checkbox').click();
+    },
+
     //--------------------------------------------------------------------------
     // Handlers
     //--------------------------------------------------------------------------
@@ -3685,7 +3702,7 @@ registry.BackgroundToggler = SnippetOptionWidget.extend({
             // image: remove the background filter option.
             // TODO there probably is a better system to implement to do that
             const widget = this._requestUserValueWidgets('bg_filter_toggle_opt')[0];
-            widget.$el.click();
+            widget.enable();
         }
     },
 });
diff --git a/addons/website/static/src/js/editor/snippets.options.js b/addons/website/static/src/js/editor/snippets.options.js
index 45735d584b4..f566e4f6b9a 100644
--- a/addons/website/static/src/js/editor/snippets.options.js
+++ b/addons/website/static/src/js/editor/snippets.options.js
@@ -797,7 +797,7 @@ snippetOptions.registry.OptionsTab = snippetOptions.SnippetOptionWidget.extend({
         // TODO improve: hack to click on external image picker
         this.bodyImageType = widgetValue;
         const widget = this._requestUserValueWidgets(params.imagepicker)[0];
-        widget.$el.click();
+        widget.enable();
     },
     /**
      * @override
@@ -1696,7 +1696,7 @@ snippetOptions.registry.Parallax = snippetOptions.SnippetOptionWidget.extend({
             // The parallax option was enabled but the background image was
             // removed: disable the parallax option.
             const widget = this._requestUserValueWidgets('parallax_none_opt')[0];
-            widget.$el.click();
+            widget.enable();
             widget.getParent().close(); // FIXME remove this ugly hack asap
         }
     },
@@ -1842,7 +1842,7 @@ const VisibilityPageOptionUpdate = snippetOptions.SnippetOptionWidget.extend({
         // toggled (otherwise it would be about editing an element which
         // is actually never displayed on the page).
         const widget = this._requestUserValueWidgets(this.showOptionWidgetName)[0];
-        widget.$el.click();
+        widget.enable();
     },
 
     //--------------------------------------------------------------------------