From 39d0f387387b0ce01a41dc8f8329b479680c4c48 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Fri, 10 Jun 2022 15:10:26 +0000
Subject: [PATCH] [FIX] product,*: empty group in view

Since #75862, the group "Upsell & Cross Sell" was shown in the "Sales"
tab of the product views, even if empty (its content is only defined in modules
sale_product_configurator & website_sale).

This commit makes sure that the group is invisible while it has no content.

closes odoo/odoo#93504

X-original-commit: 4f6c15f07141da80525e0c361a6fa19374ef4c2c
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
 addons/product/views/product_views.xml                         | 2 +-
 .../sale_product_configurator/views/product_template_views.xml | 3 +++
 addons/website_sale/views/product_views.xml                    | 3 +++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/addons/product/views/product_views.xml b/addons/product/views/product_views.xml
index 0980f3597ef..c22739ee4a1 100644
--- a/addons/product/views/product_views.xml
+++ b/addons/product/views/product_views.xml
@@ -101,7 +101,7 @@
                         </page>
                         <page string="Sales" attrs="{'invisible':[('sale_ok','=',False)]}" name="sales" invisible="1">
                             <group name="sale">
-                                <group string="Upsell &amp; Cross-Sell" name="upsell"/>
+                                <group string="Upsell &amp; Cross-Sell" name="upsell" invisible="1"/>
                             </group>
                             <group>
                                 <group string="Sales Description" name="description">
diff --git a/addons/sale_product_configurator/views/product_template_views.xml b/addons/sale_product_configurator/views/product_template_views.xml
index e3cdbfc7583..b7a93a62e15 100644
--- a/addons/sale_product_configurator/views/product_template_views.xml
+++ b/addons/sale_product_configurator/views/product_template_views.xml
@@ -6,6 +6,9 @@
         <field name="model">product.template</field>
         <field name="inherit_id" ref="product.product_template_form_view"/>
         <field name="arch" type="xml">
+            <group name="upsell" position="attributes">
+                <attribute name="invisible">0</attribute>
+            </group>
             <group name="upsell" position="inside">
                 <field name="optional_product_ids"
                     widget="many2many_tags"
diff --git a/addons/website_sale/views/product_views.xml b/addons/website_sale/views/product_views.xml
index 8112e1869fd..4cd15540563 100644
--- a/addons/website_sale/views/product_views.xml
+++ b/addons/website_sale/views/product_views.xml
@@ -142,6 +142,9 @@
             <div name="button_box" position="inside">
                 <field name="is_published" widget="website_redirect_button" attrs="{'invisible': [('sale_ok','=',False)]}"/>
             </div>
+            <group name="upsell" position="attributes">
+                <attribute name="invisible">0</attribute>
+            </group>
             <xpath expr="//group[@name='upsell']" position="inside">
                 <field name="accessory_product_ids" widget="many2many_tags" attrs="{'invisible': [('sale_ok','=',False)]}"
                        placeholder="Suggested accessories in the eCommerce cart"/>