From 38464f5aaf13f1ce09b231a5dfd90fae96ddaaa3 Mon Sep 17 00:00:00 2001 From: Nicolas Lempereur Date: Fri, 9 Apr 2021 14:56:42 +0000 Subject: [PATCH] [FIX] web_editor: have transcoder apply text-decoration The transcoder (transforming CSS rules into inline CSS for mail clients) was not working for text-decoration property because it would transform text-decoration values in: {'text-decoration-thickness': 'normal', 'text-decoration': none} And the regex that ensures we don't add duplicates check if there is: "(^|;)\s*text-decoration" so if there is text-decoration-thickness, text-decoration is not added. The regexp could be changed to: "(^|;)\s*text-decoration[^\w-]" but we already have special case for other text-decoration-* properties. With this change we should get text-decoration applied in: - edit mode (was already the case) - readonly mode (new) - mail client (only if mail client does not override it) As a side note: text-decoration-thickness seems to be rather new[^1] so at one point in time there was probably no issue. [^1]: https://developer.mozilla.org/docs/Web/CSS/text-decoration-thickness opw-2496490 closes odoo/odoo#69078 X-original-commit: f4f1b890e15e98d9a7e72586faf73327d3f7b716 Signed-off-by: Nicolas Lempereur (nle) Co-authored-by: Kamen Zhekov --- addons/web_editor/static/src/js/backend/convert_inline.js | 1 + 1 file changed, 1 insertion(+) diff --git a/addons/web_editor/static/src/js/backend/convert_inline.js b/addons/web_editor/static/src/js/backend/convert_inline.js index 2ca27272ea6..fa48a92208c 100644 --- a/addons/web_editor/static/src/js/backend/convert_inline.js +++ b/addons/web_editor/static/src/js/backend/convert_inline.js @@ -154,6 +154,7 @@ function getMatchedCSSRules(a) { delete style['text-decoration-line']; delete style['text-decoration-color']; delete style['text-decoration-style']; + delete style['text-decoration-thickness']; } // text-align inheritance does not seem to get past elements on some