From 37ffc45883b6a8ad758d5f341f0b5a3dfa540140 Mon Sep 17 00:00:00 2001 From: "rpa (Open ERP)" Date: Thu, 4 Nov 2010 17:41:48 +0530 Subject: [PATCH] [FIX,REF]: stock: Code refactoring lp bug: https://launchpad.net/bugs/666781 fixed bzr revid: rpa@tinyerp.com-20101104121148-g4cqx1bocnmxsued --- addons/stock/wizard/stock_return_picking.py | 3 +-- addons/stock/wizard/stock_split_move.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/addons/stock/wizard/stock_return_picking.py b/addons/stock/wizard/stock_return_picking.py index 78852202440..cf6f7c4b1bd 100644 --- a/addons/stock/wizard/stock_return_picking.py +++ b/addons/stock/wizard/stock_return_picking.py @@ -149,10 +149,9 @@ class stock_return_picking(osv.osv_memory): new_picking = None date_cur = time.strftime('%Y-%m-%d %H:%M:%S') - move_ids = [m.id for m in [line for line in pick.move_lines]] set_invoice_state_to_none = True returned_lines = 0 - for move in move_obj.browse(cr, uid, move_ids): + for move in pick.move_lines: if not new_picking: if pick.type=='out': new_type = 'in' diff --git a/addons/stock/wizard/stock_split_move.py b/addons/stock/wizard/stock_split_move.py index f3e72bfdc11..92262648272 100644 --- a/addons/stock/wizard/stock_split_move.py +++ b/addons/stock/wizard/stock_split_move.py @@ -104,8 +104,7 @@ class stock_split_move_line(osv.osv_memory): pick_obj = self.pool.get('stock.picking') pick = pick_obj.browse(cr, uid, record_id, context=context) data = self.read(cr, uid, ids[0]) - move_ids = [m.id for m in [line for line in pick.move_lines]] - for move in move_obj.browse(cr, uid, move_ids, context=context): + for move in pick.move_lines: quantity = data['move%s' % move.id] if 0 < quantity < move.product_qty: new_qty = move.product_qty - quantity