From 37c4e24e6956f64d564577bd9ef457392bd62f92 Mon Sep 17 00:00:00 2001
From: Raphael Collet <rco@openerp.com>
Date: Mon, 21 Dec 2015 15:09:43 +0100
Subject: [PATCH] [IMP] crm: adapt model `crm.team` to the mail alias mixin

---
 addons/crm/sales_team.py | 57 +++++++++++-----------------------------
 1 file changed, 16 insertions(+), 41 deletions(-)

diff --git a/addons/crm/sales_team.py b/addons/crm/sales_team.py
index 3a6fbb4778c..d66fa07c2f6 100644
--- a/addons/crm/sales_team.py
+++ b/addons/crm/sales_team.py
@@ -6,8 +6,8 @@ from openerp.tools.translate import _
 
 
 class crm_team(osv.Model):
-    _inherit = 'crm.team'
-    _inherits = {'mail.alias': 'alias_id'}
+    _name = 'crm.team'
+    _inherit = ['mail.alias.mixin', 'crm.team']
 
     _columns = {
         'resource_calendar_id': fields.many2one('resource.calendar', "Working Time", help="Used to compute open days"),
@@ -17,62 +17,37 @@ class crm_team(osv.Model):
         'alias_id': fields.many2one('mail.alias', 'Alias', ondelete="restrict", required=True, help="The email address associated with this team. New emails received will automatically create new leads assigned to the team."),
     }
 
-    def _auto_init(self, cr, context=None):
-        """Installation hook to create aliases for all lead and avoid constraint errors."""
-        return self.pool.get('mail.alias').migrate_to_alias(cr, self._name, self._table, super(crm_team, self)._auto_init,
-            'crm.lead', self._columns['alias_id'], 'name', alias_prefix='Lead+', alias_defaults={}, context=context)
-
     _defaults = {
         'use_opportunities': True,
     }
 
+    def get_alias_model_name(self, vals):
+        return 'crm.lead'
+
+    def get_alias_values(self):
+        has_group_use_lead = self.env['res.users'].has_group('crm.group_use_lead')
+        values = super(crm_team, self).get_alias_values()
+        values['alias_defaults'] = defaults = eval(self.alias_defaults or "{}")
+        defaults['type'] = 'lead' if has_group_use_lead and self.use_leads else 'opportunity'
+        defaults['team_id'] = self.id
+        return values
+
     def onchange_use_leads_opportunities(self, cr, uid, ids, use_leads, use_opportunities, context=None):
         if use_leads or use_opportunities:
             return {'value': {}}
         return {'value': {'alias_name': False}}
 
-    def _get_alias_defaults_values(self, cr, uid, ids, context=None):
-        res = dict.fromkeys(ids, False)
-        is_group_use_lead = self.pool['res.users'].has_group(cr, uid, 'crm.group_use_lead')
-        for team in self.browse(cr, uid, ids, context=context):
-            alias_defaults = eval(team.alias_defaults)
-            alias_defaults.update({
-                'type': 'lead' if is_group_use_lead and team.use_leads else 'opportunity',
-                'team_id': team.id,
-            })
-            res[team.id] = {
-                'alias_defaults': alias_defaults,
-                'alias_parent_thread_id': team.id,
-            }
-        return res
-
     def create(self, cr, uid, vals, context=None):
-        if context is None:
-            context = {}
-        create_context = dict(context, alias_model_name='crm.lead', alias_parent_model_name=self._name)
         generate_alias_name = self.pool['ir.values'].get_default(cr, uid, 'sales.config.settings', 'generate_sales_team_alias')
         if generate_alias_name and not vals.get('alias_name'):
             vals['alias_name'] = vals.get('name')
-        team_id = super(crm_team, self).create(cr, uid, vals, context=create_context)
-        self.write(cr, uid, [team_id],
-                   self._get_alias_defaults_values(cr, uid, [team_id], context=context)[team_id],
-                   context=context)
-        return team_id
+        return super(crm_team, self).create(cr, uid, vals, context=context)
 
     def write(self, cr, uid, ids, vals, context=None):
         res = super(crm_team, self).write(cr, uid, ids, vals, context=context)
         if vals.get('use_leads') or vals.get('alias_defaults'):
-            alias_res = self._get_alias_defaults_values(cr, uid, ids, context=context)
-            for team_id, values in alias_res.iteritems():
-                super(crm_team, self).write(cr, uid, [team_id], values, context=context)
-        return res
-
-    def unlink(self, cr, uid, ids, context=None):
-        # Cascade-delete mail aliases as well, as they should not exist without the sales team.
-        mail_alias = self.pool.get('mail.alias')
-        alias_ids = [team.alias_id.id for team in self.browse(cr, uid, ids, context=context) if team.alias_id]
-        res = super(crm_team, self).unlink(cr, uid, ids, context=context)
-        mail_alias.unlink(cr, uid, alias_ids, context=context)
+            for team in self.browse(cr, uid, ids, context=context):
+                team.alias_id.write(team.get_alias_values())
         return res
 
     def action_your_pipeline(self, cr, uid, context=None):