From be4aba7d8f6dccd1ab7e1152d8c00378b69359fe Mon Sep 17 00:00:00 2001
From: Darshan Kalola <darshankalola@gmail.com>
Date: Mon, 19 Aug 2013 14:13:04 +0530
Subject: [PATCH 1/6] [IMP]improve onchange behaviour when creating partner or
 contact

bzr revid: darshankalola@gmail.com-20130819084304-5jxrvmu8on3fzm2j
---
 openerp/addons/base/res/res_partner_view.xml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index f02021313c0..a032ecfe4db 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -140,8 +140,7 @@
                         <field name="parent_id"
                             placeholder="Company"
                             domain="[('is_company', '=', True)]" context="{'default_is_company': True, 'default_supplier': supplier, 'default_customer': customer}"
-                            attrs="{'invisible': [('is_company','=', True),('parent_id', '=', False)]}"
-                            on_change="onchange_address(use_parent_address, parent_id)"/>
+                            attrs="{'invisible': [('is_company','=', True),('parent_id', '=', False)]}"/>
                         <field name="category_id" widget="many2many_tags" placeholder="Tags..."/>
                     </div>
                     <div class="oe_right oe_button_box" name="buttons"> </div>
@@ -188,7 +187,7 @@
 
                     <notebook colspan="4">
                         <page string="Contacts" attrs="{'invisible': [('is_company','=',False), ('child_ids', '=', [])]}" autofocus="autofocus">
-                            <field name="child_ids" mode="kanban" context="{'default_parent_id': active_id, 'default_street': street, 'default_street2': street2, 'default_city': city, 'default_state_id': state_id, 'default_zip': zip, 'default_country_id': country_id, 'default_supplier': supplier, 'default_customer': customer}">
+                            <field name="child_ids" mode="kanban" context="{'default_parent_id': active_id, 'default_street': street, 'default_street2': street2, 'default_city': city, 'default_state_id': state_id, 'default_zip': zip, 'default_country_id': country_id, 'default_supplier': supplier, 'default_customer': customer, 'default_use_parent_address': True}">
                                 <kanban>
                                     <field name="color"/>
                                     <field name="name"/>

From 15906b31fbbfb93b8a27520247e4dd9be2776cb9 Mon Sep 17 00:00:00 2001
From: Darshan Kalola <dka@tinyerp.com>
Date: Thu, 29 Aug 2013 16:39:55 +0530
Subject: [PATCH 2/6] [IMP]clear address when use_parent_address is set to
 false

bzr revid: dka@tinyerp.com-20130829110955-9eh0b2x0d4d24b8b
---
 openerp/addons/base/res/res_partner.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/openerp/addons/base/res/res_partner.py b/openerp/addons/base/res/res_partner.py
index 97b0ac454ae..54e61101909 100644
--- a/openerp/addons/base/res/res_partner.py
+++ b/openerp/addons/base/res/res_partner.py
@@ -379,7 +379,10 @@ class res_partner(osv.osv, format_address):
                                                       'company. You can use the "Discard" button to abandon this change.')}
             parent = self.browse(cr, uid, parent_id, context=context)
             address_fields = self._address_fields(cr, uid, context=context)
-            result['value'] = dict((key, value_or_id(parent[key])) for key in address_fields)
+            if use_parent_address:
+                result['value'] = dict((key, value_or_id(parent[key])) for key in address_fields)
+            else:
+                result['value'] = dict((key,None) for key in address_fields)
         else:
             result['value'] = {'use_parent_address': False}
         return result

From 8fdc129f5613bd3ba025afafe5514909fac7c2f4 Mon Sep 17 00:00:00 2001
From: "Darshan Kalola (OpenERP)" <dka@tinyerp.com>
Date: Tue, 24 Sep 2013 16:22:03 +0530
Subject: [PATCH 3/6] [IMP]Improve onchange behave with seperate onchange
 method for use parent address.

bzr revid: dka@tinyerp.com-20130924105203-6nq2755rdfscs6kb
---
 openerp/addons/base/res/res_partner.py       | 18 ++++++++++++++----
 openerp/addons/base/res/res_partner_view.xml |  9 +++++----
 2 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/openerp/addons/base/res/res_partner.py b/openerp/addons/base/res/res_partner.py
index 54e61101909..39e070e018b 100644
--- a/openerp/addons/base/res/res_partner.py
+++ b/openerp/addons/base/res/res_partner.py
@@ -358,11 +358,25 @@ class res_partner(osv.osv, format_address):
         value = {}
         value['title'] = False
         if is_company:
+            value['use_parent_address'] = False
             domain = {'title': [('domain', '=', 'partner')]}
         else:
             domain = {'title': [('domain', '=', 'contact')]}
         return {'value': value, 'domain': domain}
 
+    def onchange_use_address(self, cr, uid, ids, use_parent_address, parent_id, context=None):
+        def value_or_id(val):
+            """ return val or val.id if val is a browse record """
+            return val if isinstance(val, (bool, int, long, float, basestring)) else val.id
+        result = {}
+        address_fields = self._address_fields(cr, uid, context=context)
+        if parent_id and use_parent_address:
+            parent = self.browse(cr, uid, parent_id, context=context)
+            result['value'] = dict((key, value_or_id(parent[key])) for key in address_fields)
+        else:
+            result['value'] = dict((key,"") for key in address_fields)
+        return result
+
     def onchange_address(self, cr, uid, ids, use_parent_address, parent_id, context=None):
         def value_or_id(val):
             """ return val or val.id if val is a browse record """
@@ -381,10 +395,6 @@ class res_partner(osv.osv, format_address):
             address_fields = self._address_fields(cr, uid, context=context)
             if use_parent_address:
                 result['value'] = dict((key, value_or_id(parent[key])) for key in address_fields)
-            else:
-                result['value'] = dict((key,None) for key in address_fields)
-        else:
-            result['value'] = {'use_parent_address': False}
         return result
 
     def onchange_state(self, cr, uid, ids, state_id, context=None):
diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index a032ecfe4db..28d51bd1917 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -140,7 +140,8 @@
                         <field name="parent_id"
                             placeholder="Company"
                             domain="[('is_company', '=', True)]" context="{'default_is_company': True, 'default_supplier': supplier, 'default_customer': customer}"
-                            attrs="{'invisible': [('is_company','=', True),('parent_id', '=', False)]}"/>
+                            attrs="{'invisible': [('is_company','=', True),('parent_id', '=', False)]}"
+                            on_change="onchange_address(use_parent_address, parent_id)"/>
                         <field name="category_id" widget="many2many_tags" placeholder="Tags..."/>
                     </div>
                     <div class="oe_right oe_button_box" name="buttons"> </div>
@@ -156,9 +157,9 @@
                             <label for="street" string="Address"/>
                             <div>
                                 <field name="use_parent_address" class="oe_edit_only oe_inline"
-                                       on_change="onchange_address(use_parent_address, parent_id)"
-                                       attrs="{'invisible': [('parent_id','=', False),('use_parent_address','=',False)]}"/>
-                                <label for="use_parent_address" class="oe_edit_only" attrs="{'invisible': [('parent_id','=', False),('use_parent_address','=',False)]}"/>
+                                       on_change="onchange_use_address(use_parent_address, parent_id)"
+                                       attrs="{'invisible': [('is_company', '=', True)]}"/>
+                                <label for="use_parent_address" class="oe_edit_only" attrs="{'invisible': [('is_company', '=', True)]}"/>
                                 <button name="open_parent" type="object" string="(edit company address)" class="oe_link oe_edit_only"
                                         attrs="{'invisible': ['|',('parent_id','=', False),('use_parent_address','=',False)]}"/>
                                 <field name="street" placeholder="Street..."  attrs="{'readonly': [('use_parent_address','=',True)]}"/>

From 2868f916c5214b4c82d7c57c28d070c6611c0262 Mon Sep 17 00:00:00 2001
From: "Darshan Kalola (OpenERP)" <dka@tinyerp.com>
Date: Fri, 27 Sep 2013 18:00:20 +0530
Subject: [PATCH 4/6] [IMP]improve attrs on use_parent_address.

bzr revid: dka@tinyerp.com-20130927123020-nk04nr8o621xw31b
---
 openerp/addons/base/res/res_partner.py       | 2 ++
 openerp/addons/base/res/res_partner_view.xml | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/openerp/addons/base/res/res_partner.py b/openerp/addons/base/res/res_partner.py
index 84476ebcc6e..4f7d7108755 100644
--- a/openerp/addons/base/res/res_partner.py
+++ b/openerp/addons/base/res/res_partner.py
@@ -395,6 +395,8 @@ class res_partner(osv.osv, format_address):
             address_fields = self._address_fields(cr, uid, context=context)
             if use_parent_address:
                 result['value'] = dict((key, value_or_id(parent[key])) for key in address_fields)
+        else:
+            result['value'] = {'use_parent_address': False}
         return result
 
     def onchange_state(self, cr, uid, ids, state_id, context=None):
diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 28d51bd1917..c4300fe999b 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -158,8 +158,8 @@
                             <div>
                                 <field name="use_parent_address" class="oe_edit_only oe_inline"
                                        on_change="onchange_use_address(use_parent_address, parent_id)"
-                                       attrs="{'invisible': [('is_company', '=', True)]}"/>
-                                <label for="use_parent_address" class="oe_edit_only" attrs="{'invisible': [('is_company', '=', True)]}"/>
+                                       attrs="{'invisible': ['|', ('is_company', '=', True),('parent_id', '=', False)]}"/>
+                                <label for="use_parent_address" class="oe_edit_only" attrs="{'invisible': ['|', ('is_company', '=', True), ('parent_id', '=', False)]}"/>
                                 <button name="open_parent" type="object" string="(edit company address)" class="oe_link oe_edit_only"
                                         attrs="{'invisible': ['|',('parent_id','=', False),('use_parent_address','=',False)]}"/>
                                 <field name="street" placeholder="Street..."  attrs="{'readonly': [('use_parent_address','=',True)]}"/>

From f97e51b6c71b855f445ad2186537cd93750c51e1 Mon Sep 17 00:00:00 2001
From: "Darshan Kalola (OpenERP)" <dka@tinyerp.com>
Date: Thu, 3 Oct 2013 13:05:15 +0530
Subject: [PATCH 5/6] [IMP]Rename parent variable with parent_company.

bzr revid: dka@tinyerp.com-20131003073515-y3xt3qqymgourcn1
---
 openerp/addons/base/res/res_partner.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/openerp/addons/base/res/res_partner.py b/openerp/addons/base/res/res_partner.py
index 4f7d7108755..bbe4f8e361c 100644
--- a/openerp/addons/base/res/res_partner.py
+++ b/openerp/addons/base/res/res_partner.py
@@ -371,8 +371,8 @@ class res_partner(osv.osv, format_address):
         result = {}
         address_fields = self._address_fields(cr, uid, context=context)
         if parent_id and use_parent_address:
-            parent = self.browse(cr, uid, parent_id, context=context)
-            result['value'] = dict((key, value_or_id(parent[key])) for key in address_fields)
+            parent_company = self.browse(cr, uid, parent_id, context=context)
+            result['value'] = dict((key, value_or_id(parent_company[key])) for key in address_fields)
         else:
             result['value'] = dict((key,"") for key in address_fields)
         return result
@@ -391,10 +391,10 @@ class res_partner(osv.osv, format_address):
                                                       'was never correctly set. If an existing contact starts working for a new '
                                                       'company then a new contact should be created under that new '
                                                       'company. You can use the "Discard" button to abandon this change.')}
-            parent = self.browse(cr, uid, parent_id, context=context)
+            parent_company = self.browse(cr, uid, parent_id, context=context)
             address_fields = self._address_fields(cr, uid, context=context)
             if use_parent_address:
-                result['value'] = dict((key, value_or_id(parent[key])) for key in address_fields)
+                result['value'] = dict((key, value_or_id(parent_company[key])) for key in address_fields)
         else:
             result['value'] = {'use_parent_address': False}
         return result

From d75405572fa1c21cccd5ac12826209848c3acbeb Mon Sep 17 00:00:00 2001
From: "Darshan Kalola (OpenERP)" <dka@tinyerp.com>
Date: Thu, 17 Apr 2014 15:42:19 +0530
Subject: [PATCH 6/6] [IMP]removed use_company_address method, added same
 feature in single method, to achive this added new parameter 'empty_fields'
 to empty all address field when use compny address is unchecked.

bzr revid: dka@tinyerp.com-20140417101219-gs68pfe64a7l97hc
---
 openerp/addons/base/res/res_partner.py       | 22 ++++++--------------
 openerp/addons/base/res/res_partner_view.xml |  2 +-
 2 files changed, 7 insertions(+), 17 deletions(-)

diff --git a/openerp/addons/base/res/res_partner.py b/openerp/addons/base/res/res_partner.py
index 0a5758c75d0..33ebe8acf35 100644
--- a/openerp/addons/base/res/res_partner.py
+++ b/openerp/addons/base/res/res_partner.py
@@ -366,24 +366,12 @@ class res_partner(osv.osv, format_address):
             domain = {'title': [('domain', '=', 'contact')]}
         return {'value': value, 'domain': domain}
 
-    def onchange_use_address(self, cr, uid, ids, use_parent_address, parent_id, context=None):
+    def onchange_address(self, cr, uid, ids, use_parent_address, parent_id, empty_fields=False, context=None):
         def value_or_id(val):
             """ return val or val.id if val is a browse record """
             return val if isinstance(val, (bool, int, long, float, basestring)) else val.id
-        result = {}
+        result = {'value': {}}
         address_fields = self._address_fields(cr, uid, context=context)
-        if parent_id and use_parent_address:
-            parent_company = self.browse(cr, uid, parent_id, context=context)
-            result['value'] = dict((key, value_or_id(parent_company[key])) for key in address_fields)
-        else:
-            result['value'] = dict((key,"") for key in address_fields)
-        return result
-
-    def onchange_address(self, cr, uid, ids, use_parent_address, parent_id, context=None):
-        def value_or_id(val):
-            """ return val or val.id if val is a browse record """
-            return val if isinstance(val, (bool, int, long, float, basestring)) else val.id
-        result = {}
         if parent_id:
             if ids:
                 partner = self.browse(cr, uid, ids[0], context=context)
@@ -394,11 +382,13 @@ class res_partner(osv.osv, format_address):
                                                       'company then a new contact should be created under that new '
                                                       'company. You can use the "Discard" button to abandon this change.')}
             parent_company = self.browse(cr, uid, parent_id, context=context)
-            address_fields = self._address_fields(cr, uid, context=context)
             if use_parent_address:
                 result['value'] = dict((key, value_or_id(parent_company[key])) for key in address_fields)
+            if empty_fields and not use_parent_address: 
+                result['value'] = dict((key,"") for key in address_fields)
         else:
-            result['value'] = {'use_parent_address': False}
+            if use_parent_address: result['value'] = dict((key,"") for key in address_fields)
+            result['value']['use_parent_address'] = False
         return result
 
     def onchange_state(self, cr, uid, ids, state_id, context=None):
diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 82a9aa061ca..f22939b1c00 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -157,7 +157,7 @@
                             <label for="street" string="Address"/>
                             <div>
                                 <field name="use_parent_address" class="oe_edit_only oe_inline"
-                                       on_change="onchange_use_address(use_parent_address, parent_id)"
+                                       on_change="onchange_address(use_parent_address, parent_id, True)"
                                        attrs="{'invisible': ['|', ('is_company', '=', True),('parent_id', '=', False)]}"/>
                                 <label for="use_parent_address" class="oe_edit_only" attrs="{'invisible': ['|', ('is_company', '=', True), ('parent_id', '=', False)]}"/>
                                 <button name="open_parent" type="object" string="(edit company address)" class="oe_link oe_edit_only"