From 377f18013a5f94dc9502a3a2710bf578b56a7d4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20=28FRC=29?= <frc@odoo.com>
Date: Tue, 7 Sep 2021 14:47:41 +0000
Subject: [PATCH] [FIX] partner_autocomplete, *: fix partner autocomplete
 dropdown menu hidden

base: The two elements were not distinguishable by an xpath.

partner_autocomplete: Use new ids in xpath

The class `o_text_overflow` set on the fields was also
preventing the dropdown menu from appearing. This class is
now moved to the `input` tag instead of the while `div`.

closes odoo/odoo#78141

Task: 2638570
X-original-commit: fd7bfbccd45f874d5a826e695858bc75c8467700
Signed-off-by: Florian Daloze (fda) <fda@odoo.com>
---
 .../static/src/js/partner_autocomplete_fieldchar.js    |  4 ++++
 .../partner_autocomplete/views/res_partner_views.xml   | 10 ++++++++--
 odoo/addons/base/views/res_partner_views.xml           |  8 ++++----
 .../test_main_flows/static/tests/tours/main_flow.js    |  4 ++--
 4 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/addons/partner_autocomplete/static/src/js/partner_autocomplete_fieldchar.js b/addons/partner_autocomplete/static/src/js/partner_autocomplete_fieldchar.js
index 5c171258391..a9342c5d7fc 100644
--- a/addons/partner_autocomplete/static/src/js/partner_autocomplete_fieldchar.js
+++ b/addons/partner_autocomplete/static/src/js/partner_autocomplete_fieldchar.js
@@ -176,6 +176,10 @@ var FieldAutocomplete = FieldChar.extend(AutocompleteMixin, {
                 suggestions: this.suggestions,
             }));
             this.$dropdown.appendTo(this.$el);
+            // We need to make sure that the element containing the dropdown menu doesn't have the
+            // style attribute overflow: hidden, otherwise the dropdown menu will be hidden by it
+            this.$el.removeClass('o_text_overflow');
+            this.$input.addClass('o_text_overflow');
         }
     },
 
diff --git a/addons/partner_autocomplete/views/res_partner_views.xml b/addons/partner_autocomplete/views/res_partner_views.xml
index ad8190142be..0745407cc1a 100644
--- a/addons/partner_autocomplete/views/res_partner_views.xml
+++ b/addons/partner_autocomplete/views/res_partner_views.xml
@@ -5,7 +5,10 @@
         <field name="model">res.partner</field>
         <field name="inherit_id" ref="base.view_partner_form"/>
         <field name="arch" type="xml">
-            <xpath expr="//div[hasclass('oe_title')]/h1/field[@name='name']" position="attributes">
+            <xpath expr="//div[hasclass('oe_title')]/h1/field[@id='company']" position="attributes">
+                <attribute name="widget">field_partner_autocomplete</attribute>
+            </xpath>
+            <xpath expr="//div[hasclass('oe_title')]/h1/field[@id='individual']" position="attributes">
                 <attribute name="widget">field_partner_autocomplete</attribute>
             </xpath>
             <xpath expr="//field[@name='vat']" position="attributes">
@@ -23,7 +26,10 @@
         <field name="model">res.partner</field>
         <field name="inherit_id" ref="base.view_partner_simple_form"/>
         <field name="arch" type="xml">
-            <xpath expr="//div[hasclass('oe_title')]/h1/field[@name='name']" position="attributes">
+            <xpath expr="//div[hasclass('oe_title')]/h1/field[@id='company']" position="attributes">
+                <attribute name="widget">field_partner_autocomplete</attribute>
+            </xpath>
+            <xpath expr="//div[hasclass('oe_title')]/h1/field[@id='individual']" position="attributes">
                 <attribute name="widget">field_partner_autocomplete</attribute>
             </xpath>
             <xpath expr="//field[last()]" position="after">
diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml
index 6258a39524c..462770be20a 100644
--- a/odoo/addons/base/views/res_partner_views.xml
+++ b/odoo/addons/base/views/res_partner_views.xml
@@ -88,8 +88,8 @@
                     <div class="oe_title">
                         <field name="company_type" options="{'horizontal': true}" widget="radio" groups="base.group_no_one"/>
                         <h1>
-                            <field name="name" default_focus="1" placeholder="e.g. Lumber Inc" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', False)]}"/>
-                            <field name="name" default_focus="1" placeholder="e.g. Brandom Freeman" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', True)]}"/>
+                            <field id="company" name="name" default_focus="1" placeholder="e.g. Lumber Inc" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', False)]}"/>
+                            <field id="individual" name="name" default_focus="1" placeholder="e.g. Brandom Freeman" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', True)]}"/>
                         </h1>
                         <field name="parent_id"
                             widget="res_partner_many2one"
@@ -168,8 +168,8 @@
                         <field name="country_code" invisible="1"/>
                         <field name="company_type" widget="radio" options="{'horizontal': true}"/>
                         <h1>
-                            <field class="o_text_overflow" name="name" default_focus="1" placeholder="e.g. Lumber Inc" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', False)]}"/>
-                            <field class="o_text_overflow" name="name" default_focus="1" placeholder="e.g. Brandom Freeman" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', True)]}"/>
+                            <field id="company" class="o_text_overflow" name="name" default_focus="1" placeholder="e.g. Lumber Inc" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', False)]}"/>
+                            <field id="individual" class="o_text_overflow" name="name" default_focus="1" placeholder="e.g. Brandom Freeman" attrs="{'required' : [('type', '=', 'contact')], 'invisible': [('is_company','=', True)]}"/>
                         </h1>
                         <div class="o_row">
                             <field name="parent_id"
diff --git a/odoo/addons/test_main_flows/static/tests/tours/main_flow.js b/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
index ff69837a9cf..f2b99065e8d 100644
--- a/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
+++ b/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
@@ -172,7 +172,7 @@ tour.stepUtils.autoExpandMoreButtons('.o_form_readonly'),
     position: "right",
 }, {
     mobile: true,
-    trigger: "input[name=name]:not(.o_invisible_modifier)",
+    trigger: ".o_field_widget[name=name] input:not(.o_invisible_modifier)",
     extra_trigger: ".modal:not(.o_inactive_modal) .modal-dialog .o_field_radio.o_field_widget[name=company_type]",
     content: _t('Select a seller'),
     position: 'top',
@@ -461,7 +461,7 @@ tour.stepUtils.autoExpandMoreButtons('.o_form_readonly'),
     position: "left",
 }, {
     mobile: true,
-    trigger: "input[name=name]:not(.o_invisible_modifier)",
+    trigger: ".o_field_widget[name=name] input:not(.o_invisible_modifier)",
     extra_trigger: ".modal:not(.o_inactive_modal) .modal-title:contains('Organization / Contact')",
     content: _t('Let\'s enter the name.'),
     position: 'left',