From 377af37434e6bcbe0c7a900064e630cee2dda731 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 20 Oct 2010 14:44:50 +0200
Subject: [PATCH] [IMP] Style of JS inserted for handling of the pad-creation
 form: naming conventions, usage of event shortcuts

bzr revid: xmo@openerp.com-20101020124450-ctvqik4ukqizwfsc
---
 addons/piratepad/editors.py | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/addons/piratepad/editors.py b/addons/piratepad/editors.py
index c229a924da1..39df35f5ecf 100644
--- a/addons/piratepad/editors.py
+++ b/addons/piratepad/editors.py
@@ -24,7 +24,7 @@ class SidebarTemplateEditor(openobject.templating.TemplateEditor):
 
         form_insertion_point = output.index(self.BINARY_ATTACHMENTS_FORM)
         return output[:form_insertion_point] + '''
-            <form id="pad-box" action="/piratepad/link" method="post">
+            <form id="pad-form" action="/piratepad/link" method="post">
                 <label for="sidebar_pad_datas">${_("Name")}:</label>
                 <table width="100%">
                 <tr>
@@ -40,17 +40,16 @@ class SidebarTemplateEditor(openobject.templating.TemplateEditor):
             </form>
             <script type="text/javascript">
                 jQuery(document).ready(function() {
-                    var padForm = jQuery('#pad-box').hide();
-                    jQuery('#sidebar_pad_ok').bind('click', function(){
-                        padForm.submit();
+                    var $padForm = jQuery('#pad-form')
+                            .hide()
+                            .submit(createAttachment);
+                    jQuery('#sidebar_pad_ok').click(function(){
+                        $padForm.submit();
                     });
                     jQuery('#add-pad').click(function(e){
-                        padForm.show();
+                        $padForm.show();
                         e.preventDefault();
                     });
-                    padForm.bind({
-                        submit: createAttachment
-                    });
                 });
             </script>
         ''' + output[form_insertion_point:]