From 376891294788706753b056f0151d198f0a493c64 Mon Sep 17 00:00:00 2001
From: "Tiffany Chang (tic)" <tic@odoo.com>
Date: Mon, 6 Apr 2020 11:26:40 +0000
Subject: [PATCH] [IMP] Improve purchase KPIs UX

Minor improvements/fixes:
- Prevent overlap of 'o_view_nocontent' (when there are no relevant
  records) with kpis table in list/kanban views on small screens/windows.
- Create separate list views to prevent kpis table appearing in
  appropriate situations (e.g. action windows showing linkages between
  purchase orders and other models.)
- Override bootstrap styling that was making kpi table wider than the
  width of the window in list view.

closes odoo/odoo#49509

Task: 2228175
X-original-commit: ee831f7aff400f76e20e54b7cb9b5610bcec4839
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
---
 addons/purchase/static/src/scss/purchase.scss | 11 ++++++
 addons/purchase/views/purchase_views.xml      | 35 +++++++++++++++++--
 2 files changed, 44 insertions(+), 2 deletions(-)

diff --git a/addons/purchase/static/src/scss/purchase.scss b/addons/purchase/static/src/scss/purchase.scss
index dadb3972fc0..003bb0a488e 100644
--- a/addons/purchase/static/src/scss/purchase.scss
+++ b/addons/purchase/static/src/scss/purchase.scss
@@ -6,6 +6,11 @@
     position: relative;
     max-width:100%;
 
+    .row {
+        margin-right: 0;
+        margin-left: 0;
+    }
+
     .o_dashboard_action {
         cursor: pointer;
     }
@@ -47,3 +52,9 @@
         }
     }
 }
+
+.o_purchase_dashboard ~ .o_view_nocontent {
+    // To prevent overlapping from inherited values
+    position: relative;
+    width: 100%;
+}
diff --git a/addons/purchase/views/purchase_views.xml b/addons/purchase/views/purchase_views.xml
index d3522119724..9f61fd92fd0 100644
--- a/addons/purchase/views/purchase_views.xml
+++ b/addons/purchase/views/purchase_views.xml
@@ -485,6 +485,37 @@
         <record id="purchase_order_tree" model="ir.ui.view">
             <field name="name">purchase.order.tree</field>
             <field name="model">purchase.order</field>
+            <field name="priority" eval="1"/>
+            <field name="arch" type="xml">
+                <tree string="Purchase Order" multi_edit="1" decoration-bf="message_unread==True"
+                      decoration-muted="state=='cancel'" decoration-info="state in ('wait','confirmed')">
+                    <field name="message_unread" invisible="1"/>
+                    <field name="partner_ref" optional="hide"/>
+                    <field name="name" string="Reference" readonly="1"/>
+                    <field name="date_order" invisible="not context.get('quotation_only', False)" optional="show"/>
+                    <field name="date_approve" invisible="context.get('quotation_only', False)" optional="show"/>
+                    <field name="partner_id" readonly="1"/>
+                    <field name="company_id" readonly="1" options="{'no_create': True}"
+                        groups="base.group_multi_company" optional="show"/>
+                    <field name="date_planned" invisible="context.get('quotation_only', False)" optional="show"/>
+                    <field name="user_id" optional="show"/>
+                    <field name="origin" optional="show"/>
+                    <field name="amount_untaxed" sum="Total Untaxed amount" string="Untaxed" widget="monetary" optional="hide"/>
+                    <field name="amount_total" sum="Total amount" widget="monetary" optional="show"/>
+                    <field name="currency_id" invisible="1"/>
+                    <field name="state" optional="show"/>
+                    <field name="invoice_status" attrs="{'column_invisible': [('parent.state', 'not in', ('purchase', 'done'))]}"/>
+                    <field name="activity_exception_decoration" widget="activity_exception"/>
+                </tree>
+            </field>
+        </record>
+        
+        <!-- Unfortunately we want the purchase kpis table to only show up in some list views,
+             so we have to duplicate code to support both view versions -->
+        <record id="purchase_order_kpis_tree" model="ir.ui.view">
+            <field name="name">purchase.order.inherit.purchase.order.tree</field>
+            <field name="model">purchase.order</field>
+            <field name="priority" eval="10"/>
             <field name="arch" type="xml">
                 <tree string="Purchase Order" multi_edit="1" decoration-bf="message_unread==True"
                       decoration-muted="state=='cancel'" decoration-info="state in ('wait','confirmed')" class="o_purchase_order" js_class="purchase_list_dashboard">
@@ -555,7 +586,7 @@
             <field name="type">ir.actions.act_window</field>
             <field name="res_model">purchase.order</field>
             <field name="view_mode">tree,kanban,form,pivot,graph,calendar,activity</field>
-            <field name="view_id" ref="purchase_order_tree"/>
+            <field name="view_id" ref="purchase_order_kpis_tree"/>
             <field name="domain">[]</field>
             <field name="search_view_id" ref="view_purchase_order_filter"/>
             <field name="context">{'quotation_only': True}</field>
@@ -686,7 +717,7 @@
         <field name="name">Requests for Quotation</field>
         <field name="res_model">purchase.order</field>
         <field name="view_mode">form,tree,kanban,pivot,graph,calendar,activity</field>
-        <field name="view_id" ref="purchase.purchase_order_tree"/>
+        <field name="view_id" ref="purchase.purchase_order_kpis_tree"/>
         <field name="search_view_id" ref="view_purchase_order_filter"/>
         <field name="target">main</field>
         <field name="help" type="html">