From 366cf243ac8a2138103b567b8e9afaa2e8f8cfff Mon Sep 17 00:00:00 2001 From: std-odoo Date: Mon, 12 Jul 2021 11:16:28 +0000 Subject: [PATCH] [FIX] mail_group: fix a traceback when a public user subscribe When a public user subscribe to a mailing list, a traceback is raised. Introduced with refactroring odoo/odoo@2d359b909bc27fd41125c9e44d9376b5a910f6d5 Task-2599676 Part-of: odoo/odoo#75770 --- addons/mail_group/controllers/portal.py | 4 ++-- addons/mail_group/models/mail_group.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/mail_group/controllers/portal.py b/addons/mail_group/controllers/portal.py index c6e5ea234a9..2adf45159bd 100644 --- a/addons/mail_group/controllers/portal.py +++ b/addons/mail_group/controllers/portal.py @@ -248,9 +248,9 @@ class PortalMailGroup(http.Controller): else: # For non-logged user, send an email with a token to confirm the action if action == 'subscribe': - group_sudo._send_subscribe_confirmation_email(email, action) + group_sudo._send_subscribe_confirmation_email(email) else: - group_sudo._send_unsubscribe_confirmation_email(email, action) + group_sudo._send_unsubscribe_confirmation_email(email) return 'email_sent' @http.route('/groups/subscribe', type='http', auth='public', website=True) diff --git a/addons/mail_group/models/mail_group.py b/addons/mail_group/models/mail_group.py index 833c1ec395b..12cd398928c 100644 --- a/addons/mail_group/models/mail_group.py +++ b/addons/mail_group/models/mail_group.py @@ -493,7 +493,7 @@ class MailGroup(models.Model): ) _logger.info('Subscription email sent to %s.', email) - def _send_unsubscribe_confirmation_email(self, email, action): + def _send_unsubscribe_confirmation_email(self, email): """Send an email to the given address to subscribe / unsubscribe to the mailing list.""" self.ensure_one() confirm_action_url = self._generate_action_url(email, 'unsubscribe')