From 353fbb33efe6cb37aa0658cd60ba8398171932b5 Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Mon, 28 Aug 2023 11:12:18 +0200 Subject: [PATCH] [FIX] registry: misuse of psycopg2.sql import Part-of: odoo/odoo#134677 --- odoo/modules/registry.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/odoo/modules/registry.py b/odoo/modules/registry.py index 40bcf2942bc..ac8cf973608 100644 --- a/odoo/modules/registry.py +++ b/odoo/modules/registry.py @@ -26,7 +26,7 @@ from .. import SUPERUSER_ID from odoo.sql_db import TestCursor from odoo.tools import ( config, existing_tables, lazy_classproperty, - lazy_property, sql, Collector, OrderedSet, + lazy_property, sql, Collector, OrderedSet, SQL, format_frame ) from odoo.tools.func import locked @@ -797,9 +797,11 @@ class Registry(Mapping): for sequence_name in sequence_names: if sequence_name not in existing_sequences: - _sequence_name = sql.Identifier(sequence_name) # even if sequence_name should be safe, will avoid flagging the sql_injection linter - cr.execute(sql.SQL("CREATE SEQUENCE {} INCREMENT BY 1 START WITH 1").format(_sequence_name)) - cr.execute("SELECT nextval(%s)", [sequence_name]) + cr.execute(SQL( + "CREATE SEQUENCE %s INCREMENT BY 1 START WITH 1", + SQL.identifier(sequence_name), + )) + cr.execute(SQL("SELECT nextval(%s)", sequence_name)) db_registry_sequence, db_cache_sequences = self.get_sequences(cr) self.registry_sequence = db_registry_sequence