From 34b81203da9ad5ad1bc014980b11eae4bef764b6 Mon Sep 17 00:00:00 2001
From: "Louis (wil)" <wil@odoo.com>
Date: Thu, 18 Jan 2024 12:40:31 +0100
Subject: [PATCH] [FIX] sale: make "Down payment invoice" translatable

Nested gettexts aren't exported. This commit solves the problem by
moving the inner gettext outside of the arguments of the first gettext.

closes odoo/odoo#149921

Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
---
 addons/sale/i18n/sale.pot                     | 37 +++++++------------
 .../sale/wizard/sale_make_invoice_advance.py  |  4 +-
 2 files changed, 16 insertions(+), 25 deletions(-)

diff --git a/addons/sale/i18n/sale.pot b/addons/sale/i18n/sale.pot
index 8cd053a0ba0..ffdec8b8d73 100644
--- a/addons/sale/i18n/sale.pot
+++ b/addons/sale/i18n/sale.pot
@@ -843,8 +843,7 @@ msgid ""
 "Quotation: the document will be sent to and accessible by customers at any time.\n"
 "e.g. this option can be useful to share Product description files.\n"
 "Confirmed order: the document will be sent to and accessible by customers.\n"
-"e.g. this option can be useful to share User Manual or digital content bought on ecommerce. \n"
-"Inside quote: The document will be included in the pdf of the quotation between the header pages and the quote table. "
+"e.g. this option can be useful to share User Manual or digital content bought on ecommerce. "
 msgstr ""
 
 #. module: sale
@@ -1633,9 +1632,7 @@ msgstr ""
 #: model:ir.model.fields,help:sale.field_sale_order__expected_date
 msgid ""
 "Delivery date you can promise to the customer, computed from the minimum "
-"lead time of the order lines in case of Service products. In case of "
-"shipping, the shipping policy of the order will be taken into account to "
-"either use the minimum or maximum lead time of the order lines."
+"lead time of the order lines."
 msgstr ""
 
 #. module: sale
@@ -1835,6 +1832,13 @@ msgstr ""
 msgid "Down payment <br/>"
 msgstr ""
 
+#. module: sale
+#. odoo-python
+#: code:addons/sale/wizard/sale_make_invoice_advance.py:0
+#, python-format
+msgid "Down payment invoice"
+msgstr ""
+
 #. module: sale
 #. odoo-python
 #: code:addons/sale/wizard/sale_make_invoice_advance.py:0
@@ -3005,11 +3009,6 @@ msgstr ""
 msgid "Other Info"
 msgstr ""
 
-#. module: sale
-#: model:ir.actions.report,name:sale.action_report_saleorder
-msgid "PDF Quote"
-msgstr ""
-
 #. module: sale
 #: model:ir.model.fields,field_description:sale.field_res_config_settings__module_sale_pdf_quote_builder
 #: model_terms:ir.ui.view,arch_db:sale.res_config_settings_view_form
@@ -3386,6 +3385,11 @@ msgstr ""
 msgid "Quotation #"
 msgstr ""
 
+#. module: sale
+#: model:ir.actions.report,name:sale.action_report_saleorder
+msgid "Quotation / Order"
+msgstr ""
+
 #. module: sale
 #: model:ir.model.fields,field_description:sale.field_utm_campaign__quotation_count
 msgid "Quotation Count"
@@ -3471,11 +3475,6 @@ msgstr ""
 msgid "Quotations to review"
 msgstr ""
 
-#. module: sale
-#: model:ir.model.fields,field_description:sale.field_sale_order__rating_ids
-msgid "Ratings"
-msgstr ""
-
 #. module: sale
 #: model:ir.model.fields,field_description:sale.field_product_product__expense_policy
 #: model:ir.model.fields,field_description:sale.field_product_template__expense_policy
@@ -3836,14 +3835,6 @@ msgstr ""
 msgid "Sales Warnings"
 msgstr ""
 
-#. module: sale
-#: model:ir.model.fields,help:sale.field_account_analytic_line__so_line
-msgid ""
-"Sales order item to which the time spent will be added in order to be "
-"invoiced to your customer. Remove the sales order item for the timesheet "
-"entry to be non-billable."
-msgstr ""
-
 #. module: sale
 #: model:ir.model.fields.selection,name:sale.selection__product_template__expense_policy__sales_price
 msgid "Sales price"
diff --git a/addons/sale/wizard/sale_make_invoice_advance.py b/addons/sale/wizard/sale_make_invoice_advance.py
index ececc03d58d..08587d7eee2 100644
--- a/addons/sale/wizard/sale_make_invoice_advance.py
+++ b/addons/sale/wizard/sale_make_invoice_advance.py
@@ -263,9 +263,9 @@ class SaleAdvancePaymentInv(models.TransientModel):
                 subtype_xmlid='mail.mt_note',
             )
 
+            title = _("Down payment invoice")
             order.with_user(poster).message_post(
-                body=_("%s has been created",
-                        invoice._get_html_link(title=_("Down payment invoice"))),
+                body=_("%s has been created", invoice._get_html_link(title=title)),
             )
 
             return invoice