From 348e731a13ece4f251157748e18bc330e3f1bc30 Mon Sep 17 00:00:00 2001
From: "Touati Djamel (otd)" <otd@odoo.com>
Date: Tue, 22 Mar 2022 14:02:29 +0000
Subject: [PATCH] [FIX] mrp_account: add user group check

Steps to reproduce the bug:

- Install mrp_account and accounting

1:/
- remove MRP access to Marc Demo
- connect with Marc
- Go to any product with variant > variants > then open any variant

Problem:
Access error is triggered, we try to calculate the bom_count of this product, but the user does not have manager access to MRP

2:/
- now Give accountant access to Marc
- Go to any analytic account with bom or production

Problem:
Marc can see the number of boms or productions, while he does not have access to MRP

opw-2794179

closes odoo/odoo#87457

X-original-commit: 7701d85e2364bc4b59455338cc771733dbb12e73
Signed-off-by: Arnold Moyaux <arm@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
---
 addons/mrp_account/views/analytic_account_views.xml | 1 +
 addons/mrp_account/views/product_views.xml          | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/addons/mrp_account/views/analytic_account_views.xml b/addons/mrp_account/views/analytic_account_views.xml
index 14d2da069bc..454aed10d3a 100644
--- a/addons/mrp_account/views/analytic_account_views.xml
+++ b/addons/mrp_account/views/analytic_account_views.xml
@@ -5,6 +5,7 @@
         <field name="model">account.analytic.account</field>
         <field name="inherit_id" ref="analytic.view_account_analytic_account_form"/>
         <field eval="14" name="priority"/>
+        <field name="groups_id" eval="[(4, ref('mrp.group_mrp_user'))]"/>
         <field name="arch" type="xml">
             <div name="button_box" position="inside">
                 <button class="oe_stat_button" type="object" name="action_view_mrp_production"
diff --git a/addons/mrp_account/views/product_views.xml b/addons/mrp_account/views/product_views.xml
index 2263a5f0cf0..df699735d3c 100644
--- a/addons/mrp_account/views/product_views.xml
+++ b/addons/mrp_account/views/product_views.xml
@@ -5,7 +5,7 @@
             <field name="model">product.template</field>
             <field name="priority">3</field>
             <field name="inherit_id" ref="product.product_template_only_form_view" />
-            <field name="groups_id" eval="[(4, ref('mrp.group_mrp_user'))]"/>
+            <field name="groups_id" eval="[(4, ref('mrp.group_mrp_manager'))]"/>
             <field name="arch" type="xml">
                 <xpath expr="//div[@name='standard_price_uom']" position="inside">
                     <field name="cost_method" invisible="1"/>
@@ -24,7 +24,7 @@
             <field name="model">product.product</field>
             <field name="priority">4</field>
             <field name="inherit_id" ref="product.product_normal_form_view"/>
-            <field name="groups_id" eval="[(4, ref('mrp.group_mrp_user'))]"/>
+            <field name="groups_id" eval="[(4, ref('mrp.group_mrp_manager'))]"/>
             <field name="arch" type="xml">
                 <xpath expr="//div[@name='standard_price_uom']" position="inside">
                     <field name="cost_method" invisible="1"/>
@@ -43,6 +43,7 @@
             <field name="name">product.product.product.view.form.easy.bom.inherit</field>
             <field name="model">product.product</field>
             <field name="inherit_id" ref="product.product_variant_easy_edit_view"/>
+            <field name="groups_id" eval="[(4, ref('mrp.group_mrp_manager'))]"/>
             <field name="arch" type="xml">
                 <data>
                 <xpath expr="//field[@name='standard_price']" position="replace">