From 33a96a4e69a0d57fd7a348190e4eb9f10af37bb5 Mon Sep 17 00:00:00 2001 From: ddm Date: Fri, 13 Sep 2013 14:21:08 +0200 Subject: [PATCH] [IMP] SEO: highlight suggestions when in body bzr revid: ddm@openerp.com-20130913122108-mxnqz1ymui7asnfg --- addons/website/static/src/js/website.seo.js | 10 ++++++---- addons/website/static/src/xml/website.seo.xml | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/addons/website/static/src/js/website.seo.js b/addons/website/static/src/js/website.seo.js index e7983e57af1..738bd46d413 100644 --- a/addons/website/static/src/js/website.seo.js +++ b/addons/website/static/src/js/website.seo.js @@ -22,9 +22,12 @@ }, init: function (parent, keyword) { this.keyword = keyword; + var keywordRegex = new RegExp(this.keyword, "gi"); + var pageText = $('body').children().not('.js_seo_configuration').text(); + var isKeywordInBody = keywordRegex.test(pageText); // cf. http://getbootstrap.com/components/#labels // default, primary, success, info, warning, danger - this.type = 'default'; + this.type = isKeywordInBody ? 'info' : 'default'; this._super(parent); }, select: function () { @@ -96,8 +99,7 @@ website.seo.KeywordList = openerp.Widget.extend({ template: 'website.seo_list', maxKeywords: 10, - init: function (parent, htmlPage) { - this.htmlPage = htmlPage; + init: function (parent) { this._super(parent); }, keywords: function () { @@ -246,7 +248,7 @@ self.suggestImprovements(htmlPage); self.imageList = new website.seo.ImageList(self); self.imageList.appendTo($modal.find('.js_seo_image_list')); - self.keywordList = new website.seo.KeywordList(self, htmlPage); + self.keywordList = new website.seo.KeywordList(self); self.keywordList.on('list-full', self, function () { $modal.find('input[name=seo_page_keywords]') .attr('readonly', "readonly") diff --git a/addons/website/static/src/xml/website.seo.xml b/addons/website/static/src/xml/website.seo.xml index f0cbd4913c7..9471733e25c 100644 --- a/addons/website/static/src/xml/website.seo.xml +++ b/addons/website/static/src/xml/website.seo.xml @@ -1,7 +1,7 @@ -