From 317802d69e6236a43b2249b38d2f352813644f20 Mon Sep 17 00:00:00 2001
From: Prakash Prajapati <ppr@odoo.com>
Date: Wed, 5 Jun 2019 10:25:54 +0000
Subject: [PATCH] [IMP] analytic, account: set optional field to simplify the
 tree view

Purpose of the commit is to set the new attribute OPTIONAL = SHOW/Hide on tree
view so the user can easily hide/show the optional fields on the tree view.

task-1997453
Closes: #33888
---
 .../account/views/account_analytic_view.xml   |  7 ++-
 addons/account/views/account_move_views.xml   | 49 ++++++++++---------
 .../analytic/views/analytic_account_views.xml | 11 +++--
 addons/membership/views/partner_views.xml     |  4 +-
 addons/sale/views/sale_views.xml              | 11 +++++
 5 files changed, 50 insertions(+), 32 deletions(-)

diff --git a/addons/account/views/account_analytic_view.xml b/addons/account/views/account_analytic_view.xml
index 7f8164329b7..3c13b0be4d7 100644
--- a/addons/account/views/account_analytic_view.xml
+++ b/addons/account/views/account_analytic_view.xml
@@ -30,8 +30,11 @@
             <field name="inherit_id" ref="analytic.view_account_analytic_line_tree"/>
             <field name="arch" type="xml">
                 <data>
-                    <xpath expr="//field[@name='date']" position="after">
-                        <field name="ref" invisible="context.get('to_invoice', False)"/>
+                    <xpath expr="//field[@name='account_id']" position="after">
+                        <field name="ref" invisible="context.get('to_invoice', False)" optional="hide"/>
+                        <field name="general_account_id" optional="hide"/>
+                        <field name="move_id" optional="hide"/>
+                        <field name="product_id" optional="hide"/>
                     </xpath>
                 </data>
             </field>
diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 83f79b1b292..0ea26ac6708 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -131,24 +131,24 @@
             <field eval="100" name="priority"/>
             <field name="arch" type="xml">
                 <tree string="Journal Items" create="false" editable="bottom">
-                    <field name="date"/>
+                    <field name="date" optional="show"/>
                     <field name="journal_id" options='{"no_open":True}'/>
                     <field name="company_id" groups="base.group_multi_company" options="{'no_create': True}"/>
-                    <field name="name"/>
-                    <field name="ref"/>
+                    <field name="name" optional="show"/>
+                    <field name="ref" optional="show"/>
                     <field name="statement_id" invisible="1"/>
-                    <field name="partner_id"/>
+                    <field name="partner_id" optional="show"/>
                     <field name="account_id" options="{'no_open': True, 'no_create': True}" domain="[('company_id', '=', company_id)]" groups="account.group_account_user" attrs="{'readonly':[('parent_state','=','posted')]}"/>
-                    <field name="analytic_account_id" groups="account.group_account_user"/>
+                    <field name="analytic_account_id" groups="account.group_account_user" optional="show"/>
                     <field name="analytic_tag_ids" widget="many2many_tags" groups="analytic.group_analytic_tags"/>
                     <field name="reconciled" invisible="1"/>
-                    <field name="full_reconcile_id"/>
+                    <field name="full_reconcile_id" optional="show"/>
                     <field name="reconcile_model_id" invisible="1"/>
                     <field name="debit" sum="Total Debit"/>
                     <field name="credit" sum="Total Credit"/>
                     <field name="amount_currency" readonly="True" groups="base.group_multi_currency"/>
                     <field name="currency_id" readonly="True" invisible="1" />
-                    <field name="date_maturity"/>
+                    <field name="date_maturity" optional="hide"/>
                     <field name="company_currency_id" invisible="1"/>
                     <field name="company_id" invisible="1"/>
                     <field name="parent_state" invisible="1"/></tree>
@@ -337,10 +337,10 @@
                 <tree decoration-info="state == 'draft'" string="Journal Entries" decoration-muted="state == 'cancel'">
                     <field name="date"/>
                     <field name="name"/>
-                    <field name="partner_id"/>
-                    <field name="ref"/>
+                    <field name="partner_id" optional="show"/>
+                    <field name="ref" optional="show"/>
                     <field name="journal_id"/>
-                    <field name="company_id" groups="base.group_multi_company"/>
+                    <field name="company_id" groups="base.group_multi_company" optional="show"/>
                     <field name="amount_total_signed" sum="Total Amount"/>
                     <field name="state"/>
                     <field name="currency_id" invisible="1"/>
@@ -352,25 +352,26 @@
             <field name="name">account.invoice.tree</field>
             <field name="model">account.move</field>
             <field name="arch" type="xml">
-                <tree decoration-info="state == 'draft'" string="Invoices" decoration-muted="state == 'cancel'" js_class="account_tree" banner_route="/account/account_invoice_onboarding">
+                <tree decoration-info="state == 'draft'" string="Invoices" decoration-muted="state == 'cancel'" js_class="account_tree">
+                    <field name="name"/>
                     <field name="partner_id" invisible="1"/>
                     <field name="invoice_source_email" invisible="1"/>
                     <field name="invoice_vendor_icon" string=" "/>
-                    <field name="invoice_vendor_display_name" groups="base.group_user" string="Vendor"/>
-                    <field name="invoice_date"/>
-                    <field name="name"/>
-                    <field name="invoice_payment_ref"/>
-                    <field name="company_id" groups="base.group_multi_company" options="{'no_create': True}"/>
-                    <field name="invoice_date_due"/>
-                    <field name="invoice_origin"/>
-                    <field name="amount_untaxed_signed" string="Tax Excluded" sum="Total"/>
-                    <field name="amount_tax_signed" string="Tax" sum="Total"/>
-                    <field name="amount_total_signed" string="Total" sum="Total"/>
-                    <field name="amount_residual_signed" string="Amount Due" sum="Amount Due"/>
+                    <field name="invoice_vendor_display_name" invisible="context.get('default_type') not in ('in_invoice', 'in_refund','in_receipt')" groups="base.group_user" string="Vendor" />
+                    <field name="invoice_date" optional="show"/>
+                    <field name="invoice_payment_ref" optional="hide"/>
+                    <field name="invoice_user_id" optional="show" invisible="context.get('default_type') not in ('out_invoice', 'out_refund','out_receipt')" string="Sales Person"/>
+                    <field name="company_id" groups="base.group_multi_company" options="{'no_create': True}" optional="show"/>
+                    <field name="invoice_date_due" optional="show"/>
+                    <field name="invoice_origin" optional="show" string="Source Document"/>
+                    <field name="amount_untaxed_signed" string="Tax Excluded" sum="Total" optional="show"/>
+                    <field name="amount_tax_signed" string="Tax" sum="Total" optional="hide"/>
+                    <field name="amount_total_signed" string="Total" sum="Total" optional="show"/>
+                    <field name="amount_residual_signed" string="Amount Due" sum="Amount Due" optional="show"/>
                     <field name="currency_id" invisible="1"/>
                     <field name="company_currency_id" invisible="1"/>
-                    <field name="state"/>
-                    <field name="invoice_payment_state"/>
+                    <field name="state" optional="show"/>
+                    <field name="invoice_payment_state" optional="hide"/>
                     <field name="type" invisible="context.get('default_type', True)"/>
                 </tree>
             </field>
diff --git a/addons/analytic/views/analytic_account_views.xml b/addons/analytic/views/analytic_account_views.xml
index 8ae4c546a86..8505e72cefa 100644
--- a/addons/analytic/views/analytic_account_views.xml
+++ b/addons/analytic/views/analytic_account_views.xml
@@ -97,13 +97,16 @@
             <field name="model">account.analytic.line</field>
             <field name="arch" type="xml">
                 <tree string="Analytic Entries">
-                    <field name="date"/>
+                    <field name="date" optional="show"/>
                     <field name="name"/>
                     <field name="account_id"/>
                     <field name="currency_id" invisible="1"/>
-                    <field name="company_id" groups="base.group_multi_company"/>
-                    <field name="unit_amount" sum="Quantity"/>
-                    <field name="amount" sum="Total"/>
+                    <field name="unit_amount" sum="Quantity" optional="hide"/>
+                    <field name="product_uom_id" optional="hide"/>
+                    <field name="partner_id" optional="hide"/>
+                    <field name="company_id" groups="base.group_multi_company" optional="show"/>
+                    <field name="amount" sum="Total" optional="show"/>
+                    <field name="tag_ids" optional="hide" widget="many2many_tags"/>
                 </tree>
             </field>
         </record>
diff --git a/addons/membership/views/partner_views.xml b/addons/membership/views/partner_views.xml
index f44d3ffa14e..cd4feefb6d9 100644
--- a/addons/membership/views/partner_views.xml
+++ b/addons/membership/views/partner_views.xml
@@ -91,8 +91,8 @@
             <field name="inherit_id" ref="base.view_partner_tree"/>
             <field name="arch" type="xml">
                 <tree string="Contacts">
-                    <field name="category_id" position="after"/>
-                    <field name="membership_state"/>
+                    <field name="category_id" position="after" optional="hide"/>
+                    <field name="membership_state" optional="hide"/>
                 </tree>
             </field>
         </record>
diff --git a/addons/sale/views/sale_views.xml b/addons/sale/views/sale_views.xml
index 1a75bd33c62..668e3a857fc 100644
--- a/addons/sale/views/sale_views.xml
+++ b/addons/sale/views/sale_views.xml
@@ -1082,6 +1082,17 @@
             </field>
         </record>
 
+        <record id="account_invoice_view_tree" model="ir.ui.view">
+            <field name="name">account.move.tree.inherit.sale</field>
+            <field name="model">account.move</field>
+            <field name="inherit_id" ref="account.view_invoice_tree"/>
+            <field name="arch" type="xml">
+                <field name="invoice_user_id" position="after">
+                    <field name="team_id" invisible="context.get('default_type') not in ('out_invoice', 'out_refund','out_receipt')" optional="hide"/>
+                </field>
+            </field>
+        </record>
+
         <!-- Update account invoice !-->
         <record model="ir.ui.view" id="account_invoice_form">
             <field name="name">Account Invoice</field>