From 30c53a43701c43aef028d95f58d29edd466ec3b8 Mon Sep 17 00:00:00 2001 From: David Monjoie Date: Tue, 5 Oct 2021 08:23:46 +0000 Subject: [PATCH] [FIX] web_editor: fix traceback when clicking outside any snippet This bug was introduced by https://github.com/odoo/odoo/commit/2a7436d83abe178bd21c0694edc9825f5d70d65f. closes odoo/odoo#79057 Signed-off-by: David Monjoie (dmo) --- .../static/lib/odoo-editor/src/OdooEditor.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js b/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js index 527f5de9103..f05a9501f7b 100644 --- a/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js +++ b/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js @@ -1876,14 +1876,16 @@ export class OdooEditor extends EventTarget { } } } - const listMode = getListMode(block.parentElement); - const listDropdownButton = this.toolbar.querySelector('#listDropdownButton'); - if (listDropdownButton) { - if (listMode) { - listDropdownButton.classList.remove('fa-list-ul', 'fa-list-ol', 'fa-tasks'); - listDropdownButton.classList.add(listUIClasses[listMode]); + if (block) { + const listMode = getListMode(block.parentElement); + const listDropdownButton = this.toolbar.querySelector('#listDropdownButton'); + if (listDropdownButton) { + if (listMode) { + listDropdownButton.classList.remove('fa-list-ul', 'fa-list-ol', 'fa-tasks'); + listDropdownButton.classList.add(listUIClasses[listMode]); + } + listDropdownButton.closest('button').classList.toggle('active', block.tagName === 'LI'); } - listDropdownButton.closest('button').classList.toggle('active', block.tagName === 'LI'); } if (!activeLabel) { // If no element from the text style dropdown was marked as active,