From 304eef3ced10e8d21d4136e3bead1b8f027105bb Mon Sep 17 00:00:00 2001 From: Jorge Pinna Puissant Date: Thu, 4 Mar 2021 10:13:07 +0000 Subject: [PATCH] [FIX] base: traceback on testing outgoing mail server connection - Settings > Technical > Email > Outgoing Mail Servers; - Create a new serve with no security; - Test connection. Before this commit, a traceback error is raised. This occurs because SMTPException don't have 'smtp_error'. Now, the UserError is shown correctly. opw-2464796 closes odoo/odoo#67712 X-original-commit: f0e478a154b1f15146c7d95e0ffe146bb22b8cae Signed-off-by: Jorge Pinna Puissant (jpp) --- odoo/addons/base/models/ir_mail_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/odoo/addons/base/models/ir_mail_server.py b/odoo/addons/base/models/ir_mail_server.py index 3856d6f0fc1..2b48e9ef4d2 100644 --- a/odoo/addons/base/models/ir_mail_server.py +++ b/odoo/addons/base/models/ir_mail_server.py @@ -146,7 +146,7 @@ class IrMailServer(models.Model): except smtplib.SMTPResponseException as e: raise UserError(_("Server replied with following exception:\n %s", ustr(e.smtp_error))) except smtplib.SMTPException as e: - raise UserError(_("An SMTP exception occurred. Check port number and connection security type.\n %s", ustr(e.smtp_error))) + raise UserError(_("An SMTP exception occurred. Check port number and connection security type.\n %s", ustr(e))) except SSLError as e: raise UserError(_("An SSL exception occurred. Check connection security type.\n %s", ustr(e))) except Exception as e: