From 30310e7ae78920580b055162de337beea614d75b Mon Sep 17 00:00:00 2001 From: uso-odoo Date: Wed, 1 Mar 2023 12:11:08 +0000 Subject: [PATCH] [FIX] spreadsheet_account: prevent key-error when click on 'See records' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This issue is caught by a sentry. When the user clicks on 'See Records' from the spreadsheet user gets key-error 'codes'! When clicking on 'See Records' it tries to get the domain and the domain takes 'codes' in this function:- spreadsheet_move_line_action() In this PR(https://github.com/odoo/odoo/pull/113359) they changed the key from 'code' to 'codes'. sentry - 3961028578 closes odoo/odoo#114161 X-original-commit: 83a8d5437da5da3d5ff5e6395952214e8d08e8f4 Signed-off-by: Lucas Lefèvre (lul) --- addons/spreadsheet_account/static/src/index.js | 6 +++--- .../static/tests/ui/accounting_drilldown_tests.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/spreadsheet_account/static/src/index.js b/addons/spreadsheet_account/static/src/index.js index 339905b9b27..760f389334c 100644 --- a/addons/spreadsheet_account/static/src/index.js +++ b/addons/spreadsheet_account/static/src/index.js @@ -20,10 +20,10 @@ cellMenuRegistry.add("move_lines_see_records", { const position = env.model.getters.getActivePosition(); const cell = env.model.getters.getCell(position); const { args } = getFirstAccountFunction(cell.content); - let [code, date_range, offset, companyId, includeUnposted] = args + let [codes, date_range, offset, companyId, includeUnposted] = args .map(astToFormula) .map((arg) => env.model.getters.evaluateFormula(arg)); - code = toString(code); + codes = toString(codes).split(","); const dateRange = parseAccountingDate(date_range); dateRange.year += offset || 0; companyId = companyId || null; @@ -32,7 +32,7 @@ cellMenuRegistry.add("move_lines_see_records", { const action = await env.services.orm.call( "account.account", "spreadsheet_move_line_action", - [camelToSnakeObject({ dateRange, companyId, code, includeUnposted })] + [camelToSnakeObject({ dateRange, companyId, codes, includeUnposted })] ); await env.services.action.doAction(action); }, diff --git a/addons/spreadsheet_account/static/tests/ui/accounting_drilldown_tests.js b/addons/spreadsheet_account/static/tests/ui/accounting_drilldown_tests.js index 883f64b69f1..98f6aca5c8c 100644 --- a/addons/spreadsheet_account/static/tests/ui/accounting_drilldown_tests.js +++ b/addons/spreadsheet_account/static/tests/ui/accounting_drilldown_tests.js @@ -49,7 +49,7 @@ QUnit.module("spreadsheet_account > Accounting Drill down", { beforeEach }, () = if (args.method === "spreadsheet_move_line_action") { assert.deepEqual(args.args, [ { - code: "100", + codes: ["100"], company_id: null, include_unposted: false, date_range: {