From 30047d89b9c9db4b3466f0ff19fdeb2a589494c0 Mon Sep 17 00:00:00 2001
From: "Pratik Raval (PRRA)" <prra@odoo.com>
Date: Mon, 16 Oct 2023 12:31:49 +0000
Subject: [PATCH] [FIX] survey: fix form view issues

Before this commit:
1) The `certification` field was visible when `scoring_type` was set to
'No scoring'.
2) The `description` field of the Badge in form view was not taking the full
width of the sheet.

After this commit:
1) The `certification` field will be invisible if `scoring_type` is set to
'No scoring'.
2) The `description` field of the Badge in form view will take the full width of
the sheet.

Task-3367524

closes odoo/odoo#141120

X-original-commit: 094b2c53e8065de383d35bd0725e247345289867
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
---
 addons/survey/views/gamification_badge_views.xml | 4 +---
 addons/survey/views/survey_survey_views.xml      | 4 ++--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/addons/survey/views/gamification_badge_views.xml b/addons/survey/views/gamification_badge_views.xml
index 65547ba1b49..905f6d1c4df 100644
--- a/addons/survey/views/gamification_badge_views.xml
+++ b/addons/survey/views/gamification_badge_views.xml
@@ -15,9 +15,7 @@
                             <field name="name" placeholder="e.g. Problem Solver"/>
                         </h1>
                     </div>
-                    <group>
-                        <field name="description" nolabel="1" placeholder="e.g. No one can solve challenges like you do"/>
-                    </group>
+                    <field name="description" placeholder="e.g. No one can solve challenges like you do"/>
                     <group string="Rewards for challenges">
                         <field name="level"/>
                     </group>
diff --git a/addons/survey/views/survey_survey_views.xml b/addons/survey/views/survey_survey_views.xml
index b1c30f8567f..94134683579 100644
--- a/addons/survey/views/survey_survey_views.xml
+++ b/addons/survey/views/survey_survey_views.xml
@@ -129,10 +129,10 @@
                                     <field name="scoring_type" widget="radio" force_save="1"/>
                                     <field name="scoring_success_min" invisible="scoring_type == 'no_scoring'" />
                                     <label for="certification"
-                                           invisible="survey_type == 'live_session'"/>
+                                           invisible="survey_type == 'live_session' or scoring_type == 'no_scoring'"/>
                                     <div class="o_checkbox_optional_field"
                                          invisible="survey_type == 'live_session'">
-                                        <field name="certification" nolabel="1"/>
+                                        <field name="certification" invisible="scoring_type == 'no_scoring'"/>
                                         <div invisible="not certification" class="w-100">
                                             <field name="certification_report_layout" placeholder="Pick a Style..." class="w-50"/>
                                             <button name="action_survey_preview_certification_template"