From 5f49551eaf5465b8a6a03a77ffe9371223cb29e1 Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Mon, 7 Feb 2011 11:13:02 +0530
Subject: [PATCH 01/11] [IMP]: Task-2009 Improve osv memory wizard for one2many
 filed

bzr revid: ksa@tinyerp.co.in-20110207054302-b9iajxd368wwzwng
---
 addons/hr_timesheet/wizard/hr_timesheet_print_employee.py   | 4 +++-
 .../wizard/hr_timesheet_final_invoice_create.py             | 3 +++
 addons/mrp/wizard/mrp_product_produce.py                    | 4 ++--
 .../wizard/project_scrum_backlog_create_task.py             | 3 +++
 addons/project_scrum/wizard/project_scrum_backlog_sprint.py | 3 +++
 .../wizard/purchase_requisition_partner.py                  | 6 +++++-
 6 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/addons/hr_timesheet/wizard/hr_timesheet_print_employee.py b/addons/hr_timesheet/wizard/hr_timesheet_print_employee.py
index 9775a8518ff..51af2444661 100644
--- a/addons/hr_timesheet/wizard/hr_timesheet_print_employee.py
+++ b/addons/hr_timesheet/wizard/hr_timesheet_print_employee.py
@@ -31,7 +31,7 @@ class analytical_timesheet_employee(osv.osv_memory):
                                   'Month', required=True),
         'year': fields.integer('Year', required=True),
         'employee_id': fields.many2one('hr.employee', 'Employee', required=True)
-    
+
                 }
 
     def _get_user(self, cr, uid, context=None):
@@ -50,6 +50,8 @@ class analytical_timesheet_employee(osv.osv_memory):
 
     def print_report(self, cr, uid, ids, context=None):
         data = self.read(cr, uid, ids, context=context)[0]
+        if isinstance(data['employee_id'], tuple):
+            data['employee_id'] = data['employee_id'][0]
         datas = {
              'ids': [],
              'model': 'hr.employee',
diff --git a/addons/hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py b/addons/hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py
index 8f1ef4ef261..cebcf072794 100644
--- a/addons/hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py
+++ b/addons/hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py
@@ -59,6 +59,9 @@ class final_invoice_create(osv.osv_memory):
         res = mod_obj.read(cr, uid, result, ['res_id'], context=context)
 
         data = self.read(cr, uid, ids, [], context=context)[0]
+        if isinstance(data['balance_product'], tuple):
+            data['balance_product'] = data['balance_product'][0]
+
         account_ids = 'active_ids' in context and context['active_ids'] or []
 
         for account in analytic_account_obj.browse(cr, uid, account_ids, context=context):
diff --git a/addons/mrp/wizard/mrp_product_produce.py b/addons/mrp/wizard/mrp_product_produce.py
index 6052cdb56f7..811c707eb2a 100644
--- a/addons/mrp/wizard/mrp_product_produce.py
+++ b/addons/mrp/wizard/mrp_product_produce.py
@@ -70,10 +70,10 @@ class mrp_product_produce(osv.osv_memory):
             context = {}
         prod_obj = self.pool.get('mrp.production')
         move_ids = context.get('active_ids', [])
-        for data in self.read(cr, uid, ids, context=context):
+        for data in self.browse(cr, uid, ids, context=context):
             for move_id in move_ids:
                 prod_obj.action_produce(cr, uid, move_id,
-                                    data['product_qty'], data['mode'], context=context)
+                                    data.product_qty, data.mode, context=context)
         return {}
 
 mrp_product_produce()
diff --git a/addons/project_scrum/wizard/project_scrum_backlog_create_task.py b/addons/project_scrum/wizard/project_scrum_backlog_create_task.py
index afa4f40a5f8..3a13b43ae19 100644
--- a/addons/project_scrum/wizard/project_scrum_backlog_create_task.py
+++ b/addons/project_scrum/wizard/project_scrum_backlog_create_task.py
@@ -35,6 +35,9 @@ class backlog_create_task(osv.osv_memory):
         ids_task = []
 
         data = self.read(cr, uid, ids, [], context=context)[0]
+        if isinstance(data['user_id'], tuple):
+            data['user_id'] = data['user_id'][0]
+
         backlogs = backlog_id.browse(cr, uid, context['active_ids'], context=context)
         result = mod_obj._get_id(cr, uid, 'project', 'view_task_search_form')
         id = mod_obj.read(cr, uid, result, ['res_id'])
diff --git a/addons/project_scrum/wizard/project_scrum_backlog_sprint.py b/addons/project_scrum/wizard/project_scrum_backlog_sprint.py
index 591e1d5da62..f953f886e5c 100644
--- a/addons/project_scrum/wizard/project_scrum_backlog_sprint.py
+++ b/addons/project_scrum/wizard/project_scrum_backlog_sprint.py
@@ -42,6 +42,9 @@ class backlog_sprint_assign(osv.osv_memory):
         if context is None:
             context = {}
         data = self.read(cr, uid, ids, [], context=context)[0]
+        if isinstance(data['sprint_id'], tuple):
+            data['sprint_id'] = data['sprint_id'][0]
+
         for backlog in backlog_obj.browse(cr, uid, context['active_ids'], context=context):
             backlog_ids.append(backlog.id)
             if data['convert_to_task']:
diff --git a/addons/purchase_requisition/wizard/purchase_requisition_partner.py b/addons/purchase_requisition/wizard/purchase_requisition_partner.py
index 8dba2ab2eae..9ff7a769a72 100644
--- a/addons/purchase_requisition/wizard/purchase_requisition_partner.py
+++ b/addons/purchase_requisition/wizard/purchase_requisition_partner.py
@@ -67,7 +67,11 @@ class purchase_requisition_partner(osv.osv_memory):
             context = {}
         record_ids = context and context.get('active_ids', False)
         if record_ids:
-            data =  self.read(cr, uid, ids)
+            data =  self.read(cr, uid, ids,context=context)
+            for m2o_field in ['partner_id','partner_address_id']:
+                if isinstance(data[0][m2o_field], tuple):
+                    data[0][m2o_field] = data[0][m2o_field][0]
+
             company = self.pool.get('res.users').browse(cr, uid, uid, context).company_id
             order_obj = self.pool.get('purchase.order')
             order_line_obj = self.pool.get('purchase.order.line')

From ca4c6c01a74fb435bd78b2da39d574a55d9eab7c Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Tue, 8 Feb 2011 18:55:12 +0530
Subject: [PATCH 02/11] [IMP]: improvement hr related changes

bzr revid: ksa@tinyerp.co.in-20110208132512-ts4frrrau5mbi4lh
---
 addons/hr/hr.py                         | 12 ++++++------
 addons/hr/security/hr_security.xml      |  2 +-
 addons/hr_holidays/hr_holidays_view.xml |  4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/addons/hr/hr.py b/addons/hr/hr.py
index e2b9a7089f3..5dc67e79d1b 100644
--- a/addons/hr/hr.py
+++ b/addons/hr/hr.py
@@ -204,15 +204,15 @@ class hr_employee(osv.osv):
             level -= 1
         return True
 
-    def _check_department_id(self, cr, uid, ids, context=None):
-        for emp in self.browse(cr, uid, ids, context=context):
-            if emp.department_id.manager_id and emp.id == emp.department_id.manager_id.id:
-                return False
-        return True
+#    def _check_department_id(self, cr, uid, ids, context=None):
+#        for emp in self.browse(cr, uid, ids, context=context):
+#            if emp.department_id.manager_id and emp.id == emp.department_id.manager_id.id:
+#                return False
+#        return True
 
     _constraints = [
         (_check_recursion, 'Error ! You cannot create recursive Hierarchy of Employees.', ['parent_id']),
-        (_check_department_id, 'Error ! You cannot select a department for which the employee is the manager.', ['department_id']),
+#        (_check_department_id, 'Error ! You cannot select a department for which the employee is the manager.', ['department_id']),
     ]
 
 hr_employee()
diff --git a/addons/hr/security/hr_security.xml b/addons/hr/security/hr_security.xml
index 61aa5a93b12..aba7d4b45e1 100644
--- a/addons/hr/security/hr_security.xml
+++ b/addons/hr/security/hr_security.xml
@@ -7,7 +7,7 @@
     </record>
 
     <record id="base.group_hr_user" model="res.groups">
-        <field name="name">Human Resources / User</field>
+        <field name="name">Human Resources / Officer</field>
     </record>
 </data>
 </openerp>
diff --git a/addons/hr_holidays/hr_holidays_view.xml b/addons/hr_holidays/hr_holidays_view.xml
index e207c2caf7d..49c1d5d249e 100644
--- a/addons/hr_holidays/hr_holidays_view.xml
+++ b/addons/hr_holidays/hr_holidays_view.xml
@@ -94,7 +94,7 @@
                             <field name="state" colspan="2"/>
                             <group colspan="2" col="6">
                                 <button string="Refuse" name="refuse" states="confirm,validate,validate1" type="workflow" icon="gtk-no" groups="base.group_hr_user,base.group_hr_manager"/>
-                                <button string="Confirm" name="confirm" states="draft" type="workflow" icon="gtk-yes"/>
+                                <button string="Submit to Manager" name="confirm" states="draft" type="workflow" icon="gtk-yes"/>
                                 <button string="Approve" name="validate" states="confirm" type="workflow" icon="gtk-apply" groups="base.group_hr_user"/>
                                 <button string="Approved" name="second_validate" states="validate1" type="workflow" icon="gtk-apply" groups="base.group_hr_user"/>
                                 <button string="Set to Draft" name="set_to_draft" states="refuse" type="object" icon="gtk-convert" groups="base.group_hr_user"/>
@@ -414,7 +414,7 @@
         </record>
 
         <menuitem sequence="3" id="hr.menu_open_view_attendance_reason_config" parent="hr.menu_hr_configuration" name="Holidays"/>
-        
+
         <menuitem name="Leave Type"
             action="open_view_holiday_status"
             id="menu_open_view_holiday_status"

From 325f875e89ca0e77fac03b075917326b07ce4d2a Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Wed, 9 Feb 2011 11:21:38 +0530
Subject: [PATCH 03/11] [IMP]: improvement for allow user to add a timesheet
 line of another day

bzr revid: ksa@tinyerp.co.in-20110209055138-rcmr7kf2fur8f7hc
---
 addons/hr_timesheet_sheet/hr_timesheet_sheet.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/hr_timesheet_sheet/hr_timesheet_sheet.py b/addons/hr_timesheet_sheet/hr_timesheet_sheet.py
index 3a4c4e5e29d..b5349cf6db9 100644
--- a/addons/hr_timesheet_sheet/hr_timesheet_sheet.py
+++ b/addons/hr_timesheet_sheet/hr_timesheet_sheet.py
@@ -269,7 +269,7 @@ class hr_timesheet_sheet(osv.osv):
                 'draft': [('readonly', False)],
                 'new': [('readonly', False)]}
             ),
-        'attendances_ids' : one2many_mod2('hr.attendance', 'sheet_id', 'Attendances', readonly=True,),
+        'attendances_ids' : one2many_mod2('hr.attendance', 'sheet_id', 'Attendances', readonly=True, states={'draft':[('readonly',False)],'new':[('readonly',False)]}),
         'state' : fields.selection([
             ('new', 'New'),
             ('draft','Draft'),

From f77e00af1989906561bd8569706e272f60800b85 Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Fri, 11 Feb 2011 16:16:24 +0530
Subject: [PATCH 04/11] [FIX]: Try to select destination address which has no
 partner on it

lp bug: https://launchpad.net/bugs/710516 fixed

bzr revid: ksa@tinyerp.co.in-20110211104624-5gqtxl14itgw1xvz
---
 addons/purchase/purchase.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/addons/purchase/purchase.py b/addons/purchase/purchase.py
index 2527d0d6a7e..f2ef17a183d 100644
--- a/addons/purchase/purchase.py
+++ b/addons/purchase/purchase.py
@@ -170,7 +170,7 @@ class purchase_order(osv.osv):
         'partner_id':fields.many2one('res.partner', 'Supplier', required=True, states={'confirmed':[('readonly',True)], 'approved':[('readonly',True)],'done':[('readonly',True)]}, change_default=True),
         'partner_address_id':fields.many2one('res.partner.address', 'Address', required=True,
             states={'confirmed':[('readonly',True)], 'approved':[('readonly',True)],'done':[('readonly',True)]},domain="[('partner_id', '=', partner_id)]"),
-        'dest_address_id':fields.many2one('res.partner.address', 'Destination Address', domain="[('partner_id', '!=', False)]",
+        'dest_address_id':fields.many2one('res.partner.address', 'Destination Address',
             states={'confirmed':[('readonly',True)], 'approved':[('readonly',True)],'done':[('readonly',True)]},
             help="Put an address if you want to deliver directly from the supplier to the customer." \
                 "In this case, it will remove the warehouse link and set the customer location."
@@ -257,9 +257,12 @@ class purchase_order(osv.osv):
     def onchange_dest_address_id(self, cr, uid, ids, adr_id):
         if not adr_id:
             return {}
-        part_id = self.pool.get('res.partner.address').read(cr, uid, [adr_id], ['partner_id'])[0]['partner_id'][0]
-        loc_id = self.pool.get('res.partner').browse(cr, uid, part_id).property_stock_customer.id
-        return {'value':{'location_id': loc_id, 'warehouse_id': False}}
+        values = {'warehouse_id': False}
+        part_id = self.pool.get('res.partner.address').browse(cr, uid, adr_id).partner_id
+        if part_id:
+            loc_id = part_id.property_stock_customer.id
+            values.update({'location_id': loc_id})
+        return {'value':values}
 
     def onchange_warehouse_id(self, cr, uid, ids, warehouse_id):
         if not warehouse_id:

From b9d28ac4493d5168b17e7f22846dccdb7ee48c58 Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Tue, 15 Feb 2011 12:07:34 +0530
Subject: [PATCH 05/11] [FIX]:Synchronization with all objects

lp bug: https://launchpad.net/bugs/711778 fixed

bzr revid: ksa@tinyerp.co.in-20110215063734-55nlbvn1jqt6yikc
---
 addons/base_synchro/wizard/base_synchro.py    | 40 ++++++++++---------
 .../base_synchro/wizard/base_synchro_view.xml |  1 +
 2 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/addons/base_synchro/wizard/base_synchro.py b/addons/base_synchro/wizard/base_synchro.py
index d3c1de40d6d..8ba00417b95 100644
--- a/addons/base_synchro/wizard/base_synchro.py
+++ b/addons/base_synchro/wizard/base_synchro.py
@@ -32,13 +32,13 @@ class RPCProxyOne(object):
     def __init__(self, server, ressource):
         self.server = server
         local_url = 'http://%s:%d/xmlrpc/common'%(server.server_url,server.server_port)
-        rpc = xmlrpclib.ServerProxy(local_url)
+        rpc = xmlrpclib.ServerProxy(local_url, allow_none=True)
         self.uid = rpc.login(server.server_db, server.login, server.password)
         local_url = 'http://%s:%d/xmlrpc/object'%(server.server_url,server.server_port)
-        self.rpc = xmlrpclib.ServerProxy(local_url)
+        self.rpc = xmlrpclib.ServerProxy(local_url, allow_none=True)
         self.ressource = ressource
     def __getattr__(self, name):
-        return lambda cr, uid, *args, **kwargs: self.rpc.execute(self.server.server_db, self.uid, self.server.password, self.ressource, name, *args, **kwargs)
+        return lambda cr, uid, *args, **kwargs: self.rpc.execute(self.server.server_db, self.uid, self.server.password, self.ressource, name, *args)
 
 class RPCProxy(object):
     def __init__(self, server):
@@ -79,6 +79,7 @@ class base_synchro(osv.osv_memory):
                 eval(object.domain),
                 {'action':'d'}
             )
+
         if object.action in ('u','b'):
             ids += pool2.get('base.synchro.obj').get_ids(cr, uid,
                 object.model_id.model,
@@ -102,7 +103,7 @@ class base_synchro(osv.osv_memory):
             if object.model_id.model=='crm.case.history':
                 fields = ['email','description','log_id']
             value = pool_src.get(object.model_id.model).read(cr, uid, [id], fields)[0]
-            value = self.data_transform(cr, uid, pool_src, pool_dest, object.model_id.model, value, action)
+            value = self.data_transform(cr, uid, pool_src, pool_dest, object.model_id.model, value, action, context=context)
             id2 = self.get_id(cr, uid, object.id, id, action, context)
             #
             # Transform value
@@ -110,7 +111,6 @@ class base_synchro(osv.osv_memory):
             #tid=pool_dest.get(object.model_id.model).name_search(cr, uid, value['name'],[],'=',)
             if not (iii%50):
                 print 'Record', iii
-
             # Filter fields to not sync
             for field in object.avoid_ids:
                 if field.name in value:
@@ -125,15 +125,17 @@ class base_synchro(osv.osv_memory):
                 self.report_write+=1
             else:
                 print value
-                idnew = pool_dest.get(object.model_id.model).create(cr, uid, value)
-                synid = self.pool.get('base.synchro.obj.line').create(cr, uid, {
-                    'obj_id': object.id,
-                    'local_id': (action=='u') and id or idnew,
-                    'remote_id': (action=='d') and id or idnew
-                })
-                self.report_total+=1
-                self.report_create+=1
-        self.meta = {}
+                new_value = pool_dest.get(object.model_id.model).search(cr, uid, [('name','=',value['name'])])
+                if not new_value:
+                    idnew = pool_dest.get(object.model_id.model).create(cr, uid, value)
+                    synid = self.pool.get('base.synchro.obj.line').create(cr, uid, {
+                        'obj_id': object.id,
+                        'local_id': (action=='u') and id or idnew,
+                        'remote_id': (action=='d') and id or idnew
+                    })
+                    self.report_total+=1
+                    self.report_create+=1
+            self.meta = {}
         return True
 
     def get_id(self, cr, uid, object_id, id, action, context=None):
@@ -219,13 +221,13 @@ class base_synchro(osv.osv_memory):
         server = pool.get('base.synchro.server').browse(cr, uid, ids, context=context)[0]
         for object in server.obj_ids:
             dt = time.strftime('%Y-%m-%d %H:%M:%S')
-            self.synchronize(cr, uid, server, object, context)
+            self.synchronize(cr, uid, server, object, context=context)
             if object.action=='b':
                 time.sleep(1)
                 dt = time.strftime('%Y-%m-%d %H:%M:%S')
             self.pool.get('base.synchro.obj').write(cr, uid, [object.id], {'synchronize_date': dt})
         end_date = time.strftime('%Y-%m-%d, %Hh %Mm %Ss')
-        if 'user_id' in syn_obj.user_id:
+        if syn_obj.user_id:
             request = pooler.get_pool(cr.dbname).get('res.request')
             if not self.report:
                 self.report.append('No exception.')
@@ -244,18 +246,20 @@ Exceptions:
             request.create(cr, uid, {
                 'name' : "Synchronization report",
                 'act_from' : uid,
-                'act_to' : syn_obj.user_id,
+                'act_to' : syn_obj.user_id.id,
                 'body': summary,
             })
             return True
 
     def upload_download_multi_thread(self, cr, uid, data, context=None):
-        threaded_synchronization = threading.Thread(target=self.upload_download, args=(cr, uid, data, context))
+        cr1 = pooler.get_db(cr.dbname).cursor()
+        threaded_synchronization = threading.Thread(target=self.upload_download, args=(cr1, uid, data, context))
         threaded_synchronization.run()
         data_obj = self.pool.get('ir.model.data')
         id2 = data_obj._get_id(cr, uid, 'base_synchro', 'view_base_synchro_finish')
         if id2:
             id2 = data_obj.browse(cr, uid, id2, context=context).res_id
+        cr.commit()
         return {
             'view_type': 'form',
             'view_mode': 'form',
diff --git a/addons/base_synchro/wizard/base_synchro_view.xml b/addons/base_synchro/wizard/base_synchro_view.xml
index c0c140f3791..231fc7b055f 100644
--- a/addons/base_synchro/wizard/base_synchro_view.xml
+++ b/addons/base_synchro/wizard/base_synchro_view.xml
@@ -25,6 +25,7 @@
             <field name="res_model">base.synchro</field>
             <field name="view_type">form</field>
             <field name="view_mode">form</field>
+            <field name="view_id" ref="view_base_synchro"/>
             <field name="target">new</field>
         </record>
 

From 34ce5acd01dc0d444957731597c8712f32ecdb12 Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Tue, 15 Feb 2011 17:36:58 +0530
Subject: [PATCH 06/11] [FIX]: production lot does not work

lp bug: https://launchpad.net/bugs/718685 fixed

bzr revid: ksa@tinyerp.co.in-20110215120658-48kkt5li2431esc1
---
 .../wizard/stock_inventory_line_split.py      | 57 ++++++++++---------
 1 file changed, 30 insertions(+), 27 deletions(-)

diff --git a/addons/stock/wizard/stock_inventory_line_split.py b/addons/stock/wizard/stock_inventory_line_split.py
index 11a6a2da323..2e8b93ad52b 100644
--- a/addons/stock/wizard/stock_inventory_line_split.py
+++ b/addons/stock/wizard/stock_inventory_line_split.py
@@ -29,65 +29,68 @@ class stock_inventory_line_split(osv.osv_memory):
     _name = "stock.inventory.line.split"
     _description = "Split inventory lines"
 
-    
+
     def default_get(self, cr, uid, fields, context=None):
-        """ To check the availability of production lot. 
+        """ To check the availability of production lot.
         @param self: The object pointer.
         @param cr: A database cursor
         @param uid: ID of the user currently logged in
-        @param fields: List of fields for which we want default values 
-        @param context: A standard dictionary 
-        @return: A dictionary which of fields with values. 
-        """        
+        @param fields: List of fields for which we want default values
+        @param context: A standard dictionary
+        @return: A dictionary which of fields with values.
+        """
         if context is None:
             context = {}
         record_id = context and context.get('active_id',False)
         res = {}
-        line = self.pool.get('stock.inventory.line').browse(cr, uid, record_id, context=context)        
+        line = self.pool.get('stock.inventory.line').browse(cr, uid, record_id, context=context)
         if 'product_id' in fields:
             res.update({'product_id':line.product_id.id})
         if 'product_uom' in fields:
             res.update({'product_uom': line.product_uom.id})
         if 'qty' in fields:
-            res.update({'qty': line.product_qty})       
+            res.update({'qty': line.product_qty})
         return res
-    
+
     def split(self, cr, uid, ids, line_ids, context=None):
         """ To split stock inventory lines according to production lot.
         @param self: The object pointer.
         @param cr: A database cursor
         @param uid: ID of the user currently logged in
-        @param ids: the ID or list of IDs if we want more than one 
+        @param ids: the ID or list of IDs if we want more than one
         @param line_ids: the ID or list of IDs of inventory lines we want to split
-        @param context: A standard dictionary 
-        @return: 
-        """                    
+        @param context: A standard dictionary
+        @return:
+        """
         prodlot_obj = self.pool.get('stock.production.lot')
         ir_sequence_obj = self.pool.get('ir.sequence')
         line_obj = self.pool.get('stock.inventory.line')
-        new_line = []        
+        new_line = []
         for data in self.browse(cr, uid, ids, context=context):
             for inv_line in line_obj.browse(cr, uid, line_ids, context=context):
                 line_qty = inv_line.product_qty
-                quantity_rest = inv_line.product_qty                
-                new_line = []   
+                quantity_rest = inv_line.product_qty
+                new_line = []
                 if data.use_exist:
                     lines = [l for l in data.line_exist_ids if l]
                 else:
-                    lines = [l for l in data.line_ids if l]                         
+                    lines = [l for l in data.line_ids if l]
                 for line in lines:
                     quantity = line.quantity
                     if quantity <= 0 or line_qty == 0:
                         continue
-                    quantity_rest -= quantity                    
-                    if quantity_rest <= 0:
+                    quantity_rest -= quantity
+                    if quantity_rest < 0:
                         quantity_rest = quantity
                         break
                     default_val = {
-                        'product_qty': quantity,                         
+                        'product_qty': quantity,
                     }
-                    current_line = line_obj.copy(cr, uid, inv_line.id, default_val)
-                    new_line.append(current_line)
+                    if quantity_rest > 0:
+                        current_line = line_obj.copy(cr, uid, inv_line.id, default_val)
+                        new_line.append(current_line)
+                    if quantity_rest == 0:
+                        current_line = inv_line.id
                     prodlot_id = False
                     if data.use_exist:
                         prodlot_id = line.prodlot_id.id
@@ -97,13 +100,13 @@ class stock_inventory_line_split(osv.osv_memory):
                             'product_id': inv_line.product_id.id},
                         context=context)
                     line_obj.write(cr, uid, [current_line], {'prod_lot_id': prodlot_id})
-                    prodlot = prodlot_obj.browse(cr, uid, prodlot_id)                    
-                    
+                    prodlot = prodlot_obj.browse(cr, uid, prodlot_id)
+
                     update_val = {}
-                    if quantity_rest > 0:                        
-                        update_val['product_qty'] = quantity_rest                                            
+                    if quantity_rest > 0:
+                        update_val['product_qty'] = quantity_rest
                         line_obj.write(cr, uid, [inv_line.id], update_val)
-                    
+
         return new_line
 stock_inventory_line_split()
 

From 0fbf994b7eb7ec941b7834bed33d79520447a72b Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Tue, 15 Feb 2011 18:13:46 +0530
Subject: [PATCH 07/11] [IMP]: improve for base synchro module related bug code

bzr revid: ksa@tinyerp.co.in-20110215124346-acu977ksffoxvcou
---
 addons/base_synchro/wizard/base_synchro.py | 23 ++++++++++------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/addons/base_synchro/wizard/base_synchro.py b/addons/base_synchro/wizard/base_synchro.py
index 8ba00417b95..6c3db7f2f6c 100644
--- a/addons/base_synchro/wizard/base_synchro.py
+++ b/addons/base_synchro/wizard/base_synchro.py
@@ -125,16 +125,14 @@ class base_synchro(osv.osv_memory):
                 self.report_write+=1
             else:
                 print value
-                new_value = pool_dest.get(object.model_id.model).search(cr, uid, [('name','=',value['name'])])
-                if not new_value:
-                    idnew = pool_dest.get(object.model_id.model).create(cr, uid, value)
-                    synid = self.pool.get('base.synchro.obj.line').create(cr, uid, {
-                        'obj_id': object.id,
-                        'local_id': (action=='u') and id or idnew,
-                        'remote_id': (action=='d') and id or idnew
-                    })
-                    self.report_total+=1
-                    self.report_create+=1
+                idnew = pool_dest.get(object.model_id.model).create(cr, uid, value)
+                synid = self.pool.get('base.synchro.obj.line').create(cr, uid, {
+                    'obj_id': object.id,
+                    'local_id': (action=='u') and id or idnew,
+                    'remote_id': (action=='d') and id or idnew
+                })
+                self.report_total+=1
+                self.report_create+=1
             self.meta = {}
         return True
 
@@ -218,7 +216,7 @@ class base_synchro(osv.osv_memory):
         start_date = time.strftime('%Y-%m-%d, %Hh %Mm %Ss')
         syn_obj = self.browse(cr, uid, ids, context=context)[0]
         pool = pooler.get_pool(cr.dbname)
-        server = pool.get('base.synchro.server').browse(cr, uid, ids, context=context)[0]
+        server = pool.get('base.synchro.server').browse(cr, uid, syn_obj.server_url.id, context=context)
         for object in server.obj_ids:
             dt = time.strftime('%Y-%m-%d %H:%M:%S')
             self.synchronize(cr, uid, server, object, context=context)
@@ -252,8 +250,7 @@ Exceptions:
             return True
 
     def upload_download_multi_thread(self, cr, uid, data, context=None):
-        cr1 = pooler.get_db(cr.dbname).cursor()
-        threaded_synchronization = threading.Thread(target=self.upload_download, args=(cr1, uid, data, context))
+        threaded_synchronization = threading.Thread(target=self.upload_download, args=(cr, uid, data, context))
         threaded_synchronization.run()
         data_obj = self.pool.get('ir.model.data')
         id2 = data_obj._get_id(cr, uid, 'base_synchro', 'view_base_synchro_finish')

From 6fd5b215a2ca8c856b6475d26e37abe07f1b215d Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Wed, 16 Feb 2011 12:05:23 +0530
Subject: [PATCH 08/11] [IMP]: improve base synchronization code

bzr revid: ksa@tinyerp.co.in-20110216063523-jsgi7svhgnmmwuzu
---
 addons/base_synchro/wizard/base_synchro.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/addons/base_synchro/wizard/base_synchro.py b/addons/base_synchro/wizard/base_synchro.py
index 6c3db7f2f6c..49c8d8fa2ec 100644
--- a/addons/base_synchro/wizard/base_synchro.py
+++ b/addons/base_synchro/wizard/base_synchro.py
@@ -32,10 +32,10 @@ class RPCProxyOne(object):
     def __init__(self, server, ressource):
         self.server = server
         local_url = 'http://%s:%d/xmlrpc/common'%(server.server_url,server.server_port)
-        rpc = xmlrpclib.ServerProxy(local_url, allow_none=True)
+        rpc = xmlrpclib.ServerProxy(local_url)
         self.uid = rpc.login(server.server_db, server.login, server.password)
         local_url = 'http://%s:%d/xmlrpc/object'%(server.server_url,server.server_port)
-        self.rpc = xmlrpclib.ServerProxy(local_url, allow_none=True)
+        self.rpc = xmlrpclib.ServerProxy(local_url)
         self.ressource = ressource
     def __getattr__(self, name):
         return lambda cr, uid, *args, **kwargs: self.rpc.execute(self.server.server_db, self.uid, self.server.password, self.ressource, name, *args)
@@ -256,7 +256,6 @@ Exceptions:
         id2 = data_obj._get_id(cr, uid, 'base_synchro', 'view_base_synchro_finish')
         if id2:
             id2 = data_obj.browse(cr, uid, id2, context=context).res_id
-        cr.commit()
         return {
             'view_type': 'form',
             'view_mode': 'form',

From a8d7bde551b4c5200d4b4e13447c2d001a0db6ee Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Wed, 16 Feb 2011 15:45:33 +0530
Subject: [PATCH 09/11] [FIX]: Defining supplier UOM for product not default

lp bug: https://launchpad.net/bugs/718896 fixed

bzr revid: ksa@tinyerp.co.in-20110216101533-o0en12copnkix3b4
---
 addons/product/product.py       | 14 +++++++++-----
 addons/product/product_view.xml |  2 +-
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/addons/product/product.py b/addons/product/product.py
index bbf3ea1b646..9c5ff4f8505 100644
--- a/addons/product/product.py
+++ b/addons/product/product.py
@@ -482,7 +482,7 @@ class product_product(osv.osv):
         'pricelist_id': fields.dummy(string='Pricelist', relation='product.pricelist', type='many2one'),
         'name_template': fields.related('product_tmpl_id', 'name', string="Name", type='char', size=128, store=True),
     }
-    
+
     def unlink(self, cr, uid, ids, context=None):
         unlink_ids = []
         unlink_product_tmpl_ids = []
@@ -715,10 +715,14 @@ class product_supplierinfo(osv.osv):
             result[supplier_info.id]['qty'] = qty
         return result
 
-    def _get_uom_id(self, cr, uid, *args):
-        cr.execute('select id from product_uom order by id limit 1')
-        res = cr.fetchone()
-        return res and res[0] or False
+    def _get_uom_id(self, cr, uid, context=None):
+        uom_id = context.get('uom_id', False)
+        if uom_id:
+            return uom_id
+        else:
+            cr.execute('select id from product_uom order by id limit 1')
+            res = cr.fetchone()
+            return res and res[0] or False
 
     _columns = {
         'name' : fields.many2one('res.partner', 'Supplier', required=True,domain = [('supplier','=',True)], ondelete='cascade', help="Supplier of this product"),
diff --git a/addons/product/product_view.xml b/addons/product/product_view.xml
index 83240716715..70d61ee453d 100644
--- a/addons/product/product_view.xml
+++ b/addons/product/product_view.xml
@@ -150,7 +150,7 @@
 
                         </page>
                         <page string="Suppliers">
-                            <field colspan="4" name="seller_ids" nolabel="1"/>
+                            <field colspan="4" name="seller_ids" nolabel="1" context="{'uom_id': uom_id}"/>
                         </page>
                         <page string="Descriptions">
                             <separator string="Description"/>

From 88bcdbd41d7147b02791895427a0a968cd985197 Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Wed, 16 Feb 2011 16:15:58 +0530
Subject: [PATCH 10/11] [IMP]: check if context is none

bzr revid: ksa@tinyerp.co.in-20110216104558-seg6lbd3ccm20s2u
---
 addons/product/product.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/addons/product/product.py b/addons/product/product.py
index 9c5ff4f8505..6e0ff11e674 100644
--- a/addons/product/product.py
+++ b/addons/product/product.py
@@ -716,6 +716,8 @@ class product_supplierinfo(osv.osv):
         return result
 
     def _get_uom_id(self, cr, uid, context=None):
+        if context is None:
+            context = {}
         uom_id = context.get('uom_id', False)
         if uom_id:
             return uom_id

From b8c1d07c84aade4d60b07bb4cac6bae6e0a60514 Mon Sep 17 00:00:00 2001
From: "ksa (Open ERP)" <ksa@tinyerp.co.in>
Date: Thu, 17 Feb 2011 12:46:22 +0530
Subject: [PATCH 11/11] [FIX]:manufactorig : missing label on field of bill of
 meterials

lp bug: https://launchpad.net/bugs/720288 fixed

bzr revid: ksa@tinyerp.co.in-20110217071622-1y13vj3edn43wsc3
---
 addons/mrp/mrp_view.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/addons/mrp/mrp_view.xml b/addons/mrp/mrp_view.xml
index 52a3dc6aca4..5132a6f9f34 100644
--- a/addons/mrp/mrp_view.xml
+++ b/addons/mrp/mrp_view.xml
@@ -406,6 +406,8 @@
                             <field name="date_stop"/>
                             <field name="product_rounding"/>
                             <field name="product_efficiency" groups="base.group_extended"/>
+                            <separator string="Properties" colspan="4"/>
+                            <newline/>
                             <field colspan="4" name="property_ids" nolabel="2" groups="base.group_extended"/>
                         </page>
                     </notebook>