From 2f4094802291d5aef2bf7c68e31a2b0cc01b00d9 Mon Sep 17 00:00:00 2001 From: "Lucas Perais (lpe)" Date: Thu, 10 Oct 2019 12:49:00 +0000 Subject: [PATCH] [FIX] website: oe_no_empty only in edit mode Test case; The user as edition rights on the website Install quotation builder Have a sale order with many lines Click preview > you end up on the portal view Before this commit, there was a blank space just before the sale order lines per se This was because the sale order's lines website description were in the dom and took some fixed space, which is a feature meant for the edit mode by using the class oe_no_empty After this commit, we restrict the effect of that class concerning the fixed height only to edit mode There is no more gaps in the sale order preview In master, one should check whether the class / rule is still relevant OPW 2082267 closes odoo/odoo#38435 X-original-commit: 4b177412235cdf3e62f5ff30c18246c003c25cc2 Signed-off-by: Lucas Perais (lpe) --- addons/website/static/src/scss/website.edit_mode.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/website/static/src/scss/website.edit_mode.scss b/addons/website/static/src/scss/website.edit_mode.scss index c019975249f..fd42d78a8bd 100644 --- a/addons/website/static/src/scss/website.edit_mode.scss +++ b/addons/website/static/src/scss/website.edit_mode.scss @@ -78,7 +78,8 @@ $-editor-messages-margin-x: 2%; display: block!important; } -[data-oe-type=html].oe_no_empty:empty { +// TODO: in master check if the class / rule is relevant at all +.editor_enable [data-oe-type=html].oe_no_empty:empty { height: 16px!important; }