From 2e2703990f37d45e1a5d11504ebbad869fa18791 Mon Sep 17 00:00:00 2001
From: "Michael (mcm)" <mcm@odoo.com>
Date: Wed, 16 Aug 2023 13:45:56 +0000
Subject: [PATCH] [IMP] web,*: remove unused legacy templates

task 3439226

closes odoo/odoo#133140

Related: odoo/enterprise#46278
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
---
 .../hr/static/src/xml/work_permit_upload.xml  |   8 -
 addons/hr_expense/__manifest__.py             |   1 -
 .../static/src/xml/documents_upload_views.xml |  21 --
 .../static/src/xml/expense_dashboard.xml      |  17 --
 .../src/xml/expense_qr_modal_template.xml     |  11 -
 addons/web/__manifest__.py                    |   2 -
 addons/web/static/src/legacy/xml/base.xml     | 246 ------------------
 addons/web/static/src/legacy/xml/fields.xml   |  13 -
 8 files changed, 319 deletions(-)
 delete mode 100644 addons/hr/static/src/xml/work_permit_upload.xml
 delete mode 100644 addons/hr_expense/static/src/xml/documents_upload_views.xml
 delete mode 100644 addons/hr_expense/static/src/xml/expense_dashboard.xml
 delete mode 100644 addons/hr_expense/static/src/xml/expense_qr_modal_template.xml
 delete mode 100644 addons/web/static/src/legacy/xml/fields.xml

diff --git a/addons/hr/static/src/xml/work_permit_upload.xml b/addons/hr/static/src/xml/work_permit_upload.xml
deleted file mode 100644
index 28a18a93b37..00000000000
--- a/addons/hr/static/src/xml/work_permit_upload.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<templates id="template" xml:space="preserve">
-    <t  t-name="hr.WorkPermitUpload" t-inherit="web.FieldBinaryFile" t-inherit-mode="primary">
-        <xpath expr="//button[@title='Select']" position="attributes">
-            <attribute name="class" remove="btn-primary" add="btn-secondary" separator=" "/>
-        </xpath>
-    </t>
-</templates>
diff --git a/addons/hr_expense/__manifest__.py b/addons/hr_expense/__manifest__.py
index 1f4754ae4cf..008286632e7 100644
--- a/addons/hr_expense/__manifest__.py
+++ b/addons/hr_expense/__manifest__.py
@@ -61,7 +61,6 @@ This module also uses analytic accounting and is compatible with the invoice on
             'hr_expense/static/src/views/*.js',
             'hr_expense/static/src/views/*.xml',
             'hr_expense/static/src/scss/hr_expense.scss',
-            'hr_expense/static/src/xml/**/*',
             'hr_expense/static/src/js/tours/*.js',
         ],
         'web.assets_tests': [
diff --git a/addons/hr_expense/static/src/xml/documents_upload_views.xml b/addons/hr_expense/static/src/xml/documents_upload_views.xml
deleted file mode 100644
index 495e6cc1c36..00000000000
--- a/addons/hr_expense/static/src/xml/documents_upload_views.xml
+++ /dev/null
@@ -1,21 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<templates>
-    <t t-name="hr.expense.DocumentsHiddenUploadForm">
-        <div class="d-none o_expense_documents_upload">
-            <t t-call="HiddenInputFile">
-                <t t-set="multi_upload" t-value="true"/>
-                <t t-set="fileupload_id" t-value="widget.fileUploadID"/>
-                <t t-set="fileupload_action" t-translation="off">/web/binary/upload_attachment</t>
-                <input type="hidden" name="model" t-att-value="'hr.expense'"/>
-                <input type="hidden" name="id" t-att-value="0"/>
-            </t>
-        </div>
-    </t>
-
-    <t t-name="hr.expense.DocumentDropZone">
-        <div class="o_drop_area d-none">
-            <i class="fa fa-upload fa-10x"></i>
-        </div>
-    </t>
-</templates>
diff --git a/addons/hr_expense/static/src/xml/expense_dashboard.xml b/addons/hr_expense/static/src/xml/expense_dashboard.xml
deleted file mode 100644
index ba9b1dce78e..00000000000
--- a/addons/hr_expense/static/src/xml/expense_dashboard.xml
+++ /dev/null
@@ -1,17 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<templates id="template">
-    <t t-name="hr_expense.dashboard_list_header">
-        <div class="o_expense_container position-sticky start-0 d-flex o_form_statusbar">
-            <t t-foreach="expenses" t-as="expense" t-key="expense_index">
-                <div t-attf-class="o_expense_card o_arrow_button flex-grow-1 d-flex flex-column p-3 border-bottom text-center">
-                    <span t-esc="render_monetary_field(expenses[expense]['amount'], expenses[expense]['currency'])" class="h2 m-0 text-odoo"/>
-                    <b class="mx-2" t-esc="expenses[expense]['description']"/>
-                </div>
-                <div t-if="expense !== 'approved'" t-attf-class="o_expense_card o_arrow_button flex-grow-1 d-flex flex-column p-3 border-bottom text-center">
-                    <i class="fa fa-angle-right fa-3x"/>
-                </div>
-            </t>
-        </div>
-    </t>
-</templates>
diff --git a/addons/hr_expense/static/src/xml/expense_qr_modal_template.xml b/addons/hr_expense/static/src/xml/expense_qr_modal_template.xml
deleted file mode 100644
index 00a59f418fe..00000000000
--- a/addons/hr_expense/static/src/xml/expense_qr_modal_template.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<templates id="template" xml:space="preserve">
-<t t-name="hr_expense_qr_code">
-    <div style="text-align:center;" class="o_expense_modal">
-        <t t-if="widget.url">
-            <h3>Scan this QR code to get the Odoo app:</h3><br/><br/>
-            <img class="border border-dark rounded" t-att-src="widget.url"/>
-        </t>
-    </div>
-</t>
-</templates>
diff --git a/addons/web/__manifest__.py b/addons/web/__manifest__.py
index e83395003d7..2872e818b4f 100644
--- a/addons/web/__manifest__.py
+++ b/addons/web/__manifest__.py
@@ -169,8 +169,6 @@ This module provides the core of the Odoo Web Client.
             'web/static/src/legacy/js/owl_compatibility.js',
 
             'web/static/src/legacy/xml/base.xml',
-            'web/static/src/legacy/xml/fields.xml',
-            'web/static/src/legacy/xml/week_days.xml',
             # Don't include dark mode files in light mode
             ('remove', 'web/static/src/**/*.dark.scss'),
         ],
diff --git a/addons/web/static/src/legacy/xml/base.xml b/addons/web/static/src/legacy/xml/base.xml
index 626084e14da..3e3b1924a1a 100644
--- a/addons/web/static/src/legacy/xml/base.xml
+++ b/addons/web/static/src/legacy/xml/base.xml
@@ -3,58 +3,6 @@
 
 <!-- Owl Templates -->
 
-<t t-name="web.DialogButton.tooltip">
-    <div class="oe_tooltip_string" role="tooltip">
-        <div class="tooltip-inner">
-            <t>Hit ENTER to <t t-esc="title"/></t>
-        </div>
-    </div>
-</t>
-
-<t t-name="web.legacy.Pager">
-    <nav class="o_pager align-items-center d-flex gap-2" aria-label="Pager">
-        <span class="o_pager_counter" t-on-click.stop="">
-            <input t-if="state.editing" type="text"
-                class="o_pager_value o_input d-inline-block w-auto text-end"
-                size="7"
-                t-ref="autofocus"
-                t-att-value="value"
-                t-on-blur="() => { this.state.editing = false }"
-                t-on-change="_onValueChange"
-                t-on-keydown.stop="_onValueKeydown"
-            />
-            <span t-else=""
-                class="o_pager_value d-inline-block border-bottom border-white"
-                t-esc="value"
-                t-on-click="_onEdit"
-            />
-            <span> / </span>
-            <span class="o_pager_limit" t-esc="props.size"/>
-        </span>
-        <span class="btn-group" aria-atomic="true">
-            <!-- accesskeys not wanted in X2Many widgets -->
-            <button type="button"
-                class="oi oi-chevron-left px-2 btn btn-secondary o_pager_previous rounded-start"
-                t-att-disabled="state.disabled || singlePage"
-                t-att-accesskey="props.withAccessKey ? 'p' : false"
-                aria-label="Previous page"
-                title="Previous page"
-                tabindex="-1"
-                t-on-click="ev => this._changeSelection(-1, ev)"
-            />
-            <button type="button"
-                class="oi oi-chevron-right px-2 btn btn-secondary o_pager_next rounded-end"
-                t-att-disabled="state.disabled || singlePage"
-                t-att-accesskey="props.withAccessKey ? 'n' : false"
-                aria-label="Next page"
-                title="Next page"
-                tabindex="-1"
-                t-on-click="ev => this._changeSelection(1, ev)"
-            />
-        </span>
-    </nav>
-</t>
-
 <t t-name="web.ViewSwitcherButton">
     <t t-set="buttonLabel">View %s</t>
     <button type="button"
@@ -70,10 +18,6 @@
 
 <!-- Legacy Templates -->
 
-<div t-name="Action" class="o_action">
-    <div class="o_content"/>
-</div>
-
 <t t-name="FormButton.tooltip">
     <div class="oe_tooltip_string" role="tooltip">
         <div class="tooltip-inner">
@@ -96,183 +40,6 @@
         <span class="o_datepicker_button"/>
     </div>
 </t>
-<t t-name="web.Legacy.FieldSelection">
-    <span t-if="widget.mode === 'readonly'"/>
-
-    <select t-if="widget.mode !== 'readonly'"
-        class="o_input"
-        t-att-name="widget.name"
-        t-att-tabindex="widget.attrs.tabindex"
-        t-att-autofocus="widget.attrs.autofocus"
-        t-att-id="widget.idForLabel"/>
-</t>
-<t t-name="FieldRadio.button">
-    <div class="form-check o_radio_item" aria-atomic="true">
-        <input type="radio" class="form-check-input o_radio_input" t-att-checked="checked ? true : undefined" t-att-disabled="disabled ? true : undefined"
-            t-att-name="name" t-att-data-value="value[0]" t-att-data-index="index" t-att-id="id"/>
-        <label class="form-check-label o_form_label" t-att-for="id"><t t-esc="value[1]"/></label>
-    </div>
-</t>
-
-<t t-name="FieldMany2One">
-    <t t-if="widget.mode === 'readonly'">
-        <a t-if="!widget.noOpen" t-att-tabindex="widget.attrs.tabindex" class="o_form_uri" href="#"/>
-        <span t-if="widget.noOpen"/>
-    </t>
-    <div t-if="widget.mode === 'edit'" class="o_field_widget o_field_many2one" aria-atomic="true">
-        <div class="o_field_many2one_selection">
-            <div class="o_input_dropdown">
-                <input type="text" class="o_input form-control"
-                    t-att-barcode_events="widget.nodeOptions.barcode_events"
-                    t-att-tabindex="widget.attrs.tabindex"
-                    t-att-autofocus="widget.attrs.autofocus"
-                    t-att-placeholder="widget.attrs.placeholder"
-                    t-att-id="widget.idForLabel"/>
-                <a role="button" class="o_dropdown_button" draggable="false"/>
-            </div>
-            <button type="button" t-if="!widget.noOpen" class="fa fa-external-link btn btn-secondary o_external_button" tabindex="-1" draggable="false" aria-label="External link" title="External link"/>
-        </div>
-        <div class="o_field_many2one_extra"/>
-    </div>
-</t>
-
-<t t-name="web.Many2OneAvatar">
-    <div class="o_m2o_avatar">
-        <img t-if="widget.value" t-att-src="url" t-att-alt="value"/>
-        <span t-elif="widget.mode === 'edit'" class="o_m2o_avatar_empty"></span>
-        <span t-if="widget.mode === 'readonly'" t-esc="value"/>
-    </div>
-</t>
-
-<t t-name="FieldMany2ManyTag">
-    <t t-foreach="elements" t-as="el" t-key="el_index">
-        <t t-set="color" t-value="el[colorField] || 0"/>
-        <t t-set="colornames" t-value="['No color', 'Red', 'Orange', 'Yellow', 'Light blue', 'Dark purple', 'Salmon pink', 'Medium blue', 'Dark blue', 'Fushia', 'Green', 'Purple']"/>
-        <div t-attf-class="badge rounded-pill #{hasDropdown ? 'dropdown' : ''} o_tag_color_#{color}" t-att-data-color="color" t-att-data-index="el_index" t-att-data-id="el.id" t-attf-title="Tag color: #{colornames[color]}">
-            <t t-set="_badge_text">
-                <span class="o_badge_text" t-att-title="el.display_name"><span role="img" t-attf-aria-label="Tag color: #{colornames[color]}"/><span class="o_tag_badge_text" t-esc="el.display_name"/></span>
-            </t>
-            <t t-if="hasDropdown">
-                <a role="button" href="#" class="dropdown-toggle o-no-caret" aria-expanded="false">
-                    <t t-out="_badge_text"/>
-                </a>
-            </t>
-            <t t-else="">
-                <t t-out="_badge_text"/>
-            </t>
-            <a t-if="!readonly" href="#" class="fa fa-times o_delete" title="Delete" aria-label="Delete"/>
-        </div>
-    </t>
-</t>
-<t t-name="FieldMany2ManyTagAvatar" t-extend="FieldMany2ManyTag">
-    <t t-jquery="t[t-set='_badge_text']" t-operation="before">
-        <span><img t-attf-src="/web/image/#{avatarModel}/#{el.id}/#{avatarField}" t-att-data-id="el.id" class="rounded-circle o_m2m_avatar"/></span>
-    </t>
-</t>
-<t t-name="KanbanMany2ManyTagAvatar">
-    <t t-set="visibleElements" t-value="elements.length === widget.visibleAvatarCount ? elements : elements.slice(0, widget.visibleAvatarCount - 1)"/>
-    <t t-foreach="visibleElements" t-as="el" t-key="el_index">
-        <span><img t-attf-src="/web/image/#{avatarModel}/#{el.id}/#{avatarField}" t-att-title="el.display_name" t-att-data-id="el.id" class="rounded-circle o_m2m_avatar"/></span>
-    </t>
-    <t t-if="elements.length > widget.visibleAvatarCount">
-        <span class="o_m2m_avatar_empty rounded-circle text-center fw-bold">
-            <span t-if="elements.length - widget.visibleAvatarCount + 1 > 9">9+</span>
-            <span t-else="">+<t t-esc="elements.length - widget.visibleAvatarCount + 1"/></span>
-        </span>
-    </t>
-</t>
-<t t-name="ListMany2ManyTagAvatar">
-    <t t-if="widget.mode !== 'readonly'">
-        <t t-call="FieldMany2ManyTagAvatar"/>
-    </t>
-    <t t-else="">
-        <t t-if="elements.length === 1">
-            <div>
-                <img t-attf-src="/web/image/#{avatarModel}/#{elements[0].id}/#{avatarField}" t-att-data-id="elements[0].id" class="rounded-circle o_m2m_avatar"/>
-                <span t-esc="elements[0].display_name"/>
-            </div>
-        </t>
-        <t t-else="">
-            <t t-set="visibleElements" t-value="elements.length === widget.visibleAvatarCount ? elements : elements.slice(0, widget.visibleAvatarCount - 1)"/>
-            <t t-foreach="visibleElements" t-as="el" t-key="el_index">
-                <span><img t-attf-src="/web/image/#{avatarModel}/#{el.id}/#{avatarField}" t-att-title="el.display_name" t-att-data-id="el.id" class="rounded-circle o_m2m_avatar"/></span>
-            </t>
-            <t t-if="elements.length > widget.visibleAvatarCount">
-                <span class="o_m2m_avatar_empty rounded-circle text-center fw-bold">
-                    <span t-if="elements.length - widget.visibleAvatarCount + 1 > 9">9+</span>
-                    <span t-else="">+<t t-esc="elements.length - widget.visibleAvatarCount + 1"/></span>
-                </span>
-            </t>
-        </t>
-    </t>
-</t>
-<t t-name="Many2ManyTagAvatarPopover">
-    <t t-foreach="elements" t-as="el" t-key="el_index">
-        <div><t t-esc="el.display_name"/></div>
-    </t>
-</t>
-<t t-name="FieldMany2ManyTag.colorpicker">
-    <div class="o_colorpicker dropdown-menu tagcolor_dropdown_menu" role="menu">
-        <ul>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_1" data-color="1" title="Red" aria-label="Red"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_2" data-color="2" title="Orange" aria-label="Orange"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_3" data-color="3" title="Yellow" aria-label="Yellow"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_4" data-color="4" title="Light blue" aria-label="Light blue"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_5" data-color="5" title="Dark purple" aria-label="Dark purple"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_6" data-color="6" title="Salmon pink" aria-label="Salmon pink"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_7" data-color="7" title="Medium blue" aria-label="Medium blue"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_8" data-color="8" title="Dark blue" aria-label="Dark blue"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_9" data-color="9" title="Fushia" aria-label="Fushia"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_10" data-color="10" title="Green" aria-label="Green"/></li>
-            <li><a role="menuitem" href="#" t-att-data-id="tag_id" class="o_tag_color_11" data-color="11" title="Purple" aria-label="Purple"/></li>
-            <li> <!-- checkbox for tag color 0 -->
-                <div role="menuitem" class="o_hide_in_kanban"
-                     t-att-data-id="tag_id"
-                     t-att-data-color="0">
-                    <div class="form-check">
-                        <input type="checkbox" id="o_hide_in_kanban_checkbox" class="form-check-input"/>
-                        <label for="o_hide_in_kanban_checkbox" class="form-check-label">Hide in Kanban</label>
-                    </div>
-                </div>
-            </li>
-        </ul>
-    </div>
-</t>
-<t t-name="FieldBinaryFile">
-    <a t-if="widget.mode === 'readonly'" href="javascript:void(0)" class="o_form_uri"/>
-
-    <div t-if="widget.mode !== 'readonly'" class="o_field_binary_file" aria-atomic="true">
-        <input type="text" class="o_input"
-            readonly="readonly"
-            t-att-name="widget.name"
-            t-att-tabindex="widget.attrs.tabindex"
-            t-att-autofocus="widget.attrs.autofocus"/>
-
-        <button type="button" class="btn btn-primary o_select_file_button" title="Select">Upload your file</button>
-        <button type="button" class="btn btn-secondary fa fa-pencil o_select_file_button" title="Select" aria-label="Select"/>
-        <button type="button" class="btn btn-secondary fa fa-trash-o o_clear_file_button" title="Clear" aria-label="Clear"/>
-
-        <span class="o_form_binary_progress">Uploading...</span>
-        <t t-call="HiddenInputFile">
-            <t t-set="fileupload_id" t-value="widget.fileupload_id"/>
-            <t t-set="fileupload_style" t-translation="off">overflow-x: hidden</t>
-        </t>
-    </div>
-</t>
-
-<t t-name="HiddenInputFile">
-    <div t-attf-class="o_hidden_input_file #{fileupload_class or ''}" t-att-style="fileupload_style" aria-atomic="true">
-        <form class="o_form_binary_form" t-att-target="fileupload_id"
-              method="post" enctype="multipart/form-data" t-att-action="fileupload_action || '/web/binary/upload'">
-            <input type="hidden" name="csrf_token" t-att-value="window.odoo.csrf_token"/>
-            <input type="hidden" name="callback" t-att-value="fileupload_id"/>
-            <input type="file" class="o_input_file" name="ufile"
-                t-att="{'multiple': multi_upload ? 'multiple' : null, 'accept': widget.accepted_file_extensions || '*'}"/>
-            <t t-out="0"/>
-        </form>
-        <iframe t-att-id="fileupload_id" t-att-name="fileupload_id" style="display: none"/>
-    </div>
-</t>
 
 <t t-name="Throbber">
     <div>
@@ -283,18 +50,5 @@
         <div class="oe_throbber_message" style="color:white"></div>
     </div>
 </t>
-<t t-name="Spinner">
-    <div class="o_spinner"><i class="fa fa-circle-o-notch fa-spin" role="img" aria-label="Loading, please wait..." title="Loading, please wait..."/></div>
-</t>
-<t t-name="M2ODialog">
-    <div>
-        Create <strong t-esc="widget.value"/> as a new <t t-esc="widget.name"/>?
-    </div>
-</t>
-<t t-name="toggle_button">
-    <button type="button" class="o_icon_button" t-att-title="widget.string" t-att-aria-label="widget.string" aria-pressed="false">
-        <i class="fa fa-circle" t-att-title="widget.string"/>
-    </button>
-</t>
 
 </templates>
diff --git a/addons/web/static/src/legacy/xml/fields.xml b/addons/web/static/src/legacy/xml/fields.xml
deleted file mode 100644
index 0a41c2cc81d..00000000000
--- a/addons/web/static/src/legacy/xml/fields.xml
+++ /dev/null
@@ -1,13 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<templates id="template" xml:space="preserve">
-
-    <t t-name="web.LegacyFieldBoolean">
-        <CustomCheckbox disabled="hasReadonlyModifier"
-            value="value" class="'o_field_boolean'" onChange.bind="_onChange"/>
-    </t>
-
-    <t t-name="web.FieldBadge">
-        <span class="badge rounded-pill o_field_badge bg-opacity-50" t-esc="_formatValue(value)"/>
-    </t>
-
-</templates>