From 2db449a2ae8c720361b699bfe3eddf34f2de24a7 Mon Sep 17 00:00:00 2001 From: Goffin Simon Date: Wed, 11 Jan 2017 10:57:17 +0100 Subject: [PATCH] [FIX] hr_attendance: check in with blank pin When writing a blank pin, the user logged can check in his own related employee. opw:703744 --- addons/hr_attendance/models/hr_employee.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_attendance/models/hr_employee.py b/addons/hr_attendance/models/hr_employee.py index a17c2e50b84..a4dac9883ea 100644 --- a/addons/hr_attendance/models/hr_employee.py +++ b/addons/hr_attendance/models/hr_employee.py @@ -74,7 +74,7 @@ class HrEmployee(models.Model): @api.multi def attendance_manual(self, next_action, entered_pin=None): self.ensure_one() - if entered_pin or self.env['res.users'].browse(SUPERUSER_ID).has_group('hr_attendance.group_hr_attendance_use_pin') and (self.user_id and self.user_id.id != self._uid or not self.user_id): + if not (entered_pin is None) or self.env['res.users'].browse(SUPERUSER_ID).has_group('hr_attendance.group_hr_attendance_use_pin') and (self.user_id and self.user_id.id != self._uid or not self.user_id): if entered_pin != self.pin: return {'warning': _('Wrong PIN')} return self.attendance_action(next_action)