From 2d581cd6654d53ede9bc8d4ee72d06d894756562 Mon Sep 17 00:00:00 2001 From: Nicolas Lempereur Date: Tue, 7 Jul 2015 15:11:25 +0200 Subject: [PATCH] [FIX] website_links: don't allow an empty link code An empty code would get a link with an existing controller (/r/). closes #7499 opw-644156 --- addons/website_links/static/src/js/website_links.js | 8 +++++++- .../static/src/js/website_links_code_editor.js | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/addons/website_links/static/src/js/website_links.js b/addons/website_links/static/src/js/website_links.js index dd28ecfb437..7a2b12755a0 100644 --- a/addons/website_links/static/src/js/website_links.js +++ b/addons/website_links/static/src/js/website_links.js @@ -146,6 +146,12 @@ openerp.website.if_dom_contains('div.o_website_links_create_tracked_url', functi var init_code = this.$('#o_website_links_edit_code_form #init_code').val(); var new_code = this.$('#o_website_links_edit_code_form #new_code').val(); + if(new_code === '') { + self.$('.o_website_links_code_error').html("The code cannot be left empty"); + self.$('.o_website_links_code_error').show(); + return; + } + function show_new_code(new_code) { self.$('.o_website_links_code_error').html(''); self.$('.o_website_links_code_error').hide(); @@ -378,4 +384,4 @@ openerp.website.if_dom_contains('div.o_website_links_create_tracked_url', functi }) }); }); -})(); \ No newline at end of file +})(); diff --git a/addons/website_links/static/src/js/website_links_code_editor.js b/addons/website_links/static/src/js/website_links_code_editor.js index 62d4065e20b..3bc1500ead8 100644 --- a/addons/website_links/static/src/js/website_links_code_editor.js +++ b/addons/website_links/static/src/js/website_links_code_editor.js @@ -34,6 +34,12 @@ openerp.website.if_dom_contains('.o_website_links_edit_code', function() { var init_code = $('#edit-code-form #init_code').val(); var new_code = $('#edit-code-form #new_code').val(); + if(new_code === '') { + self.$('.o_website_links_code_error').html("The code cannot be left empty"); + self.$('.o_website_links_code_error').show(); + return; + } + function show_new_code(new_code) { $('.o_website_links_code_error').html(''); $('.o_website_links_code_error').hide(); @@ -80,4 +86,4 @@ openerp.website.if_dom_contains('.o_website_links_edit_code', function() { }); }); }); -})(); \ No newline at end of file +})();