From 2cc8af737ab02ab10b268787092739c1908fe5fe Mon Sep 17 00:00:00 2001 From: Damien Bouvy Date: Mon, 31 Aug 2020 08:05:09 +0000 Subject: [PATCH] [FIX] sale,payment: remove useless comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DBO won't be here anymore 👋 This is my last commit, I had to find something harmless. Task-NaNNaNNaNNaNNaNNaN closes odoo/odoo#56789 X-original-commit: fc92728fb2aa306bf0e01a7f9ae1cfa3c1df0e10 Signed-off-by: Yannick Tivisse (yti) --- addons/payment/models/payment_acquirer.py | 1 - addons/sale/controllers/portal.py | 2 +- addons/sale/tests/test_sale_order.py | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/addons/payment/models/payment_acquirer.py b/addons/payment/models/payment_acquirer.py index 840426f0a9e..5df9742a052 100644 --- a/addons/payment/models/payment_acquirer.py +++ b/addons/payment/models/payment_acquirer.py @@ -1134,7 +1134,6 @@ class PaymentToken(models.Model): """ @TBE: stolen shamelessly from there https://www.paypal.com/us/selfhelp/article/why-is-there-a-$1.95-charge-on-my-card-statement-faq554 Most of them are ~1.50€s - TODO: See this with @AL & @DBO """ VALIDATION_AMOUNTS = { 'CAD': 2.45, diff --git a/addons/sale/controllers/portal.py b/addons/sale/controllers/portal.py index c9a7f7a9acf..969de29735d 100644 --- a/addons/sale/controllers/portal.py +++ b/addons/sale/controllers/portal.py @@ -263,7 +263,7 @@ class CustomerPortal(CustomerPortal): return request.redirect(order_sudo.get_portal_url(query_string=query_string)) - # note dbo: website_sale code + # note: website_sale code @http.route(['/my/orders//transaction/'], type='json', auth="public", website=True) def payment_transaction_token(self, acquirer_id, order_id, save_token=False, access_token=None, **kwargs): """ Json method that creates a payment.transaction, used to create a diff --git a/addons/sale/tests/test_sale_order.py b/addons/sale/tests/test_sale_order.py index 5f8abd34470..1280a3a5f07 100644 --- a/addons/sale/tests/test_sale_order.py +++ b/addons/sale/tests/test_sale_order.py @@ -64,7 +64,7 @@ class TestSaleOrder(TestSaleCommon): """ Test the sales order flow (invoicing and quantity updates) - Invoice repeatedly while varrying delivered quantities and check that invoice are always what we expect """ - # DBO TODO: validate invoice and register payments + # TODO?: validate invoice and register payments self.sale_order.order_line.read(['name', 'price_unit', 'product_uom_qty', 'price_total']) self.assertEqual(self.sale_order.amount_total, 1240.0, 'Sale: total amount is wrong')