From 2cbcf266f707af90a9b3630d7b082b98ceebe70a Mon Sep 17 00:00:00 2001 From: "Julien Carion (juca)" Date: Thu, 21 Sep 2023 13:30:00 +0000 Subject: [PATCH] [FIX] web: popovers do close correctly in kanban MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit fixes a bug where popovers could stack up in kanban if one kept opening them. By changing the event to close popovers from a mousedown event to a pointerdown event, it is no longer stopped by the draggable hook and executes correctly. closes odoo/odoo#136890 X-original-commit: 76665eb400168a6fd6e2b5f5fe099c8c4e9c8a5e Signed-off-by: Michaël Mattiello (mcm) Signed-off-by: Julien Carion (juca) --- addons/web/static/src/core/popover/popover_controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/core/popover/popover_controller.js b/addons/web/static/src/core/popover/popover_controller.js index 2c835e7d098..32eeb20218d 100644 --- a/addons/web/static/src/core/popover/popover_controller.js +++ b/addons/web/static/src/core/popover/popover_controller.js @@ -24,7 +24,7 @@ export class PopoverController extends Component { setup() { if (this.props.target.isConnected) { this.popoverRef = useChildRef(); - useExternalListener(window, "mousedown", this.onClickAway, { capture: true }); + useExternalListener(window, "pointerdown", this.onClickAway, { capture: true }); useHotkey("escape", () => this.props.close()); const targetObserver = new MutationObserver(this.onTargetMutate.bind(this)); targetObserver.observe(this.props.target.parentElement, { childList: true });