From 2bcccbfb910609f6cf54d607d198aae4c5b28b86 Mon Sep 17 00:00:00 2001 From: "Lopes Marc (loma)" Date: Fri, 5 Jan 2024 10:33:40 +0000 Subject: [PATCH] [FIX] survey: fix global css print rules PURPOSE ======= The survey addon assets contain some global rules for print mode, that are present in the global backend stack. In Odoo 15.2, we put these rules in `survey_templates_results.scss`. Then, in later versions of Odoo we updated it wih more 'print mode' global rules. As these rules are specific to the survey addon, we don't want them to affect the (whole) Odoo backend. HOW TO FIX ========== It seems rules defined in `survey_templates_results.scss` are not used in survey backend views, but specific to frontend views. `survey_templates_results.scss` is also part of the `survey.survey_assets` bundle. This bundle is loaded only for the following frontend views: - Survey: main page (take survey) - Survey: custom 403 page - Survey: void content - Survey: login required - Survey: expired - Survey: Access Code page - Survey: print page - Survey: result statistics page Among them, views that are not intended to be printed are not negatively impacted by the css rules for print mode. A solution would therefore be to remove `survey_templates_results.scss` from the backend stack. see 0364161 see #135683 see #146812 task-3666858 closes odoo/odoo#155126 X-original-commit: aba4b503b60b42c91191436491205a0c7575ecbd Signed-off-by: Thibault Delavallee (tde) --- addons/survey/__manifest__.py | 1 - 1 file changed, 1 deletion(-) diff --git a/addons/survey/__manifest__.py b/addons/survey/__manifest__.py index 18077d28f1a..ad9302e431c 100644 --- a/addons/survey/__manifest__.py +++ b/addons/survey/__manifest__.py @@ -96,7 +96,6 @@ sent mails with personal token for the invitation of the survey. 'survey/static/src/views/**/*.xml', 'survey/static/src/scss/survey_survey_views.scss', 'survey/static/src/scss/survey_question_views.scss', - 'survey/static/src/scss/survey_templates_results.scss', 'survey/static/src/js/tours/survey_tour.js', ], "web.assets_web_dark": [