From 2b9717400aeb9afbdb73d6b57f46a59992606abe Mon Sep 17 00:00:00 2001
From: "Simon Genin (ges)" <ges@odoo.com>
Date: Mon, 8 Jan 2024 17:02:47 +0100
Subject: [PATCH] [FIX] web: Kanban grouped on field with readonly expression

As a reminder, the readonly expression in grouped kanban can enable or
disable the drag and drop feature. If the view is not reaonly but the
field in the arch on which the view is grouped is readonly, the drag
would be disabled.

Before this commit, there was a regression introduced in commit
ba1a5509fa49fd846739252d16083dd8cb334b53 that made the kanban record not
able to evaluate the readonly expression in the fields.

This commit fixes the issue by making the kanban record evaluate the
provided expression. It does not however correctly evaluate the
expression if it contains another field as the drag and drop feature
can be enabled at a view level, not at a per record level. It would then
resolve to not readonly.

Task id 3611116

closes odoo/odoo#148533

Signed-off-by: Francois Georis (fge) <fge@odoo.com>
---
 .../src/views/kanban/kanban_renderer.js       | 18 +++--
 .../tests/views/kanban/kanban_view_tests.js   | 70 +++++++++++++++++++
 2 files changed, 82 insertions(+), 6 deletions(-)

diff --git a/addons/web/static/src/views/kanban/kanban_renderer.js b/addons/web/static/src/views/kanban/kanban_renderer.js
index 60fd55151ff..67dc8ccf344 100644
--- a/addons/web/static/src/views/kanban/kanban_renderer.js
+++ b/addons/web/static/src/views/kanban/kanban_renderer.js
@@ -16,6 +16,7 @@ import { KanbanRecord } from "./kanban_record";
 import { KanbanRecordQuickCreate } from "./kanban_record_quick_create";
 
 import { Component, onPatched, onWillDestroy, onWillPatch, useRef, useState } from "@odoo/owl";
+import { evaluateExpr } from "@web/core/py_js/py";
 
 const DRAGGABLE_GROUP_TYPES = ["many2one"];
 const MOVABLE_RECORD_TYPES = ["char", "boolean", "integer", "selection", "many2one"];
@@ -224,12 +225,17 @@ export class KanbanRenderer extends Component {
             (fieldNode) => fieldNode.name === groupByField.name
         );
         let isReadonly = this.props.list.fields[groupByField.name].readonly;
-        if (
-            !isReadonly &&
-            fieldNodes.length &&
-            fieldNodes.some((fieldNode) => "readonly" in fieldNode)
-        ) {
-            isReadonly = fieldNodes.every((fieldNode) => fieldNode.readonly === "True");
+        if (!isReadonly && fieldNodes.length) {
+            isReadonly = fieldNodes.every((fieldNode) => {
+                if (!fieldNode.readonly) {
+                    return false;
+                }
+                try {
+                    return evaluateExpr(fieldNode.readonly, this.props.list.evalContext);
+                } catch {
+                    return false;
+                }
+            });
         }
         return !isReadonly && this.isMovableField(groupByField);
     }
diff --git a/addons/web/static/tests/views/kanban/kanban_view_tests.js b/addons/web/static/tests/views/kanban/kanban_view_tests.js
index 66734632841..70e219bf5ed 100644
--- a/addons/web/static/tests/views/kanban/kanban_view_tests.js
+++ b/addons/web/static/tests/views/kanban/kanban_view_tests.js
@@ -14224,4 +14224,74 @@ QUnit.module("Views", (hooks) => {
         assert.containsOnce(target, ".o_kanban_record:not(.o_kanban_ghost)");
         assert.containsNone(target, ".my_kanban_compiler");
     });
+
+    QUnit.test(
+        "Kanban grouped on field with readonly expression depending on context",
+        async (assert) => {
+            await makeView({
+                type: "kanban",
+                resModel: "partner",
+                serverData,
+                arch: `<kanban>
+                <templates>
+                    <t t-name="kanban-box">
+                        <div>
+                            <field name="product_id" readonly="context.get('abc')" />
+                        </div>
+                    </t>
+                </templates>
+            </kanban>`,
+                groupBy: ["product_id"],
+                context: { abc: true },
+            });
+
+            assert.containsN(target, ".o_kanban_group:first-child .o_kanban_record", 2);
+            assert.containsN(target, ".o_kanban_group:nth-child(2) .o_kanban_record", 2);
+
+            await dragAndDrop(
+                ".o_kanban_group:first-child .o_kanban_record",
+                ".o_kanban_group:nth-child(2)"
+            );
+
+            assert.containsN(target, ".o_kanban_group:first-child .o_kanban_record", 2);
+            assert.containsN(target, ".o_kanban_group:nth-child(2) .o_kanban_record", 2);
+        }
+    );
+
+    QUnit.test(
+        "Kanban grouped on field with readonly expression depending on fields",
+        async (assert) => {
+            // Fields are not available in the current context as the drag and drop must be enabled globally
+            // for the view, it's not a per record thing.
+            // So if the readonly expression contains fields, it will resolve to readonly === false and
+            // the drag and drop will be enabled.
+            await makeView({
+                type: "kanban",
+                resModel: "partner",
+                serverData,
+                arch: `<kanban>
+                <templates>
+                    <t t-name="kanban-box">
+                        <div>
+                            <field name="foo" />
+                            <field name="product_id" readonly="foo == 'yop'" />
+                        </div>
+                    </t>
+                </templates>
+            </kanban>`,
+                groupBy: ["product_id"],
+            });
+
+            assert.containsN(target, ".o_kanban_group:first-child .o_kanban_record", 2);
+            assert.containsN(target, ".o_kanban_group:nth-child(2) .o_kanban_record", 2);
+
+            await dragAndDrop(
+                ".o_kanban_group:first-child .o_kanban_record",
+                ".o_kanban_group:nth-child(2)"
+            );
+
+            assert.containsN(target, ".o_kanban_group:first-child .o_kanban_record", 1);
+            assert.containsN(target, ".o_kanban_group:nth-child(2) .o_kanban_record", 3);
+        }
+    );
 });