From 2b7d899124fdea32c05d833ca49478b1b4f99a22 Mon Sep 17 00:00:00 2001
From: Hiral Bhavsar <hbh@odoo.com>
Date: Thu, 16 May 2019 13:51:37 +0000
Subject: [PATCH] [IMP] account(_*): clean the controlpanel actions

* check_printing, voucher

For the model 'account.account',
- Replace the action menu 'Journal Items' by the stat button.
- Hide menu 'Journal Items for Tax Audit' from actions menu.

For the model 'account.invoice',
- Set action menu 'Share' only for the form view.
- Rename the action menu 'Confirm Draft Invoices' by 'Validate'.
- Rename 'Register Payment' by 'Register payment'.
- Rename 'Send' by 'Send & print'.

For the model 'account.move',
- Remove the menu 'Journal Items'.
- Rename 'Reverse Moves' by 'Reverse' and set it only for the list
  view.
- Rename 'Post Journal Entries' by 'Post entries' and set it only for
  the list view.

For the model 'account.move.line',r ename 'Reconcile Entries' by
'Reconcile' and 'Unreconcile Entries' by 'Unreconcile' and set it only
for the list view.

For the model 'account.payment',
- Rename 'Send Receipt By Email' by 'Send receipt by email' and set it
  for both form and list views.
- Rename 'Post Payments' by 'Confirm' and set it for the list view only
- Rename 'Print Checks' by 'Print checks' and set it for the list view
  only.

For the model 'account.journal', remove the menus 'Unpaid Invoices',
'Bank statements' and 'Voucher Entries'.

Linked to task 1984526
Related to PR #33720
---
 addons/account/data/account_data.xml              |  1 +
 addons/account/data/payment_receipt_data.xml      |  3 +--
 addons/account/views/account_move_views.xml       | 15 +++------------
 addons/account/views/account_payment_view.xml     |  2 ++
 addons/account/views/account_view.xml             | 12 ++++--------
 .../account/wizard/account_invoice_send_views.xml |  2 +-
 .../account/wizard/account_move_reversal_view.xml |  3 ++-
 .../account/wizard/account_unreconcile_view.xml   |  3 ++-
 .../account/wizard/account_validate_move_view.xml |  3 ++-
 .../data/account_check_printing_data.xml          |  1 +
 10 files changed, 19 insertions(+), 26 deletions(-)

diff --git a/addons/account/data/account_data.xml b/addons/account/data/account_data.xml
index ed3478c21ab..a2ee9e8dde4 100644
--- a/addons/account/data/account_data.xml
+++ b/addons/account/data/account_data.xml
@@ -179,6 +179,7 @@
             <field name="name">Share</field>
             <field name="model_id" ref="account.model_account_move"/>
             <field name="binding_model_id" ref="account.model_account_move"/>
+            <field name="binding_view_types">form</field>
             <field name="state">code</field>
             <field name="code">action = records.action_share()</field>
         </record>
diff --git a/addons/account/data/payment_receipt_data.xml b/addons/account/data/payment_receipt_data.xml
index 4895232ad10..7a72e510993 100644
--- a/addons/account/data/payment_receipt_data.xml
+++ b/addons/account/data/payment_receipt_data.xml
@@ -32,12 +32,11 @@
             <field name="user_signature" eval="False"/>
         </record>
 
-        <act_window name="Send Receipt By Email"
+        <act_window name="Send receipt by email"
             res_model="mail.compose.message"
             binding_model="account.payment"
             view_mode="form"
             target="new"
-            binding_views="form"
             id="account_send_payment_receipt_by_email_action"
             context="{
                 'default_model': 'account.payment',
diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index e083c8136a5..0270f4afe14 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -901,8 +901,7 @@
             id="action_move_line_select"
             name="Journal Items"
             context="{'search_default_account_id': [active_id]}"
-            res_model="account.move.line"
-            binding_model="account.account" binding_views="form"/>
+            res_model="account.move.line"/>
 
         <act_window
             id="action_move_line_select_by_partner"
@@ -911,10 +910,11 @@
             res_model="account.move.line"/>
 
         <record id="action_view_account_move_line_reconcile" model="ir.actions.client">
-             <field name="name">Reconcile Entries</field>
+             <field name="name">Reconcile</field>
              <field name="tag">manual_reconciliation_view</field>
              <field name="binding_model_id" ref="account.model_account_move_line"/>
              <field name="binding_type">action</field>
+             <field name="binding_view_types">list</field>
          </record>
 
         <record id="action_manual_reconcile" model="ir.actions.client">
@@ -928,7 +928,6 @@
             name="Journal Items for Tax Audit"
             context="{'search_default_account_id': [active_id]}"
             res_model="account.move.line"
-            binding_model="account.account" binding_views="form"
             view_id="account.view_move_line_tax_audit_tree"/>
 
         <record id="action_account_moves_all_a" model="ir.actions.act_window">
@@ -1195,14 +1194,6 @@
             <field name="search_view_id" ref="view_account_move_filter"/>
         </record>
 
-        <act_window
-            id="act_account_move_to_account_move_line_open"
-            name="Journal Items"
-            context="{'search_default_move_id': active_id, 'default_move_id': active_id}"
-            res_model="account.move.line"
-            binding_model="account.move" binding_views="form"
-            view_mode="tree"/>
-
         <!-- MENUS -->
 
         <menuitem
diff --git a/addons/account/views/account_payment_view.xml b/addons/account/views/account_payment_view.xml
index a6718d74840..2fe80e22cca 100644
--- a/addons/account/views/account_payment_view.xml
+++ b/addons/account/views/account_payment_view.xml
@@ -300,6 +300,7 @@
             <field name="name">Register Payment</field>
             <field name="model_id" ref="account.model_account_payment"/>
             <field name="binding_model_id" ref="account.model_account_move"/>
+            <field name="binding_view_types">list</field>
             <field name="state">code</field>
             <field name="code">
                 action = model.action_register_payment()
@@ -313,6 +314,7 @@
             <field name="state">code</field>
             <field name="model_id" ref="account.model_account_payment"/>
             <field name="binding_model_id" ref="account.model_account_payment"/>
+            <field name="binding_view_types">list</field>
             <field name="code">
                 records.post()
             </field>
diff --git a/addons/account/views/account_view.xml b/addons/account/views/account_view.xml
index da8f55092b6..938d5f2174f 100644
--- a/addons/account/views/account_view.xml
+++ b/addons/account/views/account_view.xml
@@ -7,6 +7,10 @@
             <field name="arch" type="xml">
                 <form string="Account">
                    <sheet>
+                        <div class="oe_button_box" name="button_box">
+                            <button class="oe_stat_button" name="account.action_move_line_select"
+                                string="Journal Items" type="action" icon="fa-bars"/>
+                        </div>
                        <group>
                            <group>
                              <field name="code" placeholder="code"/>
@@ -367,14 +371,6 @@ action = model.setting_init_bank_account_action()
         </record>
         <menuitem action="action_account_journal_group_list" id="menu_action_account_journal_group_list" parent="account_account_menu"/>
 
-        <act_window
-           id="act_account_journal_2_account_bank_statement"
-           name="Bank statements"
-           context="{'search_default_journal_id': active_id, 'default_journal_id': active_id}"
-           res_model="account.bank.statement"
-           binding_model="account.journal"
-           binding_views="form"/>
-
         <!-- Tags -->
         <record id="account_tag_view_form" model="ir.ui.view">
             <field name="name">Tags</field>
diff --git a/addons/account/wizard/account_invoice_send_views.xml b/addons/account/wizard/account_invoice_send_views.xml
index 8c9ce09b02a..3ed9afdabea 100644
--- a/addons/account/wizard/account_invoice_send_views.xml
+++ b/addons/account/wizard/account_invoice_send_views.xml
@@ -76,7 +76,7 @@
         </record>
 
        <act_window
-            name="Send"
+            name="Send &amp; print"
             id="invoice_send"
             res_model="account.invoice.send"
             binding_model="account.move"
diff --git a/addons/account/wizard/account_move_reversal_view.xml b/addons/account/wizard/account_move_reversal_view.xml
index 229c8391717..9f92f5904a7 100644
--- a/addons/account/wizard/account_move_reversal_view.xml
+++ b/addons/account/wizard/account_move_reversal_view.xml
@@ -50,12 +50,13 @@
         </record>
 
         <record id="action_view_account_move_reversal" model="ir.actions.act_window">
-            <field name="name">Reverse Moves</field>
+            <field name="name">Reverse</field>
             <field name="res_model">account.move.reversal</field>
             <field name="view_mode">tree,form</field>
             <field name="view_id" ref="view_account_move_reversal"/>
             <field name="target">new</field>
             <field name="binding_model_id" ref="account.model_account_move" />
+            <field name="binding_view_types">list</field>
         </record>
     </data>
 </odoo>
diff --git a/addons/account/wizard/account_unreconcile_view.xml b/addons/account/wizard/account_unreconcile_view.xml
index 965adeb8a98..5a6a1ae9b9d 100644
--- a/addons/account/wizard/account_unreconcile_view.xml
+++ b/addons/account/wizard/account_unreconcile_view.xml
@@ -18,12 +18,13 @@
         </record>
 
         <record id="action_account_unreconcile" model="ir.actions.act_window">
-            <field name="name">Unreconcile Entries</field>
+            <field name="name">Unreconcile</field>
             <field name="res_model">account.unreconcile</field>
             <field name="view_mode">form</field>
             <field name="view_id" ref="account_unreconcile_view"/>
             <field name="target">new</field>
             <field name="binding_model_id" ref="account.model_account_move_line" />
+            <field name="binding_view_types">list</field>
         </record>
 
     </data>
diff --git a/addons/account/wizard/account_validate_move_view.xml b/addons/account/wizard/account_validate_move_view.xml
index 0fbf75013f9..062a2e5838e 100644
--- a/addons/account/wizard/account_validate_move_view.xml
+++ b/addons/account/wizard/account_validate_move_view.xml
@@ -18,7 +18,7 @@
         </record>
 
         <record id="action_validate_account_move" model="ir.actions.act_window">
-            <field name="name">Post Journal Entries</field>
+            <field name="name">Post entries</field>
             <field name="type">ir.actions.act_window</field>
             <field name="res_model">validate.account.move</field>
             <field name="view_mode">form</field>
@@ -27,6 +27,7 @@
             <field name="target">new</field>
             <field name="help">This wizard will validate all journal entries selected. Once journal entries are validated, you can not update them anymore.</field>
             <field name="binding_model_id" ref="account.model_account_move" />
+            <field name="binding_view_types">list</field>
         </record>
 
     </data>
diff --git a/addons/account_check_printing/data/account_check_printing_data.xml b/addons/account_check_printing/data/account_check_printing_data.xml
index d4c3704f4d9..9f3fd4ded03 100644
--- a/addons/account_check_printing/data/account_check_printing_data.xml
+++ b/addons/account_check_printing/data/account_check_printing_data.xml
@@ -15,6 +15,7 @@
             <field name="name">Print Checks</field>
             <field name="model_id" ref="account.model_account_payment"/>
             <field name="binding_model_id" ref="account.model_account_payment" />
+            <field name="binding_view_types">list</field>
             <field name="state">code</field>
             <field name="code">
 if records: