From 2b4e172c6f686c0c577d4a1b1d99b65b721ed900 Mon Sep 17 00:00:00 2001 From: ryv-odoo Date: Tue, 29 Oct 2019 09:16:33 +0000 Subject: [PATCH] [IMP] mail: improve displayed error when template rendering crashes Currently when rendering a template crashes, error is not easy to understand as it is hidden in a generic message. Purpose of this commit is to improve this message to indicate why the template fails to build (only the first error encountered). Task 2085912 PR #38708 --- addons/mail/models/mail_template.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/mail/models/mail_template.py b/addons/mail/models/mail_template.py index ff161dc07a1..871a3302d65 100644 --- a/addons/mail/models/mail_template.py +++ b/addons/mail/models/mail_template.py @@ -236,9 +236,9 @@ class MailTemplate(models.Model): variables['object'] = record try: render_result = template.render(variables) - except Exception: - _logger.info("Failed to render template %r using values %r" % (template, variables), exc_info=True) - raise UserError(_("Failed to render template %r using values %r")% (template, variables)) + except Exception as e: + _logger.info("Failed to render template : %s" % e, exc_info=True) + raise UserError(_("Failed to render template : %s") % e) if render_result == u"False": render_result = u"" results[res_id] = render_result