From 2a1aed788d22e123ec7f6af1cd163598ebdc050f Mon Sep 17 00:00:00 2001
From: Pratik Awasthi <praw@odoo.com>
Date: Wed, 12 Apr 2023 00:04:54 +0000
Subject: [PATCH] [IMP] sale_timesheet: improve search view of timesheet

improve the UX for search view:
- remove the group by on 'Sale Order'
- remove the quick search on 'sales order item'
- add quick search for SO and SOL instead of 'Sale Order'

task-3265251

closes odoo/odoo#118801

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
---
 addons/sale_timesheet/views/hr_timesheet_views.xml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/addons/sale_timesheet/views/hr_timesheet_views.xml b/addons/sale_timesheet/views/hr_timesheet_views.xml
index 3cef8f3d2b1..d4bab374dc9 100644
--- a/addons/sale_timesheet/views/hr_timesheet_views.xml
+++ b/addons/sale_timesheet/views/hr_timesheet_views.xml
@@ -7,8 +7,7 @@
             <field name="inherit_id" ref="hr_timesheet.hr_timesheet_line_search_base"/>
             <field name="arch" type="xml">
                 <xpath expr="//field[@name='task_id']" position="after">
-                    <field name="order_id" string="Sales Order" groups="sales_team.group_sale_salesman"/>
-                    <field name="so_line" groups="sales_team.group_sale_salesman"/>
+                    <field name="order_id" string="Sales Order" filter_domain="['|', ('so_line', 'ilike', self), ('order_id', 'ilike', self)]"/>
                 </xpath>
                 <xpath expr="//filter[@name='month']" position="before">
                     <filter name="billable_fixed" string="Billed at a Fixed Price" domain="[('timesheet_invoice_type', '=', 'billable_fixed')]"
@@ -24,8 +23,6 @@
                     <separator/>
                 </xpath>
                 <xpath expr="//filter[@name='groupby_employee']" position="after">
-                    <filter string="Sales Order" name="groupby_sale_order" domain="[]" context="{'group_by': 'order_id'}"
-                        groups="sales_team.group_sale_salesman"/>
                     <filter string="Sales Order Item" name="groupby_sale_order_item" domain="[]" context="{'group_by': 'so_line'}"
                         groups="sales_team.group_sale_salesman"/>
                     <filter string="Invoice" name="groupby_invoice" domain="[]" context="{'group_by': 'timesheet_invoice_id'}"