From 29de1ef72b8c4cb81019dfac0192666df304a35e Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@odoo.com>
Date: Thu, 20 May 2021 06:57:08 +0000
Subject: [PATCH] [IMP] web: reduce warning spam, only show rpc error warning
 in debug

Trigger a *lot* of spam while running tests

It's not great that this is now disabled:

* some cases are mistakes in the test e.g. RPC not properly setup,
  they should really be fixed
* others are literally testing error responses, the logging should be
  suppressed instead

Ideal scenario would probably be to upgrade this to `error` and have
an API of some sort to suppress it on a per-test basis (not unlike
`@mute_logger` on the Python side).
---
 addons/web/static/tests/legacy/helpers/mock_server.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/addons/web/static/tests/legacy/helpers/mock_server.js b/addons/web/static/tests/legacy/helpers/mock_server.js
index 1a6f2d80b4c..0cea8e11fbf 100644
--- a/addons/web/static/tests/legacy/helpers/mock_server.js
+++ b/addons/web/static/tests/legacy/helpers/mock_server.js
@@ -166,7 +166,15 @@ var MockServer = Class.extend({
             var message = result && result.message;
             var event = result && result.event;
             var errorString = JSON.stringify(message || false);
-            console.warn('%c[rpc] response (error) ' + route, 'color: orange; font-weight: bold;', JSON.parse(errorString));
+            if (debug) {
+                console.warn(
+                    '%c[rpc] response (error) %s%s, during test %s',
+                    'color: orange; font-weight: bold;',
+                    route,
+                    message != null && ` -> ${errorString}`,
+                    JSON.stringify(QUnit.config.current.testName)
+                );
+            }
             return Promise.reject({message: errorString, event: event || $.Event()});
         });