From 289f47da14d986195fd2dd8a5194ddb7a8ec0070 Mon Sep 17 00:00:00 2001 From: shreya thakrar Date: Tue, 10 Dec 2019 09:27:07 +0000 Subject: [PATCH] [FIX] web: remove min-height of form sheet within a modal We added min-height for `o_form_sheet` in form view with a commit[1] restoring the views design (after views refactoring). However, the min-height isn't very useful when form view is opened witin a modal (FormViewDialog). Especially, when the form view is having only few fields, the `o_form_sheet` container occupies unnecessary height and looks a bit ugly. This commit fixes the issues by setting the min-height to `0` for `o_form_sheet` container in such cases. [1] - https://github.com/odoo/odoo/commit/250e716c3a12#diff-01e46b3171a7282967199e5d45fca0e6R15 TaskID: 2150471 PR #41619 closes odoo/odoo#43865 X-original-commit: 144d720bdc54ce762b84b1a78aa7e517ec1c3dd2 Signed-off-by: Quentin Smetz (qsm) --- addons/web/static/src/scss/form_view_extra.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/addons/web/static/src/scss/form_view_extra.scss b/addons/web/static/src/scss/form_view_extra.scss index b3157b0ace6..163d1212299 100644 --- a/addons/web/static/src/scss/form_view_extra.scss +++ b/addons/web/static/src/scss/form_view_extra.scss @@ -106,6 +106,9 @@ .o_form_sheet_bg, .o_form_sheet { border: none; } + .o_form_sheet_bg > .o_form_sheet { + min-height: 0; + } } }