From 284daaeacf0351b286eec893bbbae6c767ea6d94 Mon Sep 17 00:00:00 2001
From: William Braeckman <wbr@odoo.com>
Date: Thu, 8 Jul 2021 09:00:10 +0000
Subject: [PATCH] [IMP] hr_recruitment: improve meeting smart button

Change the text of the meeting smart button to be similar to the one
found in appraisals, it now also shows the date.

Closes odoo/odoo#72649

Task ID: 2578165

Related: odoo/upgrade#2642
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 .../hr_recruitment/models/hr_recruitment.py   | 40 +++++++++++++------
 .../views/hr_recruitment_views.xml            |  7 +++-
 2 files changed, 32 insertions(+), 15 deletions(-)

diff --git a/addons/hr_recruitment/models/hr_recruitment.py b/addons/hr_recruitment/models/hr_recruitment.py
index 10635b02e9f..bdd0e9afd4a 100644
--- a/addons/hr_recruitment/models/hr_recruitment.py
+++ b/addons/hr_recruitment/models/hr_recruitment.py
@@ -166,8 +166,10 @@ class Applicant(models.Model):
     legend_done = fields.Char(related='stage_id.legend_done', string='Kanban Valid')
     legend_normal = fields.Char(related='stage_id.legend_normal', string='Kanban Ongoing')
     application_count = fields.Integer(compute='_compute_application_count', help='Applications with the same email')
-    meeting_count = fields.Integer(compute='_compute_meeting_count', help='Meeting Count')
     refuse_reason_id = fields.Many2one('hr.applicant.refuse.reason', string='Refuse Reason', tracking=True)
+    meeting_ids = fields.One2many('calendar.event', 'applicant_id', 'Meetings')
+    meeting_display_text = fields.Char(compute='_compute_meeting_display')
+    meeting_display_date = fields.Date(compute='_compute_meeting_display')
 
     @api.depends('date_open', 'date_closed')
     def _compute_day(self):
@@ -197,18 +199,30 @@ class Applicant(models.Model):
             applicant.application_count = application_data_mapped.get(applicant.email_from, 1) - 1
         (self - applicants).application_count = False
 
-    def _compute_meeting_count(self):
-        if self.ids:
-            meeting_data = self.env['calendar.event'].sudo().read_group(
-                [('applicant_id', 'in', self.ids)],
-                ['applicant_id'],
-                ['applicant_id']
-            )
-            mapped_data = {m['applicant_id'][0]: m['applicant_id_count'] for m in meeting_data}
-        else:
-            mapped_data = dict()
-        for applicant in self:
-            applicant.meeting_count = mapped_data.get(applicant.id, 0)
+    @api.depends_context('lang')
+    @api.depends('meeting_ids', 'meeting_ids.start')
+    def _compute_meeting_display(self):
+        applicant_with_meetings = self.filtered('meeting_ids')
+        (self - applicant_with_meetings).write({
+            'meeting_display_text': _('No Meeting'),
+            'meeting_display_date': ''
+        })
+        today = fields.Date.today()
+        for applicant in applicant_with_meetings:
+            count = len(applicant.meeting_ids)
+            dates = applicant.meeting_ids.mapped('start')
+            min_date, max_date = min(dates).date(), max(dates).date()
+            if min_date >= today:
+                applicant.meeting_display_date = min_date
+            else:
+                applicant.meeting_display_date = max_date
+            if count == 1:
+                applicant.meeting_display_text = _('1 Meeting')
+            elif applicant.meeting_display_date >= today:
+                applicant.meeting_display_text = _('Next Meeting')
+            else:
+                applicant.meeting_display_text = _('Last Meeting')
+
 
     def _get_attachment_number(self):
         read_group_res = self.env['ir.attachment'].read_group(
diff --git a/addons/hr_recruitment/views/hr_recruitment_views.xml b/addons/hr_recruitment/views/hr_recruitment_views.xml
index b790f8bef96..eb0425e1c88 100644
--- a/addons/hr_recruitment/views/hr_recruitment_views.xml
+++ b/addons/hr_recruitment/views/hr_recruitment_views.xml
@@ -90,8 +90,11 @@
                         <field name="application_count" widget="statinfo" string="Other Applications"/>
                     </button>
                     <button name="action_makeMeeting" class="oe_stat_button" icon="fa-calendar" type="object"
-                         help="Schedule interview with this applicant">
-                        <field name="meeting_count" widget="statinfo" string="Meetings"/>
+                         >
+                         <div class="o_field_widget o_stat_info">
+                             <span class="o_stat_value"><field name="meeting_display_text" /></span>
+                             <span class="o_stat_text"><field name="meeting_display_date" readonly="1"/></span>
+                         </div>
                     </button>
                 </div>
                 <widget name="web_ribbon" title="Refused" bg_color="bg-danger" attrs="{'invisible': [('active', '=', True)]}"/>