From 27ef7d571b8c3dca505cc722f7475d324a69528b Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Thu, 25 Apr 2024 14:11:58 +0200 Subject: [PATCH] [FIX] account,purchase,sale: wrong mail thread method signature Since 3eb96806022705f5b667e149ffa2240760097278, the signature of method `_notify_by_email_prepare_rendering_context` has been changed to provide a default values to `msg_vals` and some overrides were not adapted (or have been added afterwards). No true bug/issue has been found caused by that discrepancy, but for consistency, this commit makes sure those overrides are adapted to provide the same API as the parent method. Fixes #162742 closes odoo/odoo#163418 X-original-commit: d4b31842d6c3e1c5c86d9019a353601914ebf1f7 Signed-off-by: Victor Feyens (vfe) --- addons/account/models/account_move.py | 2 +- addons/purchase/models/purchase_order.py | 2 +- addons/sale/models/sale_order.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/account/models/account_move.py b/addons/account/models/account_move.py index 95ec93b9f8b..ba10bcbe676 100644 --- a/addons/account/models/account_move.py +++ b/addons/account/models/account_move.py @@ -4786,7 +4786,7 @@ class AccountMove(models.Model): 'in_receipt': _('Purchase Receipt Created'), }[self.move_type] - def _notify_by_email_prepare_rendering_context(self, message, msg_vals, model_description=False, + def _notify_by_email_prepare_rendering_context(self, message, msg_vals=False, model_description=False, force_email_company=False, force_email_lang=False): # EXTENDS mail mail.thread render_context = super()._notify_by_email_prepare_rendering_context( diff --git a/addons/purchase/models/purchase_order.py b/addons/purchase/models/purchase_order.py index 4e81661553a..70843b3c6ca 100644 --- a/addons/purchase/models/purchase_order.py +++ b/addons/purchase/models/purchase_order.py @@ -376,7 +376,7 @@ class PurchaseOrder(models.Model): return groups - def _notify_by_email_prepare_rendering_context(self, message, msg_vals, model_description=False, + def _notify_by_email_prepare_rendering_context(self, message, msg_vals=False, model_description=False, force_email_company=False, force_email_lang=False): render_context = super()._notify_by_email_prepare_rendering_context( message, msg_vals, model_description=model_description, diff --git a/addons/sale/models/sale_order.py b/addons/sale/models/sale_order.py index 73a27662d52..ec99b18a3c0 100644 --- a/addons/sale/models/sale_order.py +++ b/addons/sale/models/sale_order.py @@ -1495,7 +1495,7 @@ class SaleOrder(models.Model): return groups - def _notify_by_email_prepare_rendering_context(self, message, msg_vals, model_description=False, + def _notify_by_email_prepare_rendering_context(self, message, msg_vals=False, model_description=False, force_email_company=False, force_email_lang=False): render_context = super()._notify_by_email_prepare_rendering_context( message, msg_vals, model_description=model_description,