From 27b6451dbe762d41bfd78d0b908c13004a761146 Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Thu, 2 Feb 2017 09:59:29 +0100
Subject: [PATCH] [FIX] sales_team, crm: expected closing

On the CRM dashboard, the shortcut 'exp. closing' is the same than the
'overdue' shortcut. However, the number of opportunities in these
categories is computed differently (see method
`retrieve_sales_dashboard`).

We introduce a new filter "Overdue Opportunities" which reflects this
difference.

opw-704173
---
 addons/crm/views/crm_lead_views.xml                       | 3 +++
 addons/sales_team/static/src/js/sales_team_dashboard.js   | 2 ++
 addons/sales_team/static/src/xml/sales_team_dashboard.xml | 2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index 7a89f251420..9239ee61fe9 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -588,6 +588,9 @@
                     <filter string="Overdue Activities" name="overdue"
                             domain="[('date_action', '&lt;', context_today().strftime('%Y-%m-%d'))]"
                             help="Show all opportunities for which the next action date is before today"/>
+                    <filter string="Overdue Opportunities" name="overdue_opp"
+                            domain="[('date_deadline', '&lt;', context_today().strftime('%Y-%m-%d'))]"
+                            help="Show all opportunities with a deadline for which the next action date is before today"/>
                     <separator/>
                     <filter string="Unread Messages" name="message_needaction" domain="[('message_needaction','=',True)]"/>
                     <filter string="Lost" domain="[('active', '=', False)]"/>
diff --git a/addons/sales_team/static/src/js/sales_team_dashboard.js b/addons/sales_team/static/src/js/sales_team_dashboard.js
index 220c3896820..20fda227387 100644
--- a/addons/sales_team/static/src/js/sales_team_dashboard.js
+++ b/addons/sales_team/static/src/js/sales_team_dashboard.js
@@ -65,6 +65,8 @@ var SalesTeamDashboardView = KanbanView.extend({
         } else if (action_name === 'crm.action_your_pipeline') {
             if (action_extra === 'overdue') {
                 additional_context['search_default_overdue'] = 1;
+            } else if (action_extra === 'overdue_opp') {
+                additional_context['search_default_overdue_opp'] = 1;
             }
         } else if (action_name === 'crm.crm_opportunity_report_action_graph') {
             additional_context.search_default_won = 1;
diff --git a/addons/sales_team/static/src/xml/sales_team_dashboard.xml b/addons/sales_team/static/src/xml/sales_team_dashboard.xml
index b29e1583595..8e38765875c 100644
--- a/addons/sales_team/static/src/xml/sales_team_dashboard.xml
+++ b/addons/sales_team/static/src/xml/sales_team_dashboard.xml
@@ -84,7 +84,7 @@
                             </a>
                         </td>
                         <td  t-if="show_demo or (values and values['closing']['overdue'] != 0)" class="o_warning" title="To Opportunities">
-                            <a href="#" class="o_dashboard_action" name="crm.action_your_pipeline" data-extra="overdue">
+                            <a href="#" class="o_dashboard_action" name="crm.action_your_pipeline" data-extra="overdue_opp">
                                 <t t-if="!show_demo">
                                     <t t-esc="values['closing']['overdue']"/> exp. closing
                                 </t>