From 277d71d56cecc71a98a418e1d3636faf23f3b748 Mon Sep 17 00:00:00 2001
From: Kevin Baptiste <kba@odoo.com>
Date: Wed, 14 Sep 2022 06:56:39 +0000
Subject: [PATCH] [IMP] hr_hourly_cost: remove security group

Remove the security group introduced in odoo/odoo#97988 as it's
redundant with the group_hr_user.

task-2929518

closes odoo/odoo#100127

Signed-off-by: Kevin Baptiste <kba@odoo.com>
---
 addons/hr_hourly_cost/__manifest__.py                 |  1 -
 .../security/hr_hourly_cost_security.xml              | 11 -----------
 addons/hr_hourly_cost/views/hr_employee_views.xml     |  4 ++--
 .../hr_timesheet/security/hr_timesheet_security.xml   |  3 +--
 4 files changed, 3 insertions(+), 16 deletions(-)
 delete mode 100644 addons/hr_hourly_cost/security/hr_hourly_cost_security.xml

diff --git a/addons/hr_hourly_cost/__manifest__.py b/addons/hr_hourly_cost/__manifest__.py
index 1c6fda8db0c..f700aaa8c63 100644
--- a/addons/hr_hourly_cost/__manifest__.py
+++ b/addons/hr_hourly_cost/__manifest__.py
@@ -12,7 +12,6 @@ This module assigns an hourly wage to employees to be used by other modules.
     """,
     'depends': ['hr'],
     'data': [
-        'security/hr_hourly_cost_security.xml',
         'views/hr_employee_views.xml',
     ],
     'demo': [
diff --git a/addons/hr_hourly_cost/security/hr_hourly_cost_security.xml b/addons/hr_hourly_cost/security/hr_hourly_cost_security.xml
deleted file mode 100644
index 30318334958..00000000000
--- a/addons/hr_hourly_cost/security/hr_hourly_cost_security.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<odoo>
-    <data noupdate="1">
-        <record id="group_hourly_cost_manager" model="res.groups">
-            <field name="name">Administrator</field>
-            <field name="category_id" ref="base.module_category_services_employee_hourly_cost"/>
-            <field name="implied_ids" eval="[(4, ref('hr.group_hr_user'))]"/>
-            <field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
-        </record>
-    </data>
-</odoo>
diff --git a/addons/hr_hourly_cost/views/hr_employee_views.xml b/addons/hr_hourly_cost/views/hr_employee_views.xml
index c9358efef6e..289bedc6c6e 100644
--- a/addons/hr_hourly_cost/views/hr_employee_views.xml
+++ b/addons/hr_hourly_cost/views/hr_employee_views.xml
@@ -10,8 +10,8 @@
                 <attribute name="string">Application Settings</attribute>
             </group>
             <group name="application_group" position="inside">
-                <label for="hourly_cost" groups="hr_hourly_cost.group_hourly_cost_manager"/>
-                <div name="hourly_cost" groups="hr_hourly_cost.group_hourly_cost_manager">
+                <label for="hourly_cost"/>
+                <div name="hourly_cost">
                     <field name="hourly_cost" class="oe_inline"/> per hour
                     <field name="currency_id" invisible="1"/>
                 </div>
diff --git a/addons/hr_timesheet/security/hr_timesheet_security.xml b/addons/hr_timesheet/security/hr_timesheet_security.xml
index 63135d39cb7..9f105179167 100644
--- a/addons/hr_timesheet/security/hr_timesheet_security.xml
+++ b/addons/hr_timesheet/security/hr_timesheet_security.xml
@@ -22,8 +22,7 @@
         <record id="group_timesheet_manager" model="res.groups">
             <field name="name">Administrator</field>
             <field name="category_id" ref="base.module_category_services_timesheets"/>
-            <field name="implied_ids" eval="[(4, ref('hr_timesheet.group_hr_timesheet_approver')), (4, ref('hr.group_hr_user')),
-                                             (4, ref('hr_hourly_cost.group_hourly_cost_manager'))]"/>
+            <field name="implied_ids" eval="[(4, ref('hr_timesheet.group_hr_timesheet_approver')), (4, ref('hr.group_hr_user'))]"/>
             <field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
         </record>