From 26e5d0f219f73de003bb50dbad73bfebf893e0c8 Mon Sep 17 00:00:00 2001 From: Moens Alexandre Date: Thu, 20 Dec 2018 14:49:09 +0000 Subject: [PATCH] [FIX]performance issue: _compute_sale_order_count This commit simplifies the code and improves the performance of _compute_sale_order_count. execution time from O(n^2) to pretty close to O(n) Project : Performance Issues Task : Geostaff : Success Pack 5 (100h) (opw-1912303) --- addons/sale/models/res_partner.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/addons/sale/models/res_partner.py b/addons/sale/models/res_partner.py index 27a70360d45..0ac1409cd00 100644 --- a/addons/sale/models/res_partner.py +++ b/addons/sale/models/res_partner.py @@ -16,12 +16,9 @@ class ResPartner(models.Model): def _compute_sale_order_count(self): sale_data = self.env['sale.order'].read_group(domain=[('partner_id', 'child_of', self.ids)], fields=['partner_id'], groupby=['partner_id']) - # read to keep the child/parent relation while aggregating the read_group result in the loop - partner_child_ids = self.read(['child_ids']) mapped_data = dict([(m['partner_id'][0], m['partner_id_count']) for m in sale_data]) for partner in self: - # let's obtain the partner id and all its child ids from the read up there - partner_ids = filter(lambda r: r['id'] == partner.id, partner_child_ids)[0] - partner_ids = [partner_ids.get('id')] + partner_ids.get('child_ids') + # let's obtain the partner id and all its child ids + partner_ids = [partner.id] + partner.child_ids.ids # then we can sum for all the partner's child partner.sale_order_count = sum(mapped_data.get(child, 0) for child in partner_ids)