From 26c62cbb4401bffb72ce77fee481ca84b77a8143 Mon Sep 17 00:00:00 2001 From: Romeo Fragomeli Date: Wed, 11 Sep 2019 13:06:37 +0000 Subject: [PATCH] [FIX] web: unable to scroll modal's table in Safari (iOS) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, users wasn't able to scroll vertically when there was "table-responsive" class on modal's table. In fact the scroll was effective on the body and not in the modal content. We can fix this issue by having flex elements but as this is a fix, we preferred to choose a one line fix solution. Steps to reproduce : * open Odoo in Safari (iOS) * open Sale app * create a new quotation * select a customer * select "Search More ..." * try to scroll the table vertically (BUG) Sources : https://stackoverflow.com/questions/41681251/overflow-x-scroll-inside-a-fixed-div-prevents-vertical-scrolling-on-ios#comment84970666_41693350 https://stackoverflow.com/a/57566116 opw-2042095 closes odoo/odoo#36707 closes odoo/odoo#36730 Signed-off-by: Adrien Dieudonné (adr) Signed-off-by: Adrien Dieudonné (adr) --- addons/web/static/src/scss/modal.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/addons/web/static/src/scss/modal.scss b/addons/web/static/src/scss/modal.scss index 52c3100df31..8976dc1e6e7 100644 --- a/addons/web/static/src/scss/modal.scss +++ b/addons/web/static/src/scss/modal.scss @@ -92,6 +92,11 @@ } } +body.modal-open { + // Allow vertical scrolling in modals on iOS + -webkit-overflow-scrolling: touch; +} + // Temporary fix for modals which are not instantiated thanks to the Dialog // JS classes (deprecated case) (see bootstrap_overridden.scss) + Frontend. //