From 2680e97aed1d67fd266e88c80be5992ee1bea5ec Mon Sep 17 00:00:00 2001 From: Florian Charlier Date: Mon, 19 Dec 2022 08:01:56 +0000 Subject: [PATCH] [FIX] onboarding: fix panel's 'no' background MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A traceback was shown when 'None' background was chosen to configure the onboarding panel's background image (css class). Supposing no one built anything with a `o_onboarding_False` class, we also clean the result for a `False` value while we are here. Task-3104723 closes odoo/odoo#108801 X-original-commit: 8a8da706e55073c48aa3cdc21201b4552230de87 Signed-off-by: Warnon Aurélien (awa) --- addons/onboarding/models/onboarding_onboarding.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/onboarding/models/onboarding_onboarding.py b/addons/onboarding/models/onboarding_onboarding.py index c6e786d70f1..9170c32db48 100644 --- a/addons/onboarding/models/onboarding_onboarding.py +++ b/addons/onboarding/models/onboarding_onboarding.py @@ -94,12 +94,12 @@ class Onboarding(models.Model): self.ensure_one() values = { 'bg_image': f'/web/image/onboarding.onboarding/{self.id}/panel_background_image', + 'classes': f'o_onboarding_{self.panel_background_color}' + if self.panel_background_color not in {False, 'none'} else '', 'close_method': self.panel_close_action_name, 'close_model': 'onboarding.onboarding', 'steps': self.step_ids, 'state': self.current_progress_id._get_and_update_onboarding_state(), } - if self.panel_background_color != 'none': - values.update(classes=f'o_onboarding_{self.panel_background_color}') return values