From 26325dc9438da214764cb209fdbfd01d66f65e0a Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Tue, 27 Feb 2018 13:03:00 +0100
Subject: [PATCH] [FIX] sale: sale_count

- Create a user with Inventory access but no Sales access
- Access a product

An AccessError is raised because the user doesn't have access to
`sale.report`.

We hide the stat button if user has no access to Sales, and moreover we
do not compute the sales count in this case.

opw-1815436
---
 addons/sale/models/product_product.py   | 2 ++
 addons/sale/views/sale_views.xml        | 4 ++--
 addons/sale_stock/views/stock_views.xml | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/addons/sale/models/product_product.py b/addons/sale/models/product_product.py
index 4c6223fd269..b26353142b6 100644
--- a/addons/sale/models/product_product.py
+++ b/addons/sale/models/product_product.py
@@ -10,6 +10,8 @@ class ProductProduct(models.Model):
     @api.multi
     def _sales_count(self):
         r = {}
+        if not self.user_has_groups('sales_team.group_sale_salesman'):
+            return r
         domain = [
             ('state', 'in', ['sale', 'done']),
             ('product_id', 'in', self.ids),
diff --git a/addons/sale/views/sale_views.xml b/addons/sale/views/sale_views.xml
index a3b710bef1c..45c3723c6fe 100644
--- a/addons/sale/views/sale_views.xml
+++ b/addons/sale/views/sale_views.xml
@@ -649,7 +649,7 @@
             <field name="arch" type="xml">
                 <button name="toggle_active" position="before">
                     <button class="oe_stat_button" name="%(action_product_sale_list)d"
-                        type="action" icon="fa-usd">
+                        type="action" icon="fa-usd" groups="sales_team.group_sale_salesman">
                         <field string="Sales" name="sales_count" widget="statinfo" />
                     </button>
                 </button>
@@ -671,7 +671,7 @@
             <field name="arch" type="xml">
                 <button name="toggle_active" position="before">
                     <button class="oe_stat_button" name="action_view_sales"
-                        type="object" icon="fa-usd">
+                        type="object" icon="fa-usd" groups="sales_team.group_sale_salesman">
                         <field string="Sales" name="sales_count" widget="statinfo" />
                     </button>
                 </button>
diff --git a/addons/sale_stock/views/stock_views.xml b/addons/sale_stock/views/stock_views.xml
index b70e3ac86cf..b734cd4edfa 100644
--- a/addons/sale_stock/views/stock_views.xml
+++ b/addons/sale_stock/views/stock_views.xml
@@ -39,7 +39,7 @@
             <field name="arch" type="xml">
                 <button name="action_view_orderpoints" position="after">
                     <button class="oe_stat_button" name="action_view_sales"
-                        type="object" icon="fa-usd">
+                        type="object" icon="fa-usd" groups="sales_team.group_sale_salesman">
                         <field string="Sales" name="sales_count" widget="statinfo" />
                     </button>
                 </button>