From 25ef82ca8043b1f214a835157550e33b11c8fb6d Mon Sep 17 00:00:00 2001
From: Nicolas Lempereur <nle@odoo.com>
Date: Thu, 22 Apr 2021 11:45:09 +0000
Subject: [PATCH] [FIX] l10n_latam_invoice_document: header/footer in
 mutli-print

When l10n_latam_invoice_document is installed and the current company
does not have a custom header (in stable, only Chile and Argentina with
their localization installed use custom header), printing multiple
invoice at once, one out of two had no header or footer.

This is because `<div class="header"/>` and `<div class="footer"/>`
should be unique per record being printed, and when a custom header was
not used they were duplicated with the duplicate empty.

As an example, if we had 3 documents:

- record 1 : good header
- record 1 : empty header
- record 1 : body
- record 1 : good footer
- record 1 : empty footer

- record 2 : good header
- record 2 : empty header
- record 2 : body
- record 2 : good footer
- record 2 : empty footer

- record 3 : good header
- record 3 : empty header
- record 3 : body
- record 3 : good footer
- record 3 : empty footer

When we give them to wkhtmltopdf, it would be mismatched:

- headers:
  - record 1 : good header
  - record 1 : empty header
  - record 2 : good header

- bodies:
  - record 1 : body
  - record 2 : body
  - record 3 : body

- footers:
  - record 1 : good footer
  - record 1 : empty footer
  - record 2 : good footer

so record 2 will have empty header/footer, and record 3 will get those
of record 2.

opw-2507137

note: the master forward-port also remove t-if that are no longer
necessary since the same t-if is on an ancestor tag now.

closes odoo/odoo#69718

X-original-commit: 90bdb5c7b7aa6a9b98e9acb1774d449ae65a3918
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
---
 .../views/report_templates.xml                | 32 +++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/addons/l10n_latam_invoice_document/views/report_templates.xml b/addons/l10n_latam_invoice_document/views/report_templates.xml
index 41ee61ba13a..ebc73d578df 100644
--- a/addons/l10n_latam_invoice_document/views/report_templates.xml
+++ b/addons/l10n_latam_invoice_document/views/report_templates.xml
@@ -7,8 +7,8 @@
             <attribute name="t-if">not custom_header</attribute>
         </div>
         <div t-attf-class="header o_company_#{company.id}_layout" position="after">
-            <div t-attf-class="header o_company_#{company.id}_layout">
-                <t t-if="custom_header" t-call="#{custom_header}"/>
+            <div t-attf-class="header o_company_#{company.id}_layout" t-if="custom_header">
+                <t t-call="#{custom_header}"/>
             </div>
         </div>
 
@@ -18,8 +18,8 @@
         </div>
 
         <div t-attf-class="footer o_standard_footer o_company_#{company.id}_layout" position="after">
-            <div t-attf-class="footer o_standard_footer o_company_#{company.id}_layout">
-                <t t-if="custom_footer" t-out="custom_footer"/>
+            <div t-attf-class="footer o_standard_footer o_company_#{company.id}_layout" t-if="custom_footer">
+                <t t-out="custom_footer"/>
             </div>
         </div>
     </template>
@@ -30,9 +30,9 @@
             <attribute name="t-if">not custom_header</attribute>
         </div>
         <div t-attf-class="header o_company_#{company.id}_layout" position="after">
-            <div t-attf-class="header o_company_#{company.id}_layout">
+            <div t-attf-class="header o_company_#{company.id}_layout" t-if="custom_header">
                 <div class="o_clean_header">
-                    <t t-if="custom_header" t-call="#{custom_header}"/>
+                    <t t-call="#{custom_header}"/>
                 </div>
             </div>
         </div>
@@ -42,8 +42,8 @@
             <attribute name="t-if">not custom_footer</attribute>
         </div>
         <div t-attf-class="footer o_clean_footer o_company_#{company.id}_layout" position="after">
-            <div t-attf-class="footer o_clean_footer o_company_#{company.id}_layout">
-                <t t-if="custom_footer" t-out="custom_footer"/>
+            <div t-attf-class="footer o_clean_footer o_company_#{company.id}_layout" t-if="custom_footer">
+                <t t-out="custom_footer"/>
             </div>
         </div>
     </template>
@@ -54,9 +54,9 @@
             <attribute name="t-if">not custom_header</attribute>
         </div>
         <div t-attf-class="header o_company_#{company.id}_layout" position="after">
-            <div t-attf-class="header o_company_#{company.id}_layout" >
+            <div t-attf-class="header o_company_#{company.id}_layout" t-if="custom_header">
                 <div class="o_boxed_header">
-                    <t t-if="custom_header" t-call="#{custom_header}"/>
+                    <t t-call="#{custom_header}"/>
                 </div>
             </div>
         </div>
@@ -66,8 +66,8 @@
             <attribute name="t-if">not custom_footer</attribute>
         </div>
         <div t-attf-class="footer o_boxed_footer o_company_#{company.id}_layout" position="after">
-            <div t-attf-class="footer o_boxed_footer o_company_#{company.id}_layout">
-                <t t-if="custom_footer" t-out="custom_footer"/>
+            <div t-attf-class="footer o_boxed_footer o_company_#{company.id}_layout" t-if="custom_footer">
+                <t t-out="custom_footer"/>
             </div>
         </div>
     </template>
@@ -78,9 +78,9 @@
             <attribute name="t-if">not custom_header</attribute>
         </div>
         <div t-attf-class="o_company_#{company.id}_layout header" position="after">
-            <div t-attf-class="o_company_#{company.id}_layout header">
+            <div t-attf-class="o_company_#{company.id}_layout header" t-if="custom_header">
                 <div class="o_background_header">
-                    <t t-if="custom_header" t-call="#{custom_header}"/>
+                    <t t-call="#{custom_header}"/>
                 </div>
             </div>
         </div>
@@ -90,8 +90,8 @@
             <attribute name="t-if">not custom_footer</attribute>
         </div>
         <div t-attf-class="o_company_#{company.id}_layout footer o_background_footer" position="after">
-            <div t-attf-class="o_company_#{company.id}_layout footer o_background_footer">
-                <t t-if="custom_footer" t-out="custom_footer"/>
+            <div t-attf-class="o_company_#{company.id}_layout footer o_background_footer" t-if="custom_footer">
+                <t t-out="custom_footer"/>
             </div>
         </div>
     </template>