From 2524373688942e25edc947be9feac733052aa134 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Warnon?= <awa@odoo.com>
Date: Fri, 22 Feb 2019 12:14:34 +0000
Subject: [PATCH] [REF] website_slides: introduce a slide_icon template

Purpose
=======

This commit introduces an icon template to factorize some xml code.
It also correctly overrides this template in website_slides_survey to add
the 'certification' case.

Commit linked to task ID 1942852 and PR #31394.
---
 .../views/website_slides_templates_course.xml | 17 ++++++++++-------
 .../views/website_slides_templates_lesson.xml | 19 ++++++-------------
 addons/website_slides_survey/__manifest__.py  |  1 +
 .../views/website_slides_templates_course.xml | 10 ++++++++++
 4 files changed, 27 insertions(+), 20 deletions(-)
 create mode 100644 addons/website_slides_survey/views/website_slides_templates_course.xml

diff --git a/addons/website_slides/views/website_slides_templates_course.xml b/addons/website_slides/views/website_slides_templates_course.xml
index dd3db997ac9..21217d36319 100644
--- a/addons/website_slides/views/website_slides_templates_course.xml
+++ b/addons/website_slides/views/website_slides_templates_course.xml
@@ -307,13 +307,7 @@
         class="o_wslides_slides_list_slide d-flex justify-content-between align-items-center p-2">
         <div class="ml-2">
             <i t-if="channel.can_publish" class="fa fa-arrows mr-2 text-muted"></i>
-            <i t-if="slide.slide_type == 'document'" class="fa fa-file-pdf-o mr-2 text-muted"></i>
-            <i t-if="slide.slide_type == 'infographic'" class="fa fa-file-picture-o mr-2 text-muted"></i>
-            <i t-if="slide.slide_type == 'video'" class="fa fa-play-circle mr-2 text-muted"></i>
-            <i t-if="slide.slide_type == 'link'" class="fa fa-file-code-o mr-2 text-muted"></i>
-            <i t-if="slide.slide_type == 'webpage'" class="fa fa-file-text mr-2 text-muted"></i>
-            <i t-if="slide.slide_type == 'quiz'" class="fa fa-question-circle mr-2 text-muted"></i>
-            <i t-if="slide.slide_type == 'certification'" class="fa fa-trophy mr-2 text-muted"></i>
+            <t t-call="website_slides.slide_icon"/>
             <a class="o_wslides_slides_list_slide_link" t-attf-href="/slides/slide/#{slug(slide)}"><span t-field="slide.name"/></a>
         </div>
         <div class="o_wslides_slides_list_slide_controls mr-2">
@@ -473,4 +467,13 @@
     </div>
 </template>
 
+<template id="slide_icon">
+    <i t-if="slide.slide_type == 'document'" class="fa fa-file-pdf-o mr-2 text-muted"></i>
+    <i t-if="slide.slide_type == 'infographic'" class="fa fa-file-picture-o mr-2 text-muted"></i>
+    <i t-if="slide.slide_type == 'video'" class="fa fa-play-circle mr-2 text-muted"></i>
+    <i t-if="slide.slide_type == 'link'" class="fa fa-file-code-o mr-2 text-muted"></i>
+    <i t-if="slide.slide_type == 'webpage'" class="fa fa-file-text mr-2 text-muted"></i>
+    <i t-if="slide.slide_type == 'quiz'" class="fa fa-question-circle mr-2 text-muted"></i>
+</template>
+
 </data></odoo>
diff --git a/addons/website_slides/views/website_slides_templates_lesson.xml b/addons/website_slides/views/website_slides_templates_lesson.xml
index 41ab842a74a..22f5882ce40 100644
--- a/addons/website_slides/views/website_slides_templates_lesson.xml
+++ b/addons/website_slides/views/website_slides_templates_lesson.xml
@@ -433,12 +433,9 @@
                 <a t-attf-href="/slides/slide/#{slug(course_slide)}" t-att-index="i" t-att-slide_id="course_slide.id">
                     <div  t-attf-index="#{i}" t-attf-slide_id="#{course_slide.id}"  t-attf-class="#{'active' if slide.id == course_slide.id else ''} d-flex justify-content-between">
                         <div>
-                            <i t-if="course_slide.slide_type == 'presentation'" class="fa fa-file-pdf-o mr-2 text-muted"></i>
-                            <i t-if="course_slide.slide_type == 'infographic'" class="fa fa-file-picture-o mr-2 text-muted"></i>
-                            <i t-if="course_slide.slide_type == 'video'" class="fa fa-play-circle mr-2 text-muted"></i>
-                            <i t-if="course_slide.slide_type == 'link'" class="fa fa-file-code-o mr-2 text-muted"></i>
-                            <i t-if="course_slide.slide_type == 'webpage'" class="fa fa-file-text mr-2 text-muted"></i>
-                            <i t-if="course_slide.slide_type == 'quiz'" class="fa fa-question-circle mr-2 text-muted"></i>
+                            <t t-call="website_slides.slide_icon">
+                                <t t-set="slide" t-value="course_slide" />
+                            </t>
                             <t t-esc="course_slide.name"/>
                         </div>
                         <div class="o_wslides_slides_list_slide_controls mr-2">
@@ -545,13 +542,9 @@
                             t-att-data-embed_code="course_slide.embed_code"
                             t-attf-class="o_wslides_fs_sidebar_slide_tab #{'active' if slide.id == course_slide.id else ''} d-flex justify-content-between">
                             <div>
-                                <i t-if="course_slide.slide_type == 'document'" class="fa fa-file-pdf-o mr-2 text-muted"></i>
-                                <i t-if="course_slide.slide_type == 'infographic'" class="fa fa-file-picture-o mr-2 text-muted"></i>
-                                <i t-if="course_slide.slide_type == 'video'" class="fa fa-play-circle mr-2 text-muted"></i>
-                                <i t-if="course_slide.slide_type == 'link'" class="fa fa-file-code-o mr-2 text-muted"></i>
-                                <i t-if="course_slide.slide_type == 'webpage'" class="fa fa-file-text mr-2 text-muted"></i>
-                                <i t-if="course_slide.slide_type == 'quiz'" class="fa fa-question-circle mr-2 text-muted"></i>
-                                <i t-if="course_slide.slide_type == 'certification'" class="fa fa-trophy mr-2 text-muted"></i>
+                                <t t-call="website_slides.slide_icon">
+                                    <t t-set="slide" t-value="course_slide" />
+                                </t>
                                 <t t-esc="course_slide.name"/>
                             </div>
                         </div>
diff --git a/addons/website_slides_survey/__manifest__.py b/addons/website_slides_survey/__manifest__.py
index 93c6b3159dd..71d793d7e6a 100644
--- a/addons/website_slides_survey/__manifest__.py
+++ b/addons/website_slides_survey/__manifest__.py
@@ -13,6 +13,7 @@
         'views/assets.xml',
         'views/slide_channel_views.xml',
         'views/slide_slide_views.xml',
+        'views/website_slides_templates_course.xml',
         'views/website_slides_templates.xml',
         'views/website_slides_templates_homepage.xml',
         'views/survey_templates.xml',
diff --git a/addons/website_slides_survey/views/website_slides_templates_course.xml b/addons/website_slides_survey/views/website_slides_templates_course.xml
new file mode 100644
index 00000000000..95cef917fbd
--- /dev/null
+++ b/addons/website_slides_survey/views/website_slides_templates_course.xml
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <data>
+        <template id="slide_icon_inherit_survey" inherit_id="website_slides.slide_icon">
+            <xpath expr="//i[last()]" position="after">
+                <i t-if="slide.slide_type == 'certification'" class="fa fa-trophy mr-2 text-muted"></i>
+            </xpath>
+        </template>
+    </data>
+</odoo>