From 244556ac5f4cf2e9cea2968dc4a0427bdd108c4a Mon Sep 17 00:00:00 2001 From: Damien Bouvy Date: Wed, 7 Oct 2015 11:05:44 +0200 Subject: [PATCH] [FIX] sale_service: do not remove an existing value for so_line in account.analytic.line When looking for a so_line linked to the task, the sale_service module accidentaly removed the already referenced so_line. The desired behaviour is: 1/ Check if task is linked to so_line, if yes reference it 2/ If not, then let the dict as it was before, do not put False if there already was a value (for example something that sale_timesheet might have found) --- addons/sale_service/models/timesheet.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/sale_service/models/timesheet.py b/addons/sale_service/models/timesheet.py index f4f235a8872..d9de3af5e9c 100644 --- a/addons/sale_service/models/timesheet.py +++ b/addons/sale_service/models/timesheet.py @@ -58,7 +58,7 @@ class account_analytic_line(models.Model): def _update_values(self, values): if values.get('task_id', False): task = self.env['project.task'].browse(values['task_id']) - values['so_line'] = task.sale_line_id and task.sale_line_id.id or False + values['so_line'] = task.sale_line_id and task.sale_line_id.id or values.get('so_line', False) @api.model def create(self, values):