From 23d1bb8ea12ba72c3644add9dff860b47f7053e1 Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Mon, 13 May 2019 08:52:37 +0000 Subject: [PATCH] [FIX] calendar: make get_next_potential_limit_alarm private MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Even if data is not really sensitive, there are no reason to let it public. closes odoo/odoo#33326 Signed-off-by: Jérémy Kersten (jke) --- addons/calendar/models/calendar.py | 6 +++--- addons/calendar_sms/models/calendar.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/calendar/models/calendar.py b/addons/calendar/models/calendar.py index 957bb1bdc61..7f257e3d19f 100644 --- a/addons/calendar/models/calendar.py +++ b/addons/calendar/models/calendar.py @@ -243,7 +243,7 @@ class AlarmManager(models.AbstractModel): _name = 'calendar.alarm_manager' _description = 'Event Alarm Manager' - def get_next_potential_limit_alarm(self, alarm_type, seconds=None, partner_id=None): + def _get_next_potential_limit_alarm(self, alarm_type, seconds=None, partner_id=None): result = {} delta_request = """ SELECT @@ -374,7 +374,7 @@ class AlarmManager(models.AbstractModel): cron_interval = cron.interval_number * interval_to_second[cron.interval_type] - all_meetings = self.get_next_potential_limit_alarm('email', seconds=cron_interval) + all_meetings = self._get_next_potential_limit_alarm('email', seconds=cron_interval) for meeting in self.env['calendar.event'].browse(all_meetings): max_delta = all_meetings[meeting.id]['max_duration'] @@ -404,7 +404,7 @@ class AlarmManager(models.AbstractModel): if not partner: return [] - all_meetings = self.get_next_potential_limit_alarm('notification', partner_id=partner.id) + all_meetings = self._get_next_potential_limit_alarm('notification', partner_id=partner.id) time_limit = 3600 * 24 # return alarms of the next 24 hours for event_id in all_meetings: max_delta = all_meetings[event_id]['max_duration'] diff --git a/addons/calendar_sms/models/calendar.py b/addons/calendar_sms/models/calendar.py index 1f87174e150..65cd1a8cad5 100644 --- a/addons/calendar_sms/models/calendar.py +++ b/addons/calendar_sms/models/calendar.py @@ -52,7 +52,7 @@ class AlarmManager(models.AbstractModel): } cron_interval = cron.interval_number * interval_to_second[cron.interval_type] - events_data = self.get_next_potential_limit_alarm('sms', seconds=cron_interval) + events_data = self._get_next_potential_limit_alarm('sms', seconds=cron_interval) for event in self.env['calendar.event'].browse(events_data): max_delta = events_data[event.id]['max_duration']