From 2347da9a6e536154a76f7cd3cbeb4c49f910d784 Mon Sep 17 00:00:00 2001 From: alsh-odoo Date: Thu, 30 Nov 2023 11:37:18 +0530 Subject: [PATCH] [FIX] website_sale: fix traceback when selecting a product in website This traceback arises when the user selects a product in website. To reproduce this issue: 1) Install 'website_sale' 2) Open website and click on shop 3) Set duration and click on any product category(eg: desk) 4) A traceback appears Error:'UnboundLocalError: local variable 'all_tags' referenced before assignment' On 'shop' method 'all_tags' was referenced before assignment form here https://github.com/odoo/odoo/blob/5ba7e9e16c45ba618bb728f336102454d844d144/addons/website_sale/controllers/main.py#L480-L481 sentry-4680583793 closes odoo/odoo#144297 Signed-off-by: Victor Feyens (vfe) --- addons/website_sale/controllers/main.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/website_sale/controllers/main.py b/addons/website_sale/controllers/main.py index 5bc5bcd739c..a662a227b74 100644 --- a/addons/website_sale/controllers/main.py +++ b/addons/website_sale/controllers/main.py @@ -398,14 +398,16 @@ class WebsiteSale(payment_portal.PaymentPortal): max_price = max_price if max_price >= available_min_price else available_max_price post['max_price'] = max_price + ProductTag = request.env['product.tag'] if filter_by_tags_enabled and search_product: - ProductTag = request.env['product.tag'] all_tags = ProductTag.search( expression.AND([ [('product_ids.is_published', '=', True), ('visible_on_ecommerce', '=', True)], website_domain ]) ) + else: + all_tags = ProductTag categs_domain = [('parent_id', '=', False)] + website_domain if search: