From 22fa09f63ec91c1fe06029b75eaacc66325b2c07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Theys?= Date: Fri, 16 Jun 2023 09:18:14 +0000 Subject: [PATCH] [FIX] mail: fix message create returning proxified version Double assignation does not chain, resulting in the non proxified message being returned, which can potentially cause issues either when comparing messages by reference or if a reactive version is expected. X-original-commit: 30a77cb2778ec0fce5892cfd3903aa1982825626 Part-of: odoo/odoo#125439 --- addons/mail/static/src/core/common/message_service.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/mail/static/src/core/common/message_service.js b/addons/mail/static/src/core/common/message_service.js index 7275684fd3f..1693449a478 100644 --- a/addons/mail/static/src/core/common/message_service.js +++ b/addons/mail/static/src/core/common/message_service.js @@ -218,7 +218,8 @@ export class MessageService { } else { message = new Message(); message._store = this.store; - message = this.store.messages[data.id] = message; + this.store.messages[data.id] = message; + message = this.store.messages[data.id]; } this.update(message, data); // return reactive version