From 228a5041bf7a88c080a6f091ef02c028db2e0f02 Mon Sep 17 00:00:00 2001
From: Nicolas Lempereur <nle@odoo.com>
Date: Fri, 8 Mar 2019 07:50:16 +0000
Subject: [PATCH] [FIX] stock_landed_costs: service and landed cost

In saas-11.3 "Is a Landed Cost" (landed_cost_ok) was moved from the
product accounting tab, to the inventory tab.

The inventory tab is only shown for product not of type service, but the
field should be shown when product is of type service, consu or product.

With this changeset, "Is a Landed Cost" is displayed in the top and
"Split Method" is hidden: to specify the split method, this needs to be
done from products in Inventory > Configuration > Landed Cost Types, or
by the list view of cost lines when creating a landed cost.

opw-1949329
closes #31714

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
---
 addons/stock_landed_costs/views/product_views.xml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/addons/stock_landed_costs/views/product_views.xml b/addons/stock_landed_costs/views/product_views.xml
index 3d71a3097f6..c52baf03822 100644
--- a/addons/stock_landed_costs/views/product_views.xml
+++ b/addons/stock_landed_costs/views/product_views.xml
@@ -7,11 +7,16 @@
             <field name="inherit_id" ref="purchase.view_product_supplier_inherit"/>
             <field name="arch" type="xml">
                 <xpath expr="//group[@name='inventory']" position="inside">
-                    <group string="Inventory Valuation" name="inventory_valuation">
-                        <field name="landed_cost_ok" class="oe_inline" attrs="{'invisible':[('type', 'not in', ['product', 'consu', 'service'])]}"/>
-                        <field name="split_method" attrs="{'invisible':['|', ('landed_cost_ok', '=' ,False), ('type', 'not in', ['product', 'consu', 'service'])]}"/>
+                    <group string="Inventory Valuation" name="inventory_valuation" invisible="1">
+                        <field name="split_method" invisible="1"/>
                     </group>
                 </xpath>
+                <div name="options" position="inside">
+                    <div attrs="{'invisible':[('type', 'not in', ['product', 'consu', 'service'])]}">
+                        <field name="landed_cost_ok"/>
+                        <label for="landed_cost_ok"/>
+                    </div>
+                </div>
             </field>
         </record>
     </data>