From 208287385ea95ae2751af6fbe1e161d4f4e496e8 Mon Sep 17 00:00:00 2001 From: mgh-odoo Date: Tue, 16 Apr 2019 12:33:34 +0000 Subject: [PATCH] [FIX] base_gengo: private key password field MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, the gengo private password was displayed in plaintext in edit mode. This is due to text fields being rendered as `textarea` in edit mode, which does not support the "password" type. This commit fixes the issue by turning this field to `Char`, so that it is rendered as `input` with type "password" in edit mode. The loss of multi-line from `textarea` is not a big deal, because gengo passwords are not that long. Task-ID 1892058 closes odoo/odoo#32725 Signed-off-by: Alexandre Kühn (aku) --- addons/base_gengo/models/res_company.py | 2 +- addons/base_gengo/models/res_config_settings.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/base_gengo/models/res_company.py b/addons/base_gengo/models/res_company.py index d5409dcbd46..5b1a8a788a4 100644 --- a/addons/base_gengo/models/res_company.py +++ b/addons/base_gengo/models/res_company.py @@ -7,7 +7,7 @@ from odoo import fields, models class res_company(models.Model): _inherit = "res.company" - gengo_private_key = fields.Text(string="Gengo Private Key", copy=False, groups="base.group_system") + gengo_private_key = fields.Char(string="Gengo Private Key", copy=False, groups="base.group_system") gengo_public_key = fields.Text(string="Gengo Public Key", copy=False, groups="base.group_user") gengo_comment = fields.Text(string="Comments", groups="base.group_user", help="This comment will be automatically be enclosed in each an every request sent to Gengo") diff --git a/addons/base_gengo/models/res_config_settings.py b/addons/base_gengo/models/res_config_settings.py index 78161d21429..7482bd70234 100644 --- a/addons/base_gengo/models/res_config_settings.py +++ b/addons/base_gengo/models/res_config_settings.py @@ -7,7 +7,7 @@ from odoo import api, models, fields class ResConfigSettings(models.TransientModel): _inherit = 'res.config.settings' - gengo_private_key = fields.Text(string="Gengo Private Key", related="company_id.gengo_private_key", readonly=False) + gengo_private_key = fields.Char(string="Gengo Private Key", related="company_id.gengo_private_key", readonly=False) gengo_public_key = fields.Text(string="Gengo Public Key", related="company_id.gengo_public_key", readonly=False) gengo_comment = fields.Text(string="Comments", related="company_id.gengo_comment", help="This comment will be automatically be enclosed in each an every request sent to Gengo")