From 1f0e8402389cba3a3cdbc1287e8a38926f3c3c3f Mon Sep 17 00:00:00 2001
From: FrancoisGe <fge@odoo.com>
Date: Wed, 7 Dec 2022 08:41:51 +0000
Subject: [PATCH] [IMP] *: converting custom list views adding a doAction
 button

In this commit, we will convert all the customisations of the list view
consist in adding an always present button in the control panel that
performs an action/calls a model's method.

To do this, we will use the new display="always" parameter applicable
to buttons in the header of list views. This allows us to define a
button that is always visible in a list view.

closes odoo/odoo#106519

Taskid: 3082303
Related: odoo/enterprise#34387
Related: odoo/documentation#3044
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 addons/crm_iap_mine/models/crm_lead.py        | 12 ++++++-
 .../static/src/views/generate_leads_views.js  | 16 ---------
 .../static/src/views/generate_leads_views.xml |  7 ----
 addons/crm_iap_mine/views/crm_lead_views.xml  | 12 ++++---
 addons/hr_expense/static/src/views/list.js    | 12 -------
 addons/hr_expense/static/src/views/list.xml   |  7 ----
 addons/hr_expense/views/hr_expense_views.xml  |  3 ++
 addons/mass_mailing/models/mailing_contact.py |  6 ++++
 .../src/views/mailing_contact_view_list.js    | 34 -------------------
 .../static/src/views/mass_mailing_views.xml   |  8 -----
 .../views/mailing_contact_views.xml           |  1 +
 addons/stock/models/stock_quant.py            | 18 ++++++++++
 .../src/views/list/inventory_report_list.xml  |  4 ---
 .../list/inventory_report_list_controller.js  | 23 -------------
 addons/stock/views/stock_quant_views.xml      | 16 +++++++++
 addons/stock_account/__manifest__.py          |  1 -
 .../models/stock_valuation_layer.py           | 18 ++++++++++
 .../static/src/xml/inventory_report.xml       | 13 -------
 .../views/stock_valuation_layer_views.xml     |  6 ++++
 19 files changed, 87 insertions(+), 130 deletions(-)
 delete mode 100644 addons/mass_mailing/static/src/views/mailing_contact_view_list.js
 delete mode 100644 addons/stock_account/static/src/xml/inventory_report.xml

diff --git a/addons/crm_iap_mine/models/crm_lead.py b/addons/crm_iap_mine/models/crm_lead.py
index 96361b11332..378aa71203f 100644
--- a/addons/crm_iap_mine/models/crm_lead.py
+++ b/addons/crm_iap_mine/models/crm_lead.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
-from odoo import fields, models
+from odoo import fields, models, _
 
 
 class Lead(models.Model):
@@ -11,3 +11,13 @@ class Lead(models.Model):
 
     def _merge_get_fields(self):
         return super(Lead, self)._merge_get_fields() + ['lead_mining_request_id']
+
+    def action_generate_leads(self):
+        return {
+            "name": _("Generate Leads"),
+            "type": "ir.actions.act_window",
+            "res_model": "crm.iap.lead.mining.request",
+            "target": "new",
+            "views": [[False, "form"]],
+            "context": {"is_modal": True},
+        }
diff --git a/addons/crm_iap_mine/static/src/views/generate_leads_views.js b/addons/crm_iap_mine/static/src/views/generate_leads_views.js
index d921b64b930..5bfce77a4c6 100644
--- a/addons/crm_iap_mine/static/src/views/generate_leads_views.js
+++ b/addons/crm_iap_mine/static/src/views/generate_leads_views.js
@@ -1,24 +1,8 @@
 /** @odoo-module **/
 
-import { registry } from "@web/core/registry";
 import { patch } from "@web/core/utils/patch";
 import { useGenerateLeadsButton } from "@crm_iap_mine/views/generate_leads_hook";
 import { crmKanbanView } from "@crm/views/crm_kanban/crm_kanban_view";
-import { ListController } from "@web/views/list/list_controller";
-import { listView } from "@web/views/list/list_view";
-
-export class LeadMiningRequestListController extends ListController {
-    setup() {
-        super.setup();
-        useGenerateLeadsButton();
-    }
-}
-
-registry.category("views").add("crm_iap_lead_mining_request_tree", {
-    ...listView,
-    Controller: LeadMiningRequestListController,
-    buttonTemplate: "LeadMiningRequestListView.buttons",
-});
 
 patch(crmKanbanView.Controller.prototype, "crm_iap_lead_mining_request_kanban", {
     setup() {
diff --git a/addons/crm_iap_mine/static/src/views/generate_leads_views.xml b/addons/crm_iap_mine/static/src/views/generate_leads_views.xml
index 0260b66191e..ec403c39c41 100644
--- a/addons/crm_iap_mine/static/src/views/generate_leads_views.xml
+++ b/addons/crm_iap_mine/static/src/views/generate_leads_views.xml
@@ -7,13 +7,6 @@
         </button>
     </t>
 
-    <t t-name="LeadMiningRequestListView.buttons" t-inherit="web.ListView.Buttons" t-inherit-mode="primary" owl="1">
-        <!-- Before the export button -->
-        <xpath expr="//t[contains(@t-if, 'isExportEnable')]" position="before">
-            <t t-call="LeadMiningRequest.generate_leads_button"/>
-        </xpath>
-    </t>
-
     <t t-name="LeadMiningRequestKanbanView.buttons" t-inherit="web.KanbanView.Buttons" t-inherit-mode="primary" owl="1">
         <xpath expr="//div[@t-if='props.showButtons']" position="inside">
             <t t-call="LeadMiningRequest.generate_leads_button"/>
diff --git a/addons/crm_iap_mine/views/crm_lead_views.xml b/addons/crm_iap_mine/views/crm_lead_views.xml
index 2c481f044a3..be7b5f3c04b 100644
--- a/addons/crm_iap_mine/views/crm_lead_views.xml
+++ b/addons/crm_iap_mine/views/crm_lead_views.xml
@@ -6,8 +6,9 @@
         <field name="model">crm.lead</field>
         <field name="inherit_id" ref="crm.crm_case_tree_view_oppor" />
         <field name="arch" type="xml">
-            <xpath expr="//tree" position="attributes">
-                <attribute name="js_class">crm_iap_lead_mining_request_tree</attribute>
+            <xpath expr="//header" position="inside">
+                <button name="action_generate_leads" type="object" class="o_button_generate_leads"
+                        string="Generate Leads" groups="sales_team.group_sale_manager" display="always"/>
             </xpath>
         </field>
     </record>
@@ -17,8 +18,11 @@
         <field name="model">crm.lead</field>
         <field name="inherit_id" ref="crm.crm_case_tree_view_leads" />
         <field name="arch" type="xml">
-            <xpath expr="//tree" position="attributes">
-                <attribute name="js_class">crm_iap_lead_mining_request_tree</attribute>
+            <xpath expr="//tree" position="inside">
+                <header>
+                    <button name="action_generate_leads" type="object" class="o_button_generate_leads"
+                            string="Generate Leads" groups="sales_team.group_sale_manager" display="always"/>
+                </header>
             </xpath>
         </field>
     </record>
diff --git a/addons/hr_expense/static/src/views/list.js b/addons/hr_expense/static/src/views/list.js
index f9e97abca9a..2f7492e2649 100644
--- a/addons/hr_expense/static/src/views/list.js
+++ b/addons/hr_expense/static/src/views/list.js
@@ -22,7 +22,6 @@ export class ExpenseListController extends ListController {
         this.rpc = useService("rpc");
         this.user = useService("user");
         this.isExpenseSheet = this.model.rootParams.resModel === "hr.expense.sheet";
-        this.isExpense = this.model.rootParams.resModel === "hr.expense";
 
         onWillStart(async () => {
             this.is_expense_team_approver = await this.user.hasGroup("hr_expense.group_hr_expense_team_approver");
@@ -30,10 +29,6 @@ export class ExpenseListController extends ListController {
         });
     }
 
-    displayCreateReport() {
-        return this.isExpense;
-    }
-
     displaySubmit() {
         const records = this.model.root.selection;
         return records.length && records.every(record => record.data.state === 'draft') && this.isExpenseSheet;
@@ -59,13 +54,6 @@ export class ExpenseListController extends ListController {
         this.render(true);
     }
 
-    async onCreateReportClick() {
-        const records = this.model.root.selection;
-        const recordIds = records.map((a) => a.resId);
-        const action = await this.orm.call('hr.expense', 'get_expenses_to_submit', [recordIds]);
-        this.actionService.doAction(action);
-    }
-
 }
 patch(ExpenseListController.prototype, 'expense_list_controller_upload', ExpenseDocumentUpload);
 
diff --git a/addons/hr_expense/static/src/views/list.xml b/addons/hr_expense/static/src/views/list.xml
index 0d0df139709..e4e0080f8c0 100644
--- a/addons/hr_expense/static/src/views/list.xml
+++ b/addons/hr_expense/static/src/views/list.xml
@@ -13,13 +13,6 @@
             <input type="file" name="ufile" class="d-none" t-ref="fileInput" multiple="1" accept="*" t-on-change="onChangeFileInput"/>
         </xpath>
 
-        <!-- hr.expense -->
-        <xpath expr="//button[hasclass('o_button_upload_expense')]" position="after">
-            <button t-if="displayCreateReport()" class="d-none d-md-block btn btn-secondary" t-on-click="onCreateReportClick">
-                Create Report
-            </button>
-        </xpath>
-
         <!-- hr.expense.sheet -->
         <xpath expr="//button[hasclass('o_button_upload_expense')]" position="after">
             <button t-if="displaySubmit()" class="d-none d-md-block btn btn-secondary" t-on-click="() => this.onClick('action_submit_sheet')">
diff --git a/addons/hr_expense/views/hr_expense_views.xml b/addons/hr_expense/views/hr_expense_views.xml
index 2dc18165ab3..6e9dc194218 100644
--- a/addons/hr_expense/views/hr_expense_views.xml
+++ b/addons/hr_expense/views/hr_expense_views.xml
@@ -45,6 +45,9 @@
             <field name="model">hr.expense</field>
             <field name="arch" type="xml">
                 <tree string="Expenses" multi_edit="1" sample="1" js_class="hr_expense_tree" decoration-info="state == 'draft'">
+                    <header>
+                        <button name="get_expenses_to_submit" string="Create Report" type="object" display="always"/>
+                    </header>
                     <field name="company_id" invisible="1"/>
                     <field name="company_currency_id" invisible="1"/>
                     <field name="attachment_number" invisible="True"/>
diff --git a/addons/mass_mailing/models/mailing_contact.py b/addons/mass_mailing/models/mailing_contact.py
index 567bba5d1b3..6503d1e66d7 100644
--- a/addons/mass_mailing/models/mailing_contact.py
+++ b/addons/mass_mailing/models/mailing_contact.py
@@ -185,6 +185,12 @@ class MassMailingContact(models.Model):
             for r in self
         }
 
+    def action_import(self):
+        action = self.env["ir.actions.actions"]._for_xml_id("mass_mailing.mailing_contact_import_action")
+        action['context'] = self.env.context
+
+        return action
+
     def action_add_to_mailing_list(self):
         ctx = dict(self.env.context, default_contact_ids=self.ids)
         action = self.env["ir.actions.actions"]._for_xml_id("mass_mailing.mailing_contact_to_list_action")
diff --git a/addons/mass_mailing/static/src/views/mailing_contact_view_list.js b/addons/mass_mailing/static/src/views/mailing_contact_view_list.js
deleted file mode 100644
index 4370abdd157..00000000000
--- a/addons/mass_mailing/static/src/views/mailing_contact_view_list.js
+++ /dev/null
@@ -1,34 +0,0 @@
-/** @odoo-module **/
-
-import { ListController } from "@web/views/list/list_controller";
-import { listView } from '@web/views/list/list_view';
-import { registry } from '@web/core/registry';
-import { useService } from "@web/core/utils/hooks";
-
-/**
- * List view for the <mailing.contact> model.
- *
- * Add an import button to open the wizard <mailing.contact.import>. This wizard
- * allows the user to import contacts line by line.
- */
-export class MailingContactListController extends ListController {
-    async setup() {
-        super.setup();
-        this.actionService = useService("action");
-    }
-
-    onImport() {
-        const context = this.props.context;
-        const actionParams = { additionalContext: context };
-        if (!context.default_mailing_list_ids && context.active_model === 'mailing.list' && context.active_ids) {
-            actionParams.additionalContext.default_mailing_list_ids = context.active_ids;
-        }
-        this.actionService.doAction('mass_mailing.mailing_contact_import_action', actionParams);
-    }
-};
-
-registry.category('views').add('mailing_contact_list', {
-    ...listView,
-    Controller: MailingContactListController,
-    buttonTemplate: 'MailingContactListView.buttons',
-}); 
diff --git a/addons/mass_mailing/static/src/views/mass_mailing_views.xml b/addons/mass_mailing/static/src/views/mass_mailing_views.xml
index eeb4f72dc8e..68bf7388937 100644
--- a/addons/mass_mailing/static/src/views/mass_mailing_views.xml
+++ b/addons/mass_mailing/static/src/views/mass_mailing_views.xml
@@ -1,13 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <templates id="mailing_contact_views" xml:space="preserve">
-    <t t-name="MailingContactListView.buttons" t-inherit="web.ListView.Buttons" t-inherit-mode="primary" owl="1">
-        <xpath expr="//t[@t-if='props.showButtons']" position="inside">
-            <button type="button" class="btn btn-secondary o_mass_mailing_import_contact" t-on-click="onImport">
-                Import
-            </button>
-        </xpath>
-    </t>
-
     <t t-name="MailingContactKanbanView.buttons" t-inherit="web.KanbanView.Buttons" t-inherit-mode="primary" owl="1">
         <xpath expr="//div[@t-if='props.showButtons']" position="inside">
             <button type="button" class="btn btn-secondary o_mass_mailing_import_contact" t-on-click="onImport">
diff --git a/addons/mass_mailing/views/mailing_contact_views.xml b/addons/mass_mailing/views/mailing_contact_views.xml
index a835859719b..10734a5aee3 100644
--- a/addons/mass_mailing/views/mailing_contact_views.xml
+++ b/addons/mass_mailing/views/mailing_contact_views.xml
@@ -43,6 +43,7 @@
         <field name="arch" type="xml">
             <tree string="Mailing List Contacts" sample="1" multi_edit="1" js_class="mailing_contact_list">
                 <header>
+                    <button name="action_import" string="Import" type="object" display="always"/>
                     <button name="action_add_to_mailing_list" string="Add to List" type="object"/>
                 </header>
                 <field name="create_date" optional="show"/>
diff --git a/addons/stock/models/stock_quant.py b/addons/stock/models/stock_quant.py
index 0662cff9051..540530d0b59 100644
--- a/addons/stock/models/stock_quant.py
+++ b/addons/stock/models/stock_quant.py
@@ -430,6 +430,24 @@ class StockQuant(models.Model):
         self._apply_inventory()
         self.inventory_quantity_set = False
 
+    def action_inventory_at_date(self):
+        #  Handler called when the user clicked on the 'Inventory at Date' button.
+        #  Opens wizard to display, at choice, the products inventory or a computed
+        #  inventory at a given date.
+        context = {}
+        if ("default_product_id" in self.env.context):
+            context.product_id = self.env.context.default_product_id
+        elif ("product_tmpl_id" in self.env.context):
+            context.product_tmpl_id = self.env.context.product_tmpl_id
+
+        return {
+            "res_model": "stock.quantity.history",
+            "views": [[False, "form"]],
+            "target": "new",
+            "type": "ir.actions.act_window",
+            "context": context,
+        }
+
     def action_inventory_history(self):
         self.ensure_one()
         action = {
diff --git a/addons/stock/static/src/views/list/inventory_report_list.xml b/addons/stock/static/src/views/list/inventory_report_list.xml
index 581ac6683de..808c7353351 100644
--- a/addons/stock/static/src/views/list/inventory_report_list.xml
+++ b/addons/stock/static/src/views/list/inventory_report_list.xml
@@ -3,10 +3,6 @@
 
 <t t-name="InventoryReport.Buttons" t-inherit="web.ListView.Buttons" t-inherit-mode="primary" owl="1">
     <xpath expr="(//div/*)[last()]" position="after">
-        <button t-if="props.resModel == 'stock.quant' and (!props.context.inventory_mode or props.context.inventory_report_mode) and !props.context.no_at_date"
-            type="button" class="btn btn-primary o_button_at_date me-2" t-on-click="onClickInventoryAtDate">
-            Inventory at Date
-        </button>
         <button t-if="props.context.inventory_mode and !props.context.inventory_report_mode"
             class="btn btn-secondary" type="button" t-on-click="onClickApplyAll">
             Apply All
diff --git a/addons/stock/static/src/views/list/inventory_report_list_controller.js b/addons/stock/static/src/views/list/inventory_report_list_controller.js
index f4f1108f94a..d1043572a76 100644
--- a/addons/stock/static/src/views/list/inventory_report_list_controller.js
+++ b/addons/stock/static/src/views/list/inventory_report_list_controller.js
@@ -12,29 +12,6 @@ export class InventoryReportListController extends ListController {
         }
     }
 
-    /**
-     * Handler called when the user clicked on the 'Valuation at Date' button.
-     * Opens wizard to display, at choice, the products inventory or a computed
-     * inventory at a given date.
-     */
-    async onClickInventoryAtDate() {
-        const context = {
-            active_model: this.props.resModel,
-        };
-        if (this.props.context.default_product_id) {
-            context.product_id = this.props.context.default_product_id;
-        } else if (this.props.context.product_tmpl_id) {
-            context.product_tmpl_id = this.props.context.product_tmpl_id;
-        }
-        this.actionService.doAction({
-            res_model: "stock.quantity.history",
-            views: [[false, "form"]],
-            target: "new",
-            type: "ir.actions.act_window",
-            context,
-        });
-    }
-
     get actionMenuItems() {
         const actionMenus = super.actionMenuItems;
         if (
diff --git a/addons/stock/views/stock_quant_views.xml b/addons/stock/views/stock_quant_views.xml
index f43715274c2..d7e1947dc90 100644
--- a/addons/stock/views/stock_quant_views.xml
+++ b/addons/stock/views/stock_quant_views.xml
@@ -110,6 +110,12 @@
             <tree editable="bottom"
                   create="1" edit="1" js_class="inventory_report_list"
                   sample="1">
+                <header>
+                    <button name="action_inventory_at_date" string="Inventory at Date" type="object"
+                            invisible="((context.get('inventory_mode') and not context.get('inventory_report_mode')) or context.get('no_at_date'))"
+                            class="btn-primary ms-1"
+                            display="always"/>
+                </header>
                 <field name="create_date" invisible="1"/>
                 <field name="write_date" invisible="1"/>
                 <field name="id" invisible="1"/>
@@ -153,6 +159,12 @@
         <field name="arch" type="xml">
             <tree string="Inventory Valuation" js_class="inventory_report_list"
                   create="0" delete="0">
+                <header>
+                    <button name="action_inventory_at_date" string="Inventory at Date" type="object"
+                            invisible="((context.get('inventory_mode') and not context.get('inventory_report_mode')) or context.get('no_at_date'))"
+                            class="btn-primary ms-1"
+                            display="always"/>
+                </header>
                 <field name="product_id" invisible="context.get('single_product', False)"/>
                 <field name="location_id" invisible="context.get('hide_location', False)"/>
                 <field name="lot_id" groups="stock.group_production_lot"
@@ -354,6 +366,10 @@
         <field name="arch" type="xml">
             <tree default_order="location_id, inventory_date, product_id, package_id, lot_id, owner_id" decoration-warning='is_outdated' editable="bottom" create="1" edit="1" import="1" js_class="inventory_report_list" class="o_inventory_adjustments" sample="1">
                 <header>
+                    <button name="action_inventory_at_date" string="Inventory at Date" type="object"
+                            invisible="((context.get('inventory_mode') and not context.get('inventory_report_mode')) or context.get('no_at_date'))"
+                            class="btn-primary ms-1"
+                            display="always"/>
                     <button name="stock.action_stock_inventory_adjustement_name" groups="stock.group_stock_manager" type="action" string="Apply"/>
                     <button name="action_reset" type="object" string="Clear"/>
                     <button name="stock.action_stock_request_count" groups="stock.group_stock_manager" type="action" string="Request a Count"/>
diff --git a/addons/stock_account/__manifest__.py b/addons/stock_account/__manifest__.py
index 5e5055ef5fa..cc7397d68ef 100644
--- a/addons/stock_account/__manifest__.py
+++ b/addons/stock_account/__manifest__.py
@@ -44,7 +44,6 @@ Dashboard / Reports for Warehouse Management includes:
     'assets': {
         'web.assets_backend': [
             'stock_account/static/src/js/report_stock_forecasted.js',
-            'stock_account/static/src/xml/inventory_report.xml',
         ],
     },
     'license': 'LGPL-3',
diff --git a/addons/stock_account/models/stock_valuation_layer.py b/addons/stock_account/models/stock_valuation_layer.py
index 83e77585c71..5679d8194e7 100644
--- a/addons/stock_account/models/stock_valuation_layer.py
+++ b/addons/stock_account/models/stock_valuation_layer.py
@@ -71,6 +71,24 @@ class StockValuationLayer(models.Model):
             'res_id': self.id,
         }
 
+    def action_valuation_at_date(self):
+        #  Handler called when the user clicked on the 'Valuation at Date' button.
+        #  Opens wizard to display, at choice, the products inventory or a computed
+        #  inventory at a given date.
+        context = {}
+        if ("default_product_id" in self.env.context):
+            context.product_id = self.env.context.default_product_id
+        elif ("product_tmpl_id" in self.env.context):
+            context.product_tmpl_id = self.env.context.product_tmpl_id
+
+        return {
+            "res_model": "stock.quantity.history",
+            "views": [[False, "form"]],
+            "target": "new",
+            "type": "ir.actions.act_window",
+            "context": context,
+        }
+
     def action_open_reference(self):
         self.ensure_one()
         if self.stock_move_id:
diff --git a/addons/stock_account/static/src/xml/inventory_report.xml b/addons/stock_account/static/src/xml/inventory_report.xml
deleted file mode 100644
index d30138acc00..00000000000
--- a/addons/stock_account/static/src/xml/inventory_report.xml
+++ /dev/null
@@ -1,13 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<templates id="template" xml:space="preserve">
-
-<t t-inherit="stock.InventoryReport.Buttons" t-inherit-mode="extension" owl="1">
-    <xpath expr="//button[hasclass('o_button_at_date')]" position="after">
-        <button t-if="props.resModel == 'stock.valuation.layer'" type="button"
-            class="btn btn-primary o_button_at_date me-2" t-on-click="onClickInventoryAtDate">
-            Valuation at Date
-        </button>
-    </xpath>
-</t>
-
-</templates>
diff --git a/addons/stock_account/views/stock_valuation_layer_views.xml b/addons/stock_account/views/stock_valuation_layer_views.xml
index 25de3d93f92..c10975fed57 100644
--- a/addons/stock_account/views/stock_valuation_layer_views.xml
+++ b/addons/stock_account/views/stock_valuation_layer_views.xml
@@ -44,6 +44,12 @@
             <tree default_order="id desc" create="0"
                   import="0" js_class="inventory_report_list"
                   action="action_open_reference" type="object">
+                <header>
+                    <button name="action_valuation_at_date" string="Valuation at Date" type="object"
+                            invisible="((context.get('inventory_mode') and not context.get('inventory_report_mode')) or context.get('no_at_date'))"
+                            class="btn-primary ms-1"
+                            display="always"/>
+                </header>
                 <field name="create_date" string="Date" />
                 <field name="reference"/>
                 <button name="action_open_layer" icon="fa-arrow-right" title="Open Valuation Layer" type="object"/>